From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linus.walleij@stericsson.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Tue, 7 Aug 2012 18:03:34 +0100 [thread overview]
Message-ID: <20120807170333.GV16861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120807170129.GA3759@gmail.com>
On Tue, Aug 07, 2012 at 06:01:30PM +0100, Lee Jones wrote:
> Okay, so I've just spent a small amount of time looking at this. I think
> the best place for this would be in *_get_virq(), using the same logic that
> selected a *_legacy or *_linear domain in the first place. The only thing
> the domain can test for is the 'type' of domain and the requested IRQ. This
> is where the issue lies. If a hwirq to virq conversion is requested, but a
> virq is passed (which happens in the non-DT case) a WARN() is triggered
> because the irq passed is bigger than first_irq + size. I think *_get_virq()
> should ensure that only a hwirq is passed to irq_create_mapping().
> Let me know if you had other ideas.
I'd expect your driver to always pass a hwirq into _get_virq() here.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots
Date: Tue, 7 Aug 2012 18:03:34 +0100 [thread overview]
Message-ID: <20120807170333.GV16861@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120807170129.GA3759@gmail.com>
On Tue, Aug 07, 2012 at 06:01:30PM +0100, Lee Jones wrote:
> Okay, so I've just spent a small amount of time looking at this. I think
> the best place for this would be in *_get_virq(), using the same logic that
> selected a *_legacy or *_linear domain in the first place. The only thing
> the domain can test for is the 'type' of domain and the requested IRQ. This
> is where the issue lies. If a hwirq to virq conversion is requested, but a
> virq is passed (which happens in the non-DT case) a WARN() is triggered
> because the irq passed is bigger than first_irq + size. I think *_get_virq()
> should ensure that only a hwirq is passed to irq_create_mapping().
> Let me know if you had other ideas.
I'd expect your driver to always pass a hwirq into _get_virq() here.
next prev parent reply other threads:[~2012-08-07 17:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 12:32 [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots Lee Jones
2012-08-06 12:32 ` Lee Jones
2012-08-06 8:19 ` Dmitry Torokhov
2012-08-06 8:19 ` Dmitry Torokhov
2012-08-06 15:37 ` Lee Jones
2012-08-06 15:37 ` Lee Jones
2012-08-06 15:37 ` Lee Jones
2012-08-06 16:02 ` Mark Brown
2012-08-06 16:02 ` Mark Brown
2012-08-06 17:24 ` Lee Jones
2012-08-06 17:24 ` Lee Jones
2012-08-06 17:24 ` Lee Jones
2012-08-07 17:01 ` Lee Jones
2012-08-07 17:01 ` Lee Jones
2012-08-07 17:01 ` Lee Jones
2012-08-07 17:03 ` Mark Brown [this message]
2012-08-07 17:03 ` Mark Brown
2012-08-08 7:35 ` Lee Jones
2012-08-08 7:35 ` Lee Jones
2012-08-08 7:35 ` Lee Jones
2012-08-08 8:04 ` Lee Jones
2012-08-08 8:04 ` Lee Jones
2012-08-08 8:04 ` Lee Jones
2012-08-08 8:28 ` Arnd Bergmann
2012-08-08 8:28 ` Arnd Bergmann
2012-08-08 9:59 ` Mark Brown
2012-08-08 9:59 ` Mark Brown
2012-08-08 9:49 ` Mark Brown
2012-08-08 9:49 ` Mark Brown
2012-08-08 11:40 ` Lee Jones
2012-08-08 11:40 ` Lee Jones
2012-08-08 13:17 ` Mark Brown
2012-08-08 13:17 ` Mark Brown
2012-09-13 9:35 ` Linus Walleij
2012-09-13 9:35 ` Linus Walleij
2012-09-14 8:03 ` Lee Jones
2012-09-14 8:03 ` Lee Jones
2012-09-14 8:03 ` Lee Jones
2012-09-18 11:22 ` Linus Walleij
2012-09-18 11:22 ` Linus Walleij
2012-09-19 17:11 ` Dmitry Torokhov
2012-09-19 17:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807170333.GV16861@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.