From: Catalin Marinas <catalin.marinas@arm.com>
To: Michel Lespinasse <walken@google.com>
Cc: "riel@redhat.com" <riel@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"vrajesh@umich.edu" <vrajesh@umich.edu>,
"daniel.santos@pobox.com" <daniel.santos@pobox.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree
Date: Thu, 9 Aug 2012 09:31:28 +0100 [thread overview]
Message-ID: <20120809083127.GC14102@arm.com> (raw)
In-Reply-To: <CANN689EOZ64V_AO8B6N0-_B0_HdQZVk3dH8Ce5c=m5Q=ySDKUg@mail.gmail.com>
On Wed, Aug 08, 2012 at 06:07:39PM +0100, Michel Lespinasse wrote:
> kmemleak uses a tree where each node represents an allocated memory object
> in order to quickly find out what object a given address is part of.
> However, the objects don't overlap, so rbtrees are a better choice than
> prio tree for this use. They are both faster and have lower memory overhead.
>
> Tested by booting a kernel with kmemleak enabled, loading the kmemleak_test
> module, and looking for the expected messages.
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
The patch looks fine to me but I'll give it a test later today and let
you know.
--
Catalin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Michel Lespinasse <walken@google.com>
Cc: "riel@redhat.com" <riel@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"vrajesh@umich.edu" <vrajesh@umich.edu>,
"daniel.santos@pobox.com" <daniel.santos@pobox.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [PATCH 3/5] kmemleak: use rbtree instead of prio tree
Date: Thu, 9 Aug 2012 09:31:28 +0100 [thread overview]
Message-ID: <20120809083127.GC14102@arm.com> (raw)
In-Reply-To: <CANN689EOZ64V_AO8B6N0-_B0_HdQZVk3dH8Ce5c=m5Q=ySDKUg@mail.gmail.com>
On Wed, Aug 08, 2012 at 06:07:39PM +0100, Michel Lespinasse wrote:
> kmemleak uses a tree where each node represents an allocated memory object
> in order to quickly find out what object a given address is part of.
> However, the objects don't overlap, so rbtrees are a better choice than
> prio tree for this use. They are both faster and have lower memory overhead.
>
> Tested by booting a kernel with kmemleak enabled, loading the kmemleak_test
> module, and looking for the expected messages.
>
> Signed-off-by: Michel Lespinasse <walken@google.com>
The patch looks fine to me but I'll give it a test later today and let
you know.
--
Catalin
next prev parent reply other threads:[~2012-08-09 8:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 7:25 [PATCH 0/5] rbtree based interval tree as a prio_tree replacement Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-07 7:25 ` [PATCH 1/5] rbtree: add prio tree and interval tree tests Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-07 7:25 ` [PATCH 2/5] mm: replace vma prio_tree with an interval tree Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-14 12:11 ` Hillf Danton
2012-08-14 12:11 ` Hillf Danton
2012-08-07 7:25 ` [PATCH 3/5] kmemleak: use rbtree instead of prio tree Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-08 17:07 ` Michel Lespinasse
2012-08-08 17:07 ` Michel Lespinasse
2012-08-09 8:31 ` Catalin Marinas [this message]
2012-08-09 8:31 ` Catalin Marinas
2012-08-15 16:36 ` Catalin Marinas
2012-08-15 16:36 ` Catalin Marinas
2012-08-15 20:53 ` Michel Lespinasse
2012-08-15 20:53 ` Michel Lespinasse
2012-08-16 15:06 ` Catalin Marinas
2012-08-16 15:06 ` Catalin Marinas
2012-08-07 7:25 ` [PATCH 4/5] prio_tree: remove Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-07 7:25 ` [PATCH 5/5] rbtree: move augmented rbtree functionality to rbtree_augmented.h Michel Lespinasse
2012-08-07 7:25 ` Michel Lespinasse
2012-08-08 1:19 ` Michel Lespinasse
2012-08-08 1:19 ` Michel Lespinasse
2012-08-13 8:20 ` [PATCH 0/5] rbtree based interval tree as a prio_tree replacement Peter Zijlstra
2012-08-13 8:20 ` Peter Zijlstra
2012-08-13 10:37 ` Michel Lespinasse
2012-08-13 10:37 ` Michel Lespinasse
2012-08-30 21:34 ` Andrew Morton
2012-08-30 21:34 ` Andrew Morton
2012-08-30 21:43 ` Rik van Riel
2012-08-30 21:43 ` Rik van Riel
2012-08-30 22:33 ` Michel Lespinasse
2012-08-30 22:33 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809083127.GC14102@arm.com \
--to=catalin.marinas@arm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.santos@pobox.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=vrajesh@umich.edu \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.