From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
peterz@infradead.org, lkml <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>, Ingo Molnar <mingo@elte.hu>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 2/2] powerpc: Uprobes port to powerpc
Date: Wed, 15 Aug 2012 18:59:31 +0200 [thread overview]
Message-ID: <20120815165931.GA10059@redhat.com> (raw)
In-Reply-To: <20120726052029.GB29466@in.ibm.com>
On 07/26, Ananth N Mavinakayanahalli wrote:
>
> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>
> This is the port of uprobes to powerpc. Usage is similar to x86.
I am just curious why this series was ignored by powerpc maintainers...
Of course I can not review this code, I know nothing about powerpc,
but the patches look simple/straightforward.
Paul, Benjamin?
Just one question... Shouldn't arch_uprobe_pre_xol() forbid to probe
UPROBE_SWBP_INSN (at least) ?
(I assume that emulate_step() can't handle this case but of course I
do not understand arch/powerpc/lib/sstep.c)
Note that uprobe_pre_sstep_notifier() sets utask->state = UTASK_BP_HIT
without any checks. This doesn't look right if it was UTASK_SSTEP...
But again, I do not know what powepc will actually do if we try to
single-step over UPROBE_SWBP_INSN.
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
lkml <linux-kernel@vger.kernel.org>,
benh@kernel.crashing.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
michael@ellerman.id.au, Ingo Molnar <mingo@elte.hu>,
peterz@infradead.org,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 2/2] powerpc: Uprobes port to powerpc
Date: Wed, 15 Aug 2012 18:59:31 +0200 [thread overview]
Message-ID: <20120815165931.GA10059@redhat.com> (raw)
In-Reply-To: <20120726052029.GB29466@in.ibm.com>
On 07/26, Ananth N Mavinakayanahalli wrote:
>
> From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>
> This is the port of uprobes to powerpc. Usage is similar to x86.
I am just curious why this series was ignored by powerpc maintainers...
Of course I can not review this code, I know nothing about powerpc,
but the patches look simple/straightforward.
Paul, Benjamin?
Just one question... Shouldn't arch_uprobe_pre_xol() forbid to probe
UPROBE_SWBP_INSN (at least) ?
(I assume that emulate_step() can't handle this case but of course I
do not understand arch/powerpc/lib/sstep.c)
Note that uprobe_pre_sstep_notifier() sets utask->state = UTASK_BP_HIT
without any checks. This doesn't look right if it was UTASK_SSTEP...
But again, I do not know what powepc will actually do if we try to
single-step over UPROBE_SWBP_INSN.
Oleg.
next prev parent reply other threads:[~2012-08-15 17:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 5:19 [PATCH 1/2] powerpc: Add trap_nr to thread_struct Ananth N Mavinakayanahalli
2012-07-26 5:19 ` Ananth N Mavinakayanahalli
2012-07-26 5:20 ` [PATCH v3 2/2] powerpc: Uprobes port to powerpc Ananth N Mavinakayanahalli
2012-07-26 5:20 ` Ananth N Mavinakayanahalli
2012-07-27 8:40 ` Srikar Dronamraju
2012-07-27 8:40 ` Srikar Dronamraju
2012-08-15 16:59 ` Oleg Nesterov [this message]
2012-08-15 16:59 ` Oleg Nesterov
2012-08-15 21:41 ` Benjamin Herrenschmidt
2012-08-15 21:41 ` Benjamin Herrenschmidt
2012-08-16 5:00 ` Ananth N Mavinakayanahalli
2012-08-16 5:00 ` Ananth N Mavinakayanahalli
2012-08-16 15:21 ` Oleg Nesterov
2012-08-16 15:21 ` Oleg Nesterov
2012-08-17 5:13 ` Ananth N Mavinakayanahalli
2012-08-17 5:13 ` Ananth N Mavinakayanahalli
2012-08-17 15:00 ` Oleg Nesterov
2012-08-17 15:00 ` Oleg Nesterov
2012-08-21 11:24 ` Ananth N Mavinakayanahalli
2012-08-21 11:24 ` Ananth N Mavinakayanahalli
2012-08-21 13:09 ` Oleg Nesterov
2012-08-21 13:09 ` Oleg Nesterov
2012-08-22 8:32 ` Ananth N Mavinakayanahalli
2012-08-22 8:32 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120815165931.GA10059@redhat.com \
--to=oleg@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.