[PATCH] dma: amba-pl08x: Export pl08x_filter

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  8:56 ` Roland Stigge
  0 siblings, 0 replies; 14+ messages in thread
From: Roland Stigge @ 2012-08-16  8:56 UTC (permalink / raw)
  To: artem.bityutskiy, linux-arm-kernel, arnd, linux, linux-kernel,
	kevin.wells, srinivas.bakki, aletes.xgr, dwmw2, linux-mtd
  Cc: Roland Stigge

This patch fixes the following when compiling a driver module that uses
amba-pl08x:

ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!

(drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

Done as in:

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Signed-off-by: Roland Stigge <stigge@antcom.de>

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 6fbeebb..8c2e9b6 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1608,6 +1608,7 @@ bool pl08x_filter_id(struct dma_chan *chan, void *chan_id)
 
 	return false;
 }
+EXPORT_SYMBOL(pl08x_filter_id);
 
 /*
  * Just check that the device is there and active

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  8:56 ` Roland Stigge
  0 siblings, 0 replies; 14+ messages in thread
From: Roland Stigge @ 2012-08-16  8:56 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes the following when compiling a driver module that uses
amba-pl08x:

ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!

(drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

Done as in:

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Signed-off-by: Roland Stigge <stigge@antcom.de>

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 6fbeebb..8c2e9b6 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1608,6 +1608,7 @@ bool pl08x_filter_id(struct dma_chan *chan, void *chan_id)
 
 	return false;
 }
+EXPORT_SYMBOL(pl08x_filter_id);
 
 /*
  * Just check that the device is there and active

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
  2012-08-16  8:56 ` Roland Stigge
  (?)
@ 2012-08-16  8:59   ` Arnd Bergmann
  -1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  8:59 UTC (permalink / raw)
  To: Roland Stigge
  Cc: srinivas.bakki, linux, artem.bityutskiy, linux-kernel,
	kevin.wells, linux-mtd, aletes.xgr, dwmw2, linux-arm-kernel

On Thursday 16 August 2012, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> Done as in:
> 
> drivers/dma/coh901318.c
> drivers/dma/sirf-dma.c
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  8:59   ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  8:59 UTC (permalink / raw)
  To: Roland Stigge
  Cc: artem.bityutskiy, linux-arm-kernel, linux, linux-kernel,
	kevin.wells, srinivas.bakki, aletes.xgr, dwmw2, linux-mtd

On Thursday 16 August 2012, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> Done as in:
> 
> drivers/dma/coh901318.c
> drivers/dma/sirf-dma.c
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  8:59   ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  8:59 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 16 August 2012, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> Done as in:
> 
> drivers/dma/coh901318.c
> drivers/dma/sirf-dma.c
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
  2012-08-16  8:56 ` Roland Stigge
  (?)
@ 2012-08-16  9:00   ` Russell King - ARM Linux
  -1 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2012-08-16  9:00 UTC (permalink / raw)
  To: Roland Stigge
  Cc: srinivas.bakki, arnd, artem.bityutskiy, linux-kernel, kevin.wells,
	linux-mtd, aletes.xgr, dwmw2, linux-arm-kernel

On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

It is currently intended that this be passed from platform code into
drivers via platform data, so that drivers can decide which DMA engine
they wish to make use of.

See how all the AMBA drivers work in this regard (because they need to
support more than just a single DMA engine implementation.)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  9:00   ` Russell King - ARM Linux
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2012-08-16  9:00 UTC (permalink / raw)
  To: Roland Stigge
  Cc: artem.bityutskiy, linux-arm-kernel, arnd, linux-kernel,
	kevin.wells, srinivas.bakki, aletes.xgr, dwmw2, linux-mtd

On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

It is currently intended that this be passed from platform code into
drivers via platform data, so that drivers can decide which DMA engine
they wish to make use of.

See how all the AMBA drivers work in this regard (because they need to
support more than just a single DMA engine implementation.)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  9:00   ` Russell King - ARM Linux
  0 siblings, 0 replies; 14+ messages in thread
From: Russell King - ARM Linux @ 2012-08-16  9:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

It is currently intended that this be passed from platform code into
drivers via platform data, so that drivers can decide which DMA engine
they wish to make use of.

See how all the AMBA drivers work in this regard (because they need to
support more than just a single DMA engine implementation.)

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
  2012-08-16  9:00   ` Russell King - ARM Linux
  (?)
@ 2012-08-16  9:06     ` Arnd Bergmann
  -1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  9:06 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Roland Stigge, srinivas.bakki, artem.bityutskiy, linux-kernel,
	kevin.wells, linux-mtd, aletes.xgr, dwmw2, linux-arm-kernel

On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> > 
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> > 
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Ah, you're right, I forgot about that. I'll take back my Ack then.

	Arnd

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  9:06     ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  9:06 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Roland Stigge, artem.bityutskiy, linux-arm-kernel, linux-kernel,
	kevin.wells, srinivas.bakki, aletes.xgr, dwmw2, linux-mtd

On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> > 
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> > 
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Ah, you're right, I forgot about that. I'll take back my Ack then.

	Arnd

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16  9:06     ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2012-08-16  9:06 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> > 
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> > 
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Ah, you're right, I forgot about that. I'll take back my Ack then.

	Arnd

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
  2012-08-16  9:00   ` Russell King - ARM Linux
  (?)
@ 2012-08-16 13:13     ` Roland Stigge
  -1 siblings, 0 replies; 14+ messages in thread
From: Roland Stigge @ 2012-08-16 13:13 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: srinivas.bakki, arnd, artem.bityutskiy, linux-kernel, kevin.wells,
	linux-mtd, aletes.xgr, dwmw2, linux-arm-kernel

On 08/16/2012 11:00 AM, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
>> This patch fixes the following when compiling a driver module that uses
>> amba-pl08x:
>>
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
>>
>> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Thanks for the note!

I'll post respective changes to the MTD SLC and MLC drivers of LPC32xx
(for the MTD subsystem) and the adjustment I'll do in mach-lpc32xx (my
lpc32xx tree for arm-soc).

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16 13:13     ` Roland Stigge
  0 siblings, 0 replies; 14+ messages in thread
From: Roland Stigge @ 2012-08-16 13:13 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: artem.bityutskiy, linux-arm-kernel, arnd, linux-kernel,
	kevin.wells, srinivas.bakki, aletes.xgr, dwmw2, linux-mtd

On 08/16/2012 11:00 AM, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
>> This patch fixes the following when compiling a driver module that uses
>> amba-pl08x:
>>
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
>>
>> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Thanks for the note!

I'll post respective changes to the MTD SLC and MLC drivers of LPC32xx
(for the MTD subsystem) and the adjustment I'll do in mach-lpc32xx (my
lpc32xx tree for arm-soc).

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH] dma: amba-pl08x: Export pl08x_filter_id
@ 2012-08-16 13:13     ` Roland Stigge
  0 siblings, 0 replies; 14+ messages in thread
From: Roland Stigge @ 2012-08-16 13:13 UTC (permalink / raw)
  To: linux-arm-kernel

On 08/16/2012 11:00 AM, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
>> This patch fixes the following when compiling a driver module that uses
>> amba-pl08x:
>>
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
>>
>> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Thanks for the note!

I'll post respective changes to the MTD SLC and MLC drivers of LPC32xx
(for the MTD subsystem) and the adjustment I'll do in mach-lpc32xx (my
lpc32xx tree for arm-soc).

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2012-08-16 13:13 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-16  8:56 [PATCH] dma: amba-pl08x: Export pl08x_filter_id Roland Stigge
2012-08-16  8:56 ` Roland Stigge
2012-08-16  8:59 ` Arnd Bergmann
2012-08-16  8:59   ` Arnd Bergmann
2012-08-16  8:59   ` Arnd Bergmann
2012-08-16  9:00 ` Russell King - ARM Linux
2012-08-16  9:00   ` Russell King - ARM Linux
2012-08-16  9:00   ` Russell King - ARM Linux
2012-08-16  9:06   ` Arnd Bergmann
2012-08-16  9:06     ` Arnd Bergmann
2012-08-16  9:06     ` Arnd Bergmann
2012-08-16 13:13   ` Roland Stigge
2012-08-16 13:13     ` Roland Stigge
2012-08-16 13:13     ` Roland Stigge

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.