From: Felipe Balbi <balbi@ti.com>
To: "Poddar, Sourav" <sourav.poddar@ti.com>
Cc: balbi@ti.com, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature
Date: Tue, 21 Aug 2012 15:00:54 +0300 [thread overview]
Message-ID: <20120821120052.GD10347@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAKdam56DiFpnoQwrHe1tjQWLMy5vP9ynstNj_n=OyMxkJJAUOA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Hi,
On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote:
> >> + if (type & IRQ_TYPE_LEVEL_HIGH)
> >> + sg->int_lvl[bank] |= bit;
> >> + else if (type & IRQ_TYPE_LEVEL_LOW)
> >> + sg->int_lvl[bank] &= ~bit;
> >> + else
> >> + return -EINVAL;
> >
> > this looks wrong. You could have a user who wants to trigger on both
> > HIGH and LOW levels, no ?
> >
> Yes, I think there can be a scenario where gpio_keys are attached
> to this driver and signals a "key press" at low and "key release" at
> high. ?
> Will figure out a way to add support to check for case where
> both High and low levels are used.
could probably be done on a separate patch, maybe... Just now I saw that
HIGH and LOW levels use the same bit.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature
Date: Tue, 21 Aug 2012 15:00:54 +0300 [thread overview]
Message-ID: <20120821120052.GD10347@arwen.pp.htv.fi> (raw)
In-Reply-To: <CAKdam56DiFpnoQwrHe1tjQWLMy5vP9ynstNj_n=OyMxkJJAUOA@mail.gmail.com>
Hi,
On Tue, Aug 21, 2012 at 05:17:37PM +0530, Poddar, Sourav wrote:
> >> + if (type & IRQ_TYPE_LEVEL_HIGH)
> >> + sg->int_lvl[bank] |= bit;
> >> + else if (type & IRQ_TYPE_LEVEL_LOW)
> >> + sg->int_lvl[bank] &= ~bit;
> >> + else
> >> + return -EINVAL;
> >
> > this looks wrong. You could have a user who wants to trigger on both
> > HIGH and LOW levels, no ?
> >
> Yes, I think there can be a scenario where gpio_keys are attached
> to this driver and signals a "key press" at low and "key release" at
> high. ?
> Will figure out a way to add support to check for case where
> both High and low levels are used.
could probably be done on a separate patch, maybe... Just now I saw that
HIGH and LOW levels use the same bit.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120821/c672efb3/attachment.sig>
next prev parent reply other threads:[~2012-08-21 12:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 10:45 [PATCH 0/4] Add mfd driver for smsc-ece1099 chip Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
[not found] ` <1345545940-2232-2-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:42 ` Felipe Balbi
2012-08-21 12:42 ` Felipe Balbi
2012-08-21 13:22 ` Mark Brown
2012-08-21 13:22 ` Mark Brown
[not found] ` <20120821132222.GF7995-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:49 ` Mark Brown
2012-08-21 13:49 ` Mark Brown
2012-08-21 13:52 ` Felipe Balbi
2012-08-21 13:52 ` Felipe Balbi
2012-08-21 14:08 ` Mark Brown
2012-08-21 14:08 ` Mark Brown
2012-08-21 14:09 ` Felipe Balbi
2012-08-21 14:09 ` Felipe Balbi
2012-08-21 14:20 ` Mark Brown
2012-08-21 14:20 ` Mark Brown
2012-08-21 10:45 ` [PATCH 2/4] Input: keypad: Add smsc ece1099 keypad driver Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Felipe Balbi
2012-08-21 10:45 ` Felipe Balbi
2012-08-21 11:30 ` Poddar, Sourav
2012-08-21 11:30 ` Poddar, Sourav
2012-08-21 10:46 ` Felipe Balbi
2012-08-21 10:46 ` Felipe Balbi
2012-08-21 11:31 ` Poddar, Sourav
2012-08-21 11:31 ` Poddar, Sourav
2012-08-21 10:45 ` [PATCH 3/4] arm/dts: omap5-evm: Add keypad support Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:47 ` Felipe Balbi
2012-08-21 10:47 ` Felipe Balbi
2012-08-21 11:20 ` Poddar, Sourav
2012-08-21 11:20 ` Poddar, Sourav
2012-08-21 10:45 ` [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:53 ` Felipe Balbi
2012-08-21 10:53 ` Felipe Balbi
2012-08-21 11:47 ` Poddar, Sourav
2012-08-21 11:47 ` Poddar, Sourav
2012-08-21 12:00 ` Felipe Balbi [this message]
2012-08-21 12:00 ` Felipe Balbi
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:22 ` Felipe Balbi
2012-08-21 12:22 ` Felipe Balbi
2012-08-21 14:50 ` Mark Brown
2012-08-21 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821120052.GD10347@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.