From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Tue, 21 Aug 2012 15:20:08 +0100 [thread overview]
Message-ID: <20120821142007.GP7995@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120821140923.GL10347@arwen.pp.htv.fi>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Tue, Aug 21, 2012 at 05:09:24PM +0300, Felipe Balbi wrote:
> You can't possibly understand what that'll print. First of all, VEN_ID_H
> and VEN_ID_L should be ORed together. Second, the user will see the same
> message four times in a row, with different values, but see that driver
> claims that all four values refer to the device id. What this should do,
> is at least combine all four messages into a single one of the format:
> dev_(dbg|info)(&i2c->dev, "SMSCxxx devid: %02x rev: %02x venid: %02x\n",
> devid, rev, (venid_h << 8) | venid_l);
> or something similar.
Yes, I agree that the formatting here should also be improved - as I
said in one of my earlier mails if any of these things are fixed things
that should never change the driver should instead verify the value
rather than log it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Tue, 21 Aug 2012 15:20:08 +0100 [thread overview]
Message-ID: <20120821142007.GP7995@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120821140923.GL10347@arwen.pp.htv.fi>
On Tue, Aug 21, 2012 at 05:09:24PM +0300, Felipe Balbi wrote:
> You can't possibly understand what that'll print. First of all, VEN_ID_H
> and VEN_ID_L should be ORed together. Second, the user will see the same
> message four times in a row, with different values, but see that driver
> claims that all four values refer to the device id. What this should do,
> is at least combine all four messages into a single one of the format:
> dev_(dbg|info)(&i2c->dev, "SMSCxxx devid: %02x rev: %02x venid: %02x\n",
> devid, rev, (venid_h << 8) | venid_l);
> or something similar.
Yes, I agree that the formatting here should also be improved - as I
said in one of my earlier mails if any of these things are fixed things
that should never change the driver should instead verify the value
rather than log it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120821/871c4971/attachment.sig>
next prev parent reply other threads:[~2012-08-21 14:20 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 10:45 [PATCH 0/4] Add mfd driver for smsc-ece1099 chip Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
[not found] ` <1345545940-2232-2-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:41 ` Mark Brown
2012-08-21 12:42 ` Felipe Balbi
2012-08-21 12:42 ` Felipe Balbi
2012-08-21 13:22 ` Mark Brown
2012-08-21 13:22 ` Mark Brown
[not found] ` <20120821132222.GF7995-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:27 ` Felipe Balbi
2012-08-21 13:49 ` Mark Brown
2012-08-21 13:49 ` Mark Brown
2012-08-21 13:52 ` Felipe Balbi
2012-08-21 13:52 ` Felipe Balbi
2012-08-21 14:08 ` Mark Brown
2012-08-21 14:08 ` Mark Brown
2012-08-21 14:09 ` Felipe Balbi
2012-08-21 14:09 ` Felipe Balbi
2012-08-21 14:20 ` Mark Brown [this message]
2012-08-21 14:20 ` Mark Brown
2012-08-21 10:45 ` [PATCH 2/4] Input: keypad: Add smsc ece1099 keypad driver Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Felipe Balbi
2012-08-21 10:45 ` Felipe Balbi
2012-08-21 11:30 ` Poddar, Sourav
2012-08-21 11:30 ` Poddar, Sourav
2012-08-21 10:46 ` Felipe Balbi
2012-08-21 10:46 ` Felipe Balbi
2012-08-21 11:31 ` Poddar, Sourav
2012-08-21 11:31 ` Poddar, Sourav
2012-08-21 10:45 ` [PATCH 3/4] arm/dts: omap5-evm: Add keypad support Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:47 ` Felipe Balbi
2012-08-21 10:47 ` Felipe Balbi
2012-08-21 11:20 ` Poddar, Sourav
2012-08-21 11:20 ` Poddar, Sourav
2012-08-21 10:45 ` [RFC/PATCH 4/4] gpio: smscece: Add support for gpio IO expander feature Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:45 ` Sourav Poddar
2012-08-21 10:53 ` Felipe Balbi
2012-08-21 10:53 ` Felipe Balbi
2012-08-21 11:47 ` Poddar, Sourav
2012-08-21 11:47 ` Poddar, Sourav
2012-08-21 12:00 ` Felipe Balbi
2012-08-21 12:00 ` Felipe Balbi
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:20 ` Poddar, Sourav
2012-08-21 12:22 ` Felipe Balbi
2012-08-21 12:22 ` Felipe Balbi
2012-08-21 14:50 ` Mark Brown
2012-08-21 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821142007.GP7995@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.