From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes
Date: Wed, 22 Aug 2012 22:43:23 +0100 [thread overview]
Message-ID: <20120822214323.GA12255@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201208221301.19439.arnd@arndb.de>
On Wed, Aug 22, 2012 at 01:01:19PM +0000, Arnd Bergmann wrote:
> These are lots of device drivers that include machine
> specific header files from ARM platforms and that are
> not easily scriptable. The changes have been found through
> manual inspection and should cause no visible changes
> because of the build script that maps the old names to the
> new ones.
And you end up missing a bunch of drivers in the process, such as the
sa1100 RTC driver which is shared between sa11x0 and PXA. I wonder
how many of the Samsung platforms get broken by this as well...
In any case, what we _should_ be doing here as well is moving the headers
included by drivers for platform data out of the arch/arm/mach/ subtrees
and into include/linux/platform_data. That will substantially reduce the
amount of mach/ headers to deal with.
Where I want this to get to is not a persistence of the existing crappy
situation where platforms stuff platform data definitions into arch/arm,
but instead put them in the right place. That means providing them with
a good reason why the existing solution won't work, and not allowing
mach/ includes in drivers is a very good way to achieve that.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes
Date: Wed, 22 Aug 2012 22:43:23 +0100 [thread overview]
Message-ID: <20120822214323.GA12255@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201208221301.19439.arnd@arndb.de>
On Wed, Aug 22, 2012 at 01:01:19PM +0000, Arnd Bergmann wrote:
> These are lots of device drivers that include machine
> specific header files from ARM platforms and that are
> not easily scriptable. The changes have been found through
> manual inspection and should cause no visible changes
> because of the build script that maps the old names to the
> new ones.
And you end up missing a bunch of drivers in the process, such as the
sa1100 RTC driver which is shared between sa11x0 and PXA. I wonder
how many of the Samsung platforms get broken by this as well...
In any case, what we _should_ be doing here as well is moving the headers
included by drivers for platform data out of the arch/arm/mach/ subtrees
and into include/linux/platform_data. That will substantially reduce the
amount of mach/ headers to deal with.
Where I want this to get to is not a persistence of the existing crappy
situation where platforms stuff platform data definitions into arch/arm,
but instead put them in the right place. That means providing them with
a good reason why the existing solution won't work, and not allowing
mach/ includes in drivers is a very good way to achieve that.
next prev parent reply other threads:[~2012-08-22 21:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 12:53 [PATCH 0/4] [RFC] ARM: multiplatform: rename all mach headers Arnd Bergmann
2012-08-22 12:53 ` Arnd Bergmann
2012-08-22 12:54 ` [PATCH 1/4] [RFC] ARM: autogenerate mach-foo/* and plat-foo/* header redirects Arnd Bergmann
2012-08-22 12:54 ` Arnd Bergmann
2012-08-22 15:24 ` Nicolas Pitre
2012-08-22 15:24 ` Nicolas Pitre
2012-08-24 13:44 ` Rob Herring
2012-08-24 13:44 ` Rob Herring
2012-08-22 12:56 ` [PATCH 2/4] [RFC] ARM: mass move of mach-*/plat-* header files Arnd Bergmann
2012-08-22 12:56 ` Arnd Bergmann
2012-08-22 15:28 ` Nicolas Pitre
2012-08-22 15:28 ` Nicolas Pitre
2012-08-22 15:37 ` Arnd Bergmann
2012-08-22 15:37 ` Arnd Bergmann
2012-08-22 13:00 ` [PATCH 3/4] [RFC] ARM: multiplatform: rename all mach headers Arnd Bergmann
2012-08-22 13:00 ` Arnd Bergmann
2012-08-22 15:31 ` Nicolas Pitre
2012-08-22 15:31 ` Nicolas Pitre
2012-08-22 13:01 ` [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes Arnd Bergmann
2012-08-22 13:01 ` Arnd Bergmann
2012-08-22 15:33 ` Nicolas Pitre
2012-08-22 15:33 ` Nicolas Pitre
2012-08-22 21:43 ` Russell King - ARM Linux [this message]
2012-08-22 21:43 ` Russell King - ARM Linux
2012-08-23 11:35 ` Arnd Bergmann
2012-08-23 11:35 ` Arnd Bergmann
2012-08-23 12:37 ` Nicolas Ferre
2012-08-23 12:37 ` Nicolas Ferre
2012-08-23 13:31 ` Arnd Bergmann
2012-08-23 13:31 ` Arnd Bergmann
2012-08-23 17:26 ` Arnd Bergmann
2012-08-23 17:26 ` Arnd Bergmann
2012-08-24 20:36 ` Tony Lindgren
2012-08-24 20:36 ` Tony Lindgren
2012-08-30 19:04 ` Tony Lindgren
2012-08-30 19:04 ` Tony Lindgren
2012-09-05 0:36 ` Tony Lindgren
2012-09-05 0:36 ` Tony Lindgren
2012-08-24 20:47 ` Russell King - ARM Linux
2012-08-24 20:47 ` Russell King - ARM Linux
2012-08-24 20:52 ` Russell King - ARM Linux
2012-08-24 20:52 ` Russell King - ARM Linux
2012-08-27 22:16 ` Haojian Zhuang
2012-08-27 22:16 ` Haojian Zhuang
2012-08-22 15:23 ` [PATCH 0/4] [RFC] ARM: multiplatform: rename all mach headers Nicolas Pitre
2012-08-22 15:23 ` Nicolas Pitre
2012-08-22 15:31 ` Arnd Bergmann
2012-08-22 15:31 ` Arnd Bergmann
2012-08-22 19:44 ` Stephen Warren
2012-08-22 19:44 ` Stephen Warren
2012-08-22 20:04 ` Arnd Bergmann
2012-08-22 20:04 ` Arnd Bergmann
2012-08-24 13:19 ` Shawn Guo
2012-08-24 13:19 ` Shawn Guo
2012-08-24 13:55 ` Rob Herring
2012-08-24 13:55 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822214323.GA12255@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.