All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes
Date: Thu, 23 Aug 2012 13:31:09 +0000	[thread overview]
Message-ID: <201208231331.09612.arnd@arndb.de> (raw)
In-Reply-To: <50362417.9070600@atmel.com>

On Thursday 23 August 2012, Nicolas Ferre wrote:
> > How about I move all the pure platform data definition files now and
> > rebase the other patches on top of that. Here is a list of suggested
> > file names in include/linux/platform_data/:
> > 
> > mach-at91/at_hdmac.h          -> dma-atmel.h
> 
> Fine with me. Maybe atmel-dma.h can better match what we already have in
> this directory, but I do not know what is the policy in this directory...

There does not seem to be a clear policy in that directory yet, so I
chose to put the subsystem name first. There have been a few subsystems
recently which adopted this naming scheme for their drivers, so it
seemed to be a good choice if we want to start a naming scheme that
sticks.
 
> > ** list of mach/* inclusions that I could not match with
> > ** exactly one ARM platform:
> 
> In fact, for "*atmel*" type of files, they usually match both AVR32
> and ARM/AT91 devices: so, we have to be careful about them...

Yes, I'm aware of that. My list did not include the mach/atmel-mci.h
or the mach/board.h files, which suffer from this problem and cannot
easily be merged.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes
Date: Thu, 23 Aug 2012 13:31:09 +0000	[thread overview]
Message-ID: <201208231331.09612.arnd@arndb.de> (raw)
In-Reply-To: <50362417.9070600@atmel.com>

On Thursday 23 August 2012, Nicolas Ferre wrote:
> > How about I move all the pure platform data definition files now and
> > rebase the other patches on top of that. Here is a list of suggested
> > file names in include/linux/platform_data/:
> > 
> > mach-at91/at_hdmac.h          -> dma-atmel.h
> 
> Fine with me. Maybe atmel-dma.h can better match what we already have in
> this directory, but I do not know what is the policy in this directory...

There does not seem to be a clear policy in that directory yet, so I
chose to put the subsystem name first. There have been a few subsystems
recently which adopted this naming scheme for their drivers, so it
seemed to be a good choice if we want to start a naming scheme that
sticks.
 
> > ** list of mach/* inclusions that I could not match with
> > ** exactly one ARM platform:
> 
> In fact, for "*atmel*" type of files, they usually match both AVR32
> and ARM/AT91 devices: so, we have to be careful about them...

Yes, I'm aware of that. My list did not include the mach/atmel-mci.h
or the mach/board.h files, which suffer from this problem and cannot
easily be merged.

	Arnd

  reply	other threads:[~2012-08-23 13:31 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 12:53 [PATCH 0/4] [RFC] ARM: multiplatform: rename all mach headers Arnd Bergmann
2012-08-22 12:53 ` Arnd Bergmann
2012-08-22 12:54 ` [PATCH 1/4] [RFC] ARM: autogenerate mach-foo/* and plat-foo/* header redirects Arnd Bergmann
2012-08-22 12:54   ` Arnd Bergmann
2012-08-22 15:24   ` Nicolas Pitre
2012-08-22 15:24     ` Nicolas Pitre
2012-08-24 13:44   ` Rob Herring
2012-08-24 13:44     ` Rob Herring
2012-08-22 12:56 ` [PATCH 2/4] [RFC] ARM: mass move of mach-*/plat-* header files Arnd Bergmann
2012-08-22 12:56   ` Arnd Bergmann
2012-08-22 15:28   ` Nicolas Pitre
2012-08-22 15:28     ` Nicolas Pitre
2012-08-22 15:37     ` Arnd Bergmann
2012-08-22 15:37       ` Arnd Bergmann
2012-08-22 13:00 ` [PATCH 3/4] [RFC] ARM: multiplatform: rename all mach headers Arnd Bergmann
2012-08-22 13:00   ` Arnd Bergmann
2012-08-22 15:31   ` Nicolas Pitre
2012-08-22 15:31     ` Nicolas Pitre
2012-08-22 13:01 ` [PATCH 4/4] [RFC] ARM: treewide: manually change more mach-*/*.h includes Arnd Bergmann
2012-08-22 13:01   ` Arnd Bergmann
2012-08-22 15:33   ` Nicolas Pitre
2012-08-22 15:33     ` Nicolas Pitre
2012-08-22 21:43   ` Russell King - ARM Linux
2012-08-22 21:43     ` Russell King - ARM Linux
2012-08-23 11:35     ` Arnd Bergmann
2012-08-23 11:35       ` Arnd Bergmann
2012-08-23 12:37       ` Nicolas Ferre
2012-08-23 12:37         ` Nicolas Ferre
2012-08-23 13:31         ` Arnd Bergmann [this message]
2012-08-23 13:31           ` Arnd Bergmann
2012-08-23 17:26       ` Arnd Bergmann
2012-08-23 17:26         ` Arnd Bergmann
2012-08-24 20:36         ` Tony Lindgren
2012-08-24 20:36           ` Tony Lindgren
2012-08-30 19:04           ` Tony Lindgren
2012-08-30 19:04             ` Tony Lindgren
2012-09-05  0:36             ` Tony Lindgren
2012-09-05  0:36               ` Tony Lindgren
2012-08-24 20:47         ` Russell King - ARM Linux
2012-08-24 20:47           ` Russell King - ARM Linux
2012-08-24 20:52       ` Russell King - ARM Linux
2012-08-24 20:52         ` Russell King - ARM Linux
2012-08-27 22:16   ` Haojian Zhuang
2012-08-27 22:16     ` Haojian Zhuang
2012-08-22 15:23 ` [PATCH 0/4] [RFC] ARM: multiplatform: rename all mach headers Nicolas Pitre
2012-08-22 15:23   ` Nicolas Pitre
2012-08-22 15:31   ` Arnd Bergmann
2012-08-22 15:31     ` Arnd Bergmann
2012-08-22 19:44 ` Stephen Warren
2012-08-22 19:44   ` Stephen Warren
2012-08-22 20:04   ` Arnd Bergmann
2012-08-22 20:04     ` Arnd Bergmann
2012-08-24 13:19 ` Shawn Guo
2012-08-24 13:19   ` Shawn Guo
2012-08-24 13:55 ` Rob Herring
2012-08-24 13:55   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208231331.09612.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.