All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: dedekind1@gmail.com
Cc: robherring2@gmail.com, devicetree-discuss@lists.ozlabs.org,
	linux-mtd@lists.infradead.org,
	David Woodhouse <david.woodhouse@intel.com>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Subject: Re: [PATCH V4] mtd: m25p80: Make fast read configurable via DT
Date: Sat, 25 Aug 2012 16:06:48 +0200	[thread overview]
Message-ID: <201208251606.48789.marex@denx.de> (raw)
In-Reply-To: <1345899551.1815.10.camel@kyv>

Dear Artem Bityutskiy,

> On Thu, 2012-08-23 at 15:41 +0200, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> > Cc: David Woodhouse <david.woodhouse@intel.com>
> 
> Does not compile if (I think) OF is not enabled.
> 
> drivers/mtd/devices/m25p80.c: In function 'm25p_probe':
> drivers/mtd/devices/m25p80.c:920:2: error: implicit declaration of function
> 'of_property_read_bool' [-Werror=implicit-function-declaration] cc1: some
> warnings being treated as errors
> make[4]: *** [drivers/mtd/devices/m25p80.o] Error 1

Argh, of course. Wrapping that part in ifdef CONFIG_OF should do the trick. So 
much for having CONFIG_OF on all the time.

Thanks!

Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: dedekind1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	David Woodhouse
	<david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Artem Bityutskiy
	<artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [PATCH V4] mtd: m25p80: Make fast read configurable via DT
Date: Sat, 25 Aug 2012 16:06:48 +0200	[thread overview]
Message-ID: <201208251606.48789.marex@denx.de> (raw)
In-Reply-To: <1345899551.1815.10.camel@kyv>

Dear Artem Bityutskiy,

> On Thu, 2012-08-23 at 15:41 +0200, Marek Vasut wrote:
> > Add DT property "m25p,fast-read" that signalises the particular
> > chip supports "fast read" opcode.
> > 
> > Signed-off-by: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
> > Cc: Artem Bityutskiy <artem.bityutskiy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Cc: David Woodhouse <david.woodhouse-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Does not compile if (I think) OF is not enabled.
> 
> drivers/mtd/devices/m25p80.c: In function 'm25p_probe':
> drivers/mtd/devices/m25p80.c:920:2: error: implicit declaration of function
> 'of_property_read_bool' [-Werror=implicit-function-declaration] cc1: some
> warnings being treated as errors
> make[4]: *** [drivers/mtd/devices/m25p80.o] Error 1

Argh, of course. Wrapping that part in ifdef CONFIG_OF should do the trick. So 
much for having CONFIG_OF on all the time.

Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2012-08-25 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23 13:41 [PATCH V4] mtd: m25p80: Make fast read configurable via DT Marek Vasut
2012-08-23 13:41 ` Marek Vasut
2012-08-25 12:59 ` Artem Bityutskiy
2012-08-25 12:59   ` Artem Bityutskiy
2012-08-25 14:06   ` Marek Vasut [this message]
2012-08-25 14:06     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201208251606.48789.marex@denx.de \
    --to=marek.vasut@gmail.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=david.woodhouse@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.