* [patch] ASoC: wm0010: unlock on error path
@ 2012-09-05 12:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-09-05 12:29 UTC (permalink / raw)
To: Dimitris Papastamos
Cc: alsa-devel, Mark Brown, Takashi Iwai, patches, kernel-janitors,
Liam Girdwood
We're holding the wm0010->lock mutex when we goto err_core.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This driver is only in linux-next.
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 5f99148..1c052d6 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -663,7 +663,9 @@ abort:
wm0010_halt(codec);
mutex_unlock(&wm0010->lock);
return ret;
+
err_core:
+ mutex_unlock(&wm0010->lock);
regulator_bulk_disable(ARRAY_SIZE(wm0010->core_supplies),
wm0010->core_supplies);
err:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] ASoC: wm0010: unlock on error path
@ 2012-09-05 12:29 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-09-05 12:29 UTC (permalink / raw)
To: Dimitris Papastamos
Cc: alsa-devel, Mark Brown, Takashi Iwai, patches, kernel-janitors,
Liam Girdwood
We're holding the wm0010->lock mutex when we goto err_core.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This driver is only in linux-next.
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 5f99148..1c052d6 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -663,7 +663,9 @@ abort:
wm0010_halt(codec);
mutex_unlock(&wm0010->lock);
return ret;
+
err_core:
+ mutex_unlock(&wm0010->lock);
regulator_bulk_disable(ARRAY_SIZE(wm0010->core_supplies),
wm0010->core_supplies);
err:
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: wm0010: unlock on error path
2012-09-05 12:29 ` Dan Carpenter
@ 2012-09-05 12:37 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-09-05 12:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dimitris Papastamos, alsa-devel, Takashi Iwai, patches,
kernel-janitors, Liam Girdwood
On Wed, Sep 05, 2012 at 03:29:46PM +0300, Dan Carpenter wrote:
> We're holding the wm0010->lock mutex when we goto err_core.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] ASoC: wm0010: unlock on error path
@ 2012-09-05 12:37 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-09-05 12:37 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dimitris Papastamos, alsa-devel, Takashi Iwai, patches,
kernel-janitors, Liam Girdwood
On Wed, Sep 05, 2012 at 03:29:46PM +0300, Dan Carpenter wrote:
> We're holding the wm0010->lock mutex when we goto err_core.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-05 12:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-05 12:29 [patch] ASoC: wm0010: unlock on error path Dan Carpenter
2012-09-05 12:29 ` Dan Carpenter
2012-09-05 12:37 ` Mark Brown
2012-09-05 12:37 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.