All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
	Peter Zijlstra
	<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
	Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Lennart Poettering
	<lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org>,
	Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>,
	Kamezawa Hiroyuki
	<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller
Date: Wed, 5 Sep 2012 13:12:38 -0700	[thread overview]
Message-ID: <20120905201238.GE13737@google.com> (raw)
In-Reply-To: <20120905144942.GH5388-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

Hello, Michal.

On Wed, Sep 05, 2012 at 04:49:42PM +0200, Michal Hocko wrote:
> Can we settle on the following 3 steps?
> 1) warn about "flat" hierarchies (give it X releases) - I will push it
>    to as many Suse code streams as possible (hope other distributions
>    could do the same)

I think I'm just gonna trigger WARN from cgroup core if anyone tries
to create hierarchy with a controller which doesn't support full
hierarchy.  WARN_ON_ONCE() at first and then WARN_ON() on each
creation later on.

> 2) flip the default on the root cgroup & warn when somebody tries to
>    change it to 0 (give it another X releases) that the knob will be
>    removed
> 3) remove the knob and the whole nonsese
> 4) revert 3 if somebody really objects

If we can get to 3, I don't think 4 would be a problem.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Glauber Costa <glommer@parallels.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, Dave Jones <davej@redhat.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller
Date: Wed, 5 Sep 2012 13:12:38 -0700	[thread overview]
Message-ID: <20120905201238.GE13737@google.com> (raw)
In-Reply-To: <20120905144942.GH5388@dhcp22.suse.cz>

Hello, Michal.

On Wed, Sep 05, 2012 at 04:49:42PM +0200, Michal Hocko wrote:
> Can we settle on the following 3 steps?
> 1) warn about "flat" hierarchies (give it X releases) - I will push it
>    to as many Suse code streams as possible (hope other distributions
>    could do the same)

I think I'm just gonna trigger WARN from cgroup core if anyone tries
to create hierarchy with a controller which doesn't support full
hierarchy.  WARN_ON_ONCE() at first and then WARN_ON() on each
creation later on.

> 2) flip the default on the root cgroup & warn when somebody tries to
>    change it to 0 (give it another X releases) that the knob will be
>    removed
> 3) remove the knob and the whole nonsese
> 4) revert 3 if somebody really objects

If we can get to 3, I don't think 4 would be a problem.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: Glauber Costa <glommer@parallels.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-mm@kvack.org, Dave Jones <davej@redhat.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Turner <pjt@google.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller
Date: Wed, 5 Sep 2012 13:12:38 -0700	[thread overview]
Message-ID: <20120905201238.GE13737@google.com> (raw)
In-Reply-To: <20120905144942.GH5388@dhcp22.suse.cz>

Hello, Michal.

On Wed, Sep 05, 2012 at 04:49:42PM +0200, Michal Hocko wrote:
> Can we settle on the following 3 steps?
> 1) warn about "flat" hierarchies (give it X releases) - I will push it
>    to as many Suse code streams as possible (hope other distributions
>    could do the same)

I think I'm just gonna trigger WARN from cgroup core if anyone tries
to create hierarchy with a controller which doesn't support full
hierarchy.  WARN_ON_ONCE() at first and then WARN_ON() on each
creation later on.

> 2) flip the default on the root cgroup & warn when somebody tries to
>    change it to 0 (give it another X releases) that the knob will be
>    removed
> 3) remove the knob and the whole nonsese
> 4) revert 3 if somebody really objects

If we can get to 3, I don't think 4 would be a problem.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-09-05 20:12 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-03 15:46 [PATCH v2] memcg: first step towards hierarchical controller Glauber Costa
2012-09-03 15:46 ` Glauber Costa
     [not found] ` <1346687211-31848-1-git-send-email-glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-03 16:41   ` Ben Hutchings
2012-09-03 16:41     ` Ben Hutchings
2012-09-03 16:41     ` Ben Hutchings
     [not found]     ` <20120903164148.GS29217-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2012-09-04  8:29       ` Glauber Costa
2012-09-04  8:29         ` Glauber Costa
2012-09-04  8:29         ` Glauber Costa
2012-09-03 17:08 ` Michal Hocko
2012-09-03 17:08   ` Michal Hocko
2012-09-04  8:34   ` Glauber Costa
2012-09-04  8:34     ` Glauber Costa
     [not found]     ` <5045BD25.10301-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 13:09       ` Michal Hocko
2012-09-04 13:09         ` Michal Hocko
2012-09-04 13:09         ` Michal Hocko
     [not found]         ` <20120904130905.GA15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 13:27           ` Glauber Costa
2012-09-04 13:27             ` Glauber Costa
2012-09-04 13:27             ` Glauber Costa
2012-09-04 14:35             ` Michal Hocko
2012-09-04 14:35               ` Michal Hocko
2012-09-04 14:35               ` Michal Hocko
2012-09-04 14:37               ` Glauber Costa
2012-09-04 14:37                 ` Glauber Costa
2012-09-04 14:37                 ` Glauber Costa
     [not found]                 ` <50461241.5010300-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 14:54                   ` Michal Hocko
2012-09-04 14:54                     ` Michal Hocko
2012-09-04 14:54                     ` Michal Hocko
     [not found]                     ` <20120904145414.GC15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 14:54                       ` Glauber Costa
2012-09-04 14:54                         ` Glauber Costa
2012-09-04 14:54                         ` Glauber Costa
     [not found]                         ` <50461610.30305-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-04 16:25                           ` Michal Hocko
2012-09-04 16:25                             ` Michal Hocko
2012-09-04 16:25                             ` Michal Hocko
     [not found]                             ` <20120904162501.GE15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-05  8:14                               ` Glauber Costa
2012-09-05  8:14                                 ` Glauber Costa
2012-09-05  8:14                                 ` Glauber Costa
     [not found]                                 ` <504709D4.2010800-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-05 14:49                                   ` Michal Hocko
2012-09-05 14:49                                     ` Michal Hocko
2012-09-05 14:49                                     ` Michal Hocko
     [not found]                                     ` <20120905144942.GH5388-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-05 20:12                                       ` Tejun Heo [this message]
2012-09-05 20:12                                         ` Tejun Heo
2012-09-05 20:12                                         ` Tejun Heo
     [not found]                                         ` <20120905201238.GE13737-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-06 12:06                                           ` Michal Hocko
2012-09-06 12:06                                             ` Michal Hocko
2012-09-06 12:06                                             ` Michal Hocko
2012-09-06 12:09                                             ` Glauber Costa
2012-09-06 12:09                                               ` Glauber Costa
     [not found]                                               ` <50489270.7060108-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-06 12:18                                                 ` Michal Hocko
2012-09-06 12:18                                                   ` Michal Hocko
2012-09-06 12:18                                                   ` Michal Hocko
     [not found]                                                   ` <20120906121842.GG22426-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-07  9:45                                                     ` Glauber Costa
2012-09-07  9:45                                                       ` Glauber Costa
2012-09-07  9:45                                                       ` Glauber Costa
     [not found]               ` <20120904143552.GB15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-04 18:22                 ` Tejun Heo
2012-09-04 18:22                   ` Tejun Heo
2012-09-04 18:22                   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905201238.GE13737@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
    --cc=kay.sievers-tD+1rO4QERM@public.gmane.org \
    --cc=lennart-mdGvqq1h2p+GdvJs77BJ7Q@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
    --cc=pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.