From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
Date: Tue, 11 Sep 2012 20:38:11 -0700 [thread overview]
Message-ID: <20120912033811.GA1886@lizard> (raw)
In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C176E94@039-SN1MPN1-002.039d.mgd.msft.net>
On Wed, Sep 12, 2012 at 03:19:18AM +0000, Huang Changming-R66093 wrote:
[...]
> I don't think it is the best way to do it. For the VVN2.2 or older,
> some silicon support this feature (mpc8536 and p2020), but other
> silicones don't support it (e.g. p4080, p102x). Though, the current
> p5/p4/p3 has supported this feature, can we sure the future silicon
> support it? So I think the best way is to specify it in device tree
> as 'sdhci,auto-cmd12'
In addition to your current patches, you could just add another patch
that blacklists affected SOC revisions based on the info from PVR/SVR.
For example, see gfar_detect_errata() in
drivers/net/ethernet/freescale/gianfar.c.
That way you could help users that don't have the newest device trees.
Thanks,
Anton.
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Huang Changming-R66093 <r66093@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
Date: Tue, 11 Sep 2012 20:38:11 -0700 [thread overview]
Message-ID: <20120912033811.GA1886@lizard> (raw)
In-Reply-To: <110EED8CC96DFC488B7E717A2027A27C176E94@039-SN1MPN1-002.039d.mgd.msft.net>
On Wed, Sep 12, 2012 at 03:19:18AM +0000, Huang Changming-R66093 wrote:
[...]
> I don't think it is the best way to do it. For the VVN2.2 or older,
> some silicon support this feature (mpc8536 and p2020), but other
> silicones don't support it (e.g. p4080, p102x). Though, the current
> p5/p4/p3 has supported this feature, can we sure the future silicon
> support it? So I think the best way is to specify it in device tree
> as 'sdhci,auto-cmd12'
In addition to your current patches, you could just add another patch
that blacklists affected SOC revisions based on the info from PVR/SVR.
For example, see gfar_detect_errata() in
drivers/net/ethernet/freescale/gianfar.c.
That way you could help users that don't have the newest device trees.
Thanks,
Anton.
next prev parent reply other threads:[~2012-09-12 3:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 7:12 [PATCH 1/3] powerpc/esdhc: disable CMD23 for some Freescale SoCs Chang-Ming.Huang
2012-09-11 7:12 ` [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Chang-Ming.Huang
2012-09-11 7:12 ` [PATCH 3/3] MMC/esdhc: introduce the 'sdhci,no-cmd23' Chang-Ming.Huang
2012-09-11 7:55 ` Anton Vorontsov
2012-09-11 7:54 ` [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Anton Vorontsov
2012-09-11 8:04 ` Anton Vorontsov
2012-09-11 8:04 ` Anton Vorontsov
2012-09-11 9:36 ` Huang Changming-R66093
2012-09-11 9:36 ` Huang Changming-R66093
2012-09-11 12:43 ` Kumar Gala
2012-09-11 12:43 ` Kumar Gala
2012-09-11 12:49 ` Kumar Gala
2012-09-11 12:49 ` Kumar Gala
2012-09-11 14:44 ` Chris Ball
2012-09-11 14:44 ` Chris Ball
2012-09-11 20:26 ` Kumar Gala
2012-09-11 20:26 ` Kumar Gala
2012-09-11 20:59 ` Chris Ball
2012-09-11 20:59 ` Chris Ball
2012-09-12 6:18 ` Huang Changming-R66093
2012-09-12 6:18 ` Huang Changming-R66093
2012-09-12 12:13 ` Kumar Gala
2012-09-12 12:13 ` Kumar Gala
2012-09-13 2:02 ` Huang Changming-R66093
2012-09-13 2:02 ` Huang Changming-R66093
2012-09-13 12:47 ` Kumar Gala
2012-09-13 12:47 ` Kumar Gala
2012-09-14 2:02 ` Huang Changming-R66093
2012-09-14 2:02 ` Huang Changming-R66093
2012-09-14 12:40 ` Kumar Gala
2012-09-14 12:40 ` Kumar Gala
2012-09-17 12:36 ` Chris Ball
2012-09-17 12:36 ` Chris Ball
2012-09-17 13:12 ` Kumar Gala
2012-09-17 13:12 ` Kumar Gala
2012-09-17 13:45 ` Chris Ball
2012-09-17 13:45 ` Chris Ball
2012-09-18 1:09 ` Huang Changming-R66093
2012-09-18 1:09 ` Huang Changming-R66093
2012-09-18 5:00 ` Kumar Gala
2012-09-18 5:00 ` Kumar Gala
2012-09-18 5:07 ` Chris Ball
2012-09-11 18:28 ` Scott Wood
2012-09-11 18:28 ` Scott Wood
2012-09-12 3:19 ` Huang Changming-R66093
2012-09-12 3:19 ` Huang Changming-R66093
2012-09-12 3:38 ` Anton Vorontsov [this message]
2012-09-12 3:38 ` Anton Vorontsov
2012-09-13 7:57 ` Huang Changming-R66093
2012-09-13 7:57 ` Huang Changming-R66093
2012-09-11 7:57 ` [PATCH 1/3] powerpc/esdhc: disable CMD23 for some Freescale SoCs Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912033811.GA1886@lizard \
--to=cbouatmailru@gmail.com \
--cc=B07421@freescale.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r66093@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.