All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Huang Changming-R66093 <R66093@freescale.com>,
	"linuxppc-dev@lists.ozlabs.org list"
	<linuxppc-dev@lists.ozlabs.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
Date: Mon, 17 Sep 2012 08:36:16 -0400	[thread overview]
Message-ID: <m3k3vsn7wf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <4E15F856-D385-40C4-A5FD-5F298C70F402@kernel.crashing.org> (Kumar Gala's message of "Thu, 13 Sep 2012 07:47:33 -0500")

Hi,

On Thu, Sep 13 2012, Kumar Gala wrote:
>>> Can you list out which SoCs support it and which don't.  Having this list
>>> will be useful in understanding which controller versions supported it.
>>> 
>> P1020, p1021, p1022, p1024, p1015 and p4080 can't support it.
>> Mpc8536, p2020, and the other current DPAA silicon (e.g. p5020, p3041) support it.
>
> Based on this, why don't we use the HOSTVER register to detect instead of device tree:

I've got a mild preference for handling quirk assignment in the DT
rather than in driver code, so I'd prefer to just push the original
patch to mmc-next as-is.  Does that sound okay?

(I think the argument that there isn't going to be any new hardware
with this problem is equally in favor of both methods.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

WARNING: multiple messages have this Message-ID (diff)
From: Chris Ball <cjb@laptop.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Huang Changming-R66093 <R66093@freescale.com>,
	"linuxppc-dev@lists.ozlabs.org list"
	<linuxppc-dev@lists.ozlabs.org>,
	Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23
Date: Mon, 17 Sep 2012 08:36:16 -0400	[thread overview]
Message-ID: <m3k3vsn7wf.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <4E15F856-D385-40C4-A5FD-5F298C70F402@kernel.crashing.org> (Kumar Gala's message of "Thu, 13 Sep 2012 07:47:33 -0500")

Hi,

On Thu, Sep 13 2012, Kumar Gala wrote:
>>> Can you list out which SoCs support it and which don't.  Having this list
>>> will be useful in understanding which controller versions supported it.
>>> 
>> P1020, p1021, p1022, p1024, p1015 and p4080 can't support it.
>> Mpc8536, p2020, and the other current DPAA silicon (e.g. p5020, p3041) support it.
>
> Based on this, why don't we use the HOSTVER register to detect instead of device tree:

I've got a mild preference for handling quirk assignment in the DT
rather than in driver code, so I'd prefer to just push the original
patch to mmc-next as-is.  Does that sound okay?

(I think the argument that there isn't going to be any new hardware
with this problem is equally in favor of both methods.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2012-09-17 12:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11  7:12 [PATCH 1/3] powerpc/esdhc: disable CMD23 for some Freescale SoCs Chang-Ming.Huang
2012-09-11  7:12 ` [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Chang-Ming.Huang
2012-09-11  7:12   ` [PATCH 3/3] MMC/esdhc: introduce the 'sdhci,no-cmd23' Chang-Ming.Huang
2012-09-11  7:55     ` Anton Vorontsov
2012-09-11  7:54   ` [PATCH 2/3] powerpc/esdhc: add property to disable the CMD23 Anton Vorontsov
2012-09-11  8:04     ` Anton Vorontsov
2012-09-11  8:04       ` Anton Vorontsov
2012-09-11  9:36       ` Huang Changming-R66093
2012-09-11  9:36         ` Huang Changming-R66093
2012-09-11 12:43         ` Kumar Gala
2012-09-11 12:43           ` Kumar Gala
2012-09-11 12:49           ` Kumar Gala
2012-09-11 12:49             ` Kumar Gala
2012-09-11 14:44             ` Chris Ball
2012-09-11 14:44               ` Chris Ball
2012-09-11 20:26               ` Kumar Gala
2012-09-11 20:26                 ` Kumar Gala
2012-09-11 20:59                 ` Chris Ball
2012-09-11 20:59                   ` Chris Ball
2012-09-12  6:18                   ` Huang Changming-R66093
2012-09-12  6:18                     ` Huang Changming-R66093
2012-09-12 12:13                     ` Kumar Gala
2012-09-12 12:13                       ` Kumar Gala
2012-09-13  2:02                       ` Huang Changming-R66093
2012-09-13  2:02                         ` Huang Changming-R66093
2012-09-13 12:47                         ` Kumar Gala
2012-09-13 12:47                           ` Kumar Gala
2012-09-14  2:02                           ` Huang Changming-R66093
2012-09-14  2:02                             ` Huang Changming-R66093
2012-09-14 12:40                             ` Kumar Gala
2012-09-14 12:40                               ` Kumar Gala
2012-09-17 12:36                           ` Chris Ball [this message]
2012-09-17 12:36                             ` Chris Ball
2012-09-17 13:12                             ` Kumar Gala
2012-09-17 13:12                               ` Kumar Gala
2012-09-17 13:45                               ` Chris Ball
2012-09-17 13:45                                 ` Chris Ball
2012-09-18  1:09                               ` Huang Changming-R66093
2012-09-18  1:09                                 ` Huang Changming-R66093
2012-09-18  5:00                                 ` Kumar Gala
2012-09-18  5:00                                   ` Kumar Gala
2012-09-18  5:07                                   ` Chris Ball
2012-09-11 18:28       ` Scott Wood
2012-09-11 18:28         ` Scott Wood
2012-09-12  3:19         ` Huang Changming-R66093
2012-09-12  3:19           ` Huang Changming-R66093
2012-09-12  3:38           ` Anton Vorontsov
2012-09-12  3:38             ` Anton Vorontsov
2012-09-13  7:57             ` Huang Changming-R66093
2012-09-13  7:57               ` Huang Changming-R66093
2012-09-11  7:57 ` [PATCH 1/3] powerpc/esdhc: disable CMD23 for some Freescale SoCs Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k3vsn7wf.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=R66093@freescale.com \
    --cc=cbouatmailru@gmail.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.