From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "sjurbren@gmail.com" <sjurbren@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
"Michael S. Tsirkin" <mst@redhat.com>,
Linus Walleij <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Sjur BRENDELAND <sjur.brandeland@stericsson.com>
Subject: Re: [PATCHv4] virtio_console: Add support for remoteproc serial
Date: Tue, 25 Sep 2012 12:20:25 +0530 [thread overview]
Message-ID: <20120925065025.GF32657@amit.redhat.com> (raw)
In-Reply-To: <87sja63c9b.fsf@rustcorp.com.au>
On (Tue) 25 Sep 2012 [14:55:04], Rusty Russell wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > On (Mon) 24 Sep 2012 [23:50:01], Sjur BRENDELAND wrote:
> >> Hi Amit,
> >>
> >> > I'm sorry for not being able to look at this earlier.
> >>
> >> No worries. I'll try to respin and retest this patch by tomorrow.
> >> If you by any chance could find time to review so could make it in time
> >> for 3.7 it would be great :-)
> >
> > I think it might be late for 3.7 already, I'd prefer to let this bake
> > for a while, ensure it passes my test suites, at the least. But I'll
> > let Rusty take the final call.
>
> It can make the next merge window, but it has to be done this week.
>
> I'm only allowing it this late because it's a new driver.
It does change code shared with the 'older' console and serial ports,
so the risk of regressions does exist.
Amit
WARNING: multiple messages have this Message-ID (diff)
From: Amit Shah <amit.shah@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Sjur BRENDELAND <sjur.brandeland@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"sjurbren@gmail.com" <sjurbren@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCHv4] virtio_console: Add support for remoteproc serial
Date: Tue, 25 Sep 2012 12:20:25 +0530 [thread overview]
Message-ID: <20120925065025.GF32657@amit.redhat.com> (raw)
In-Reply-To: <87sja63c9b.fsf@rustcorp.com.au>
On (Tue) 25 Sep 2012 [14:55:04], Rusty Russell wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > On (Mon) 24 Sep 2012 [23:50:01], Sjur BRENDELAND wrote:
> >> Hi Amit,
> >>
> >> > I'm sorry for not being able to look at this earlier.
> >>
> >> No worries. I'll try to respin and retest this patch by tomorrow.
> >> If you by any chance could find time to review so could make it in time
> >> for 3.7 it would be great :-)
> >
> > I think it might be late for 3.7 already, I'd prefer to let this bake
> > for a while, ensure it passes my test suites, at the least. But I'll
> > let Rusty take the final call.
>
> It can make the next merge window, but it has to be done this week.
>
> I'm only allowing it this late because it's a new driver.
It does change code shared with the 'older' console and serial ports,
so the risk of regressions does exist.
Amit
next prev parent reply other threads:[~2012-09-25 6:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 12:33 [PATCHv4] virtio_console: Add support for remoteproc serial sjur.brandeland
2012-09-24 12:33 ` sjur.brandeland
2012-09-24 17:45 ` Amit Shah
2012-09-24 17:45 ` Amit Shah
2012-09-24 21:50 ` Sjur BRENDELAND
2012-09-24 21:50 ` Sjur BRENDELAND
2012-09-25 4:01 ` Amit Shah
2012-09-25 4:01 ` Amit Shah
2012-09-25 5:25 ` Rusty Russell
2012-09-25 5:25 ` Rusty Russell
2012-09-25 6:50 ` Amit Shah [this message]
2012-09-25 6:50 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120925065025.GF32657@amit.redhat.com \
--to=amit.shah@redhat.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=sjur.brandeland@stericsson.com \
--cc=sjurbren@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.