From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: implement machine restart hook
Date: Fri, 28 Sep 2012 12:31:40 +0200 [thread overview]
Message-ID: <20120928103140.GZ17667@game.jcrosoft.org> (raw)
In-Reply-To: <1348805280-7647-1-git-send-email-swarren@wwwdotorg.org>
On 22:08 Thu 27 Sep , Stephen Warren wrote:
> Implement the machine restart hook using the SoC's watchdog timer module.
> To support this, define a DT binding for the watchdog module, and add it
> to the device tree.
>
> The downstream rpi-split branch contains a full watchdog timer driver
> implementation, which also implements the restart hook. However, the
> restart function is largely separate from the watchdog driver, so for
> simplicity, the restart hook is implemented here directly in the main
> machine source file.
>
> Overall structure (separate setup/restart) functions derived from the
> picoxcell ARM support.
>
> Watchdog register IO sequence taken from code by Simon Arlott. Note that
> the watchdog module is not documented in BCM2835-ARM-Peripherals.pdf.
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
> .../bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 13 ++++++
> arch/arm/boot/dts/bcm2835.dtsi | 5 +++
> arch/arm/mach-bcm2835/bcm2835.c | 46 ++++++++++++++++++++
> 3 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
> new file mode 100644
> index 0000000..03138e6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
> @@ -0,0 +1,13 @@
> +BCM2835 Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "brcm,bcm2835-pm-wdog"
> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +intc: interrupt-controller {
> + compatible = "brcm,bcm2835-pm-wdog";
it's seems everyone use -wdt
Best Regards,
J.
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: bcm2835: implement machine restart hook
Date: Fri, 28 Sep 2012 12:31:40 +0200 [thread overview]
Message-ID: <20120928103140.GZ17667@game.jcrosoft.org> (raw)
In-Reply-To: <1348805280-7647-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On 22:08 Thu 27 Sep , Stephen Warren wrote:
> Implement the machine restart hook using the SoC's watchdog timer module.
> To support this, define a DT binding for the watchdog module, and add it
> to the device tree.
>
> The downstream rpi-split branch contains a full watchdog timer driver
> implementation, which also implements the restart hook. However, the
> restart function is largely separate from the watchdog driver, so for
> simplicity, the restart hook is implemented here directly in the main
> machine source file.
>
> Overall structure (separate setup/restart) functions derived from the
> picoxcell ARM support.
>
> Watchdog register IO sequence taken from code by Simon Arlott. Note that
> the watchdog module is not documented in BCM2835-ARM-Peripherals.pdf.
>
> Signed-off-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> ---
> .../bindings/watchdog/brcm,bcm2835-pm-wdog.txt | 13 ++++++
> arch/arm/boot/dts/bcm2835.dtsi | 5 +++
> arch/arm/mach-bcm2835/bcm2835.c | 46 ++++++++++++++++++++
> 3 files changed, 64 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
> new file mode 100644
> index 0000000..03138e6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
> @@ -0,0 +1,13 @@
> +BCM2835 Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "brcm,bcm2835-pm-wdog"
> +- reg : Specifies base physical address and size of the registers.
> +
> +Example:
> +
> +intc: interrupt-controller {
> + compatible = "brcm,bcm2835-pm-wdog";
it's seems everyone use -wdt
Best Regards,
J.
next prev parent reply other threads:[~2012-09-28 10:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 4:08 [PATCH] ARM: bcm2835: implement machine restart hook Stephen Warren
2012-09-28 4:08 ` Stephen Warren
2012-09-28 10:15 ` Thomas Petazzoni
2012-09-28 10:15 ` Thomas Petazzoni
2012-09-28 14:56 ` Stephen Warren
2012-09-28 14:56 ` Stephen Warren
2012-09-28 10:31 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-09-28 10:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 14:57 ` Stephen Warren
2012-09-28 14:57 ` Stephen Warren
2012-10-26 2:51 ` Stephen Warren
2012-10-26 2:51 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120928103140.GZ17667@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.