From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm2835: implement machine restart hook
Date: Fri, 28 Sep 2012 08:57:20 -0600 [thread overview]
Message-ID: <5065BAD0.1030105@wwwdotorg.org> (raw)
In-Reply-To: <20120928103140.GZ17667@game.jcrosoft.org>
On 09/28/2012 04:31 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:08 Thu 27 Sep , Stephen Warren wrote:
>> Implement the machine restart hook using the SoC's watchdog timer module.
>> To support this, define a DT binding for the watchdog module, and add it
>> to the device tree.
>>
>> The downstream rpi-split branch contains a full watchdog timer driver
>> implementation, which also implements the restart hook. However, the
>> restart function is largely separate from the watchdog driver, so for
>> simplicity, the restart hook is implemented here directly in the main
>> machine source file.
>> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
>> +Example:
>> +
>> +intc: interrupt-controller {
>> + compatible = "brcm,bcm2835-pm-wdog";
>
> it's seems everyone use -wdt
That is true. "-wdog" is what was in the downstream patch, but I guess
it makes sense to fix it up to be consistent with everything already in
the kernel.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: bcm2835: implement machine restart hook
Date: Fri, 28 Sep 2012 08:57:20 -0600 [thread overview]
Message-ID: <5065BAD0.1030105@wwwdotorg.org> (raw)
In-Reply-To: <20120928103140.GZ17667-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
On 09/28/2012 04:31 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:08 Thu 27 Sep , Stephen Warren wrote:
>> Implement the machine restart hook using the SoC's watchdog timer module.
>> To support this, define a DT binding for the watchdog module, and add it
>> to the device tree.
>>
>> The downstream rpi-split branch contains a full watchdog timer driver
>> implementation, which also implements the restart hook. However, the
>> restart function is largely separate from the watchdog driver, so for
>> simplicity, the restart hook is implemented here directly in the main
>> machine source file.
>> +++ b/Documentation/devicetree/bindings/watchdog/brcm,bcm2835-pm-wdog.txt
>> +Example:
>> +
>> +intc: interrupt-controller {
>> + compatible = "brcm,bcm2835-pm-wdog";
>
> it's seems everyone use -wdt
That is true. "-wdog" is what was in the downstream patch, but I guess
it makes sense to fix it up to be consistent with everything already in
the kernel.
next prev parent reply other threads:[~2012-09-28 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 4:08 [PATCH] ARM: bcm2835: implement machine restart hook Stephen Warren
2012-09-28 4:08 ` Stephen Warren
2012-09-28 10:15 ` Thomas Petazzoni
2012-09-28 10:15 ` Thomas Petazzoni
2012-09-28 14:56 ` Stephen Warren
2012-09-28 14:56 ` Stephen Warren
2012-09-28 10:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 10:31 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-28 14:57 ` Stephen Warren [this message]
2012-09-28 14:57 ` Stephen Warren
2012-10-26 2:51 ` Stephen Warren
2012-10-26 2:51 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065BAD0.1030105@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.