All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michel Lespinasse <walken@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	stable@vger.kernel.org
Subject: Re: [patch] mm, thp: fix mlock statistics
Date: Fri, 28 Sep 2012 15:51:14 +0200	[thread overview]
Message-ID: <20120928135114.GB19474@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209261929270.8567@chino.kir.corp.google.com>

On Wed, Sep 26, 2012 at 07:29:58PM -0700, David Rientjes wrote:
> NR_MLOCK is only accounted in single page units: there's no logic to
> handle transparent hugepages.  This patch checks the appropriate number
> of pages to adjust the statistics by so that the correct amount of memory
> is reflected.

*snip*

> Reported-by: Hugh Dickens <hughd@google.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  mm/internal.h   |    3 ++-
>  mm/mlock.c      |    6 ++++--
>  mm/page_alloc.c |    2 +-
>  3 files changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>

Thanks!
Andrea

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michel Lespinasse <walken@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	stable@vger.kernel.org
Subject: Re: [patch] mm, thp: fix mlock statistics
Date: Fri, 28 Sep 2012 15:51:14 +0200	[thread overview]
Message-ID: <20120928135114.GB19474@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1209261929270.8567@chino.kir.corp.google.com>

On Wed, Sep 26, 2012 at 07:29:58PM -0700, David Rientjes wrote:
> NR_MLOCK is only accounted in single page units: there's no logic to
> handle transparent hugepages.  This patch checks the appropriate number
> of pages to adjust the statistics by so that the correct amount of memory
> is reflected.

*snip*

> Reported-by: Hugh Dickens <hughd@google.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
>  mm/internal.h   |    3 ++-
>  mm/mlock.c      |    6 ++++--
>  mm/page_alloc.c |    2 +-
>  3 files changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>

Thanks!
Andrea

  parent reply	other threads:[~2012-09-28 13:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  1:19 [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock David Rientjes
2012-09-20  1:19 ` David Rientjes
2012-09-20  4:01 ` Hugh Dickins
2012-09-20  4:01   ` Hugh Dickins
2012-09-27  1:40   ` David Rientjes
2012-09-27  1:40     ` David Rientjes
2012-09-27  1:54     ` Hugh Dickins
2012-09-27  1:54       ` Hugh Dickins
2012-09-27  2:29     ` [patch] mm, thp: fix mlock statistics David Rientjes
2012-09-27  2:29       ` David Rientjes
2012-09-28  1:32       ` Hugh Dickins
2012-09-28  1:32         ` Hugh Dickins
2012-10-03 20:10         ` Andrew Morton
2012-10-03 20:10           ` Andrew Morton
2012-10-03 21:10           ` [patch -mm] mm, thp: fix mlock statistics fix David Rientjes
2012-10-03 21:10             ` David Rientjes
2012-10-03 21:25             ` Andrew Morton
2012-10-03 21:25               ` Andrew Morton
2012-10-03 21:46               ` Hugh Dickins
2012-10-03 21:46                 ` Hugh Dickins
2012-10-03 21:29             ` Hugh Dickins
2012-10-03 21:29               ` Hugh Dickins
2012-09-28 13:51       ` Andrea Arcangeli [this message]
2012-09-28 13:51         ` [patch] mm, thp: fix mlock statistics Andrea Arcangeli
2012-09-29  0:11       ` Michel Lespinasse
2012-09-29  0:11         ` Michel Lespinasse
2012-10-01 15:22     ` [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock Linus Torvalds
2012-10-01 15:22       ` Linus Torvalds
2012-09-28 13:30 ` Andrea Arcangeli
2012-09-28 13:30   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120928135114.GB19474@redhat.com \
    --to=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rientjes@google.com \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.