All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michel Lespinasse <walken@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch -mm] mm, thp: fix mlock statistics fix
Date: Wed, 3 Oct 2012 14:25:19 -0700	[thread overview]
Message-ID: <20121003142519.93375e01.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1210031403270.4352@chino.kir.corp.google.com>

On Wed, 3 Oct 2012 14:10:41 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:

> > The free_page_mlock() hunk gets dropped because free_page_mlock() is
> > removed.  And clear_page_mlock() doesn't need this treatment.  But
> > please check my handiwork.
> > 
> 
> I reviewed what was merged into -mm and clear_page_mlock() does need this 
> fix as well.

argh, it got me *again*.  grr.

From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm: document PageHuge somewhat

Cc: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/hugetlb.c |    5 +++++
 1 file changed, 5 insertions(+)

diff -puN mm/hugetlb.c~mm-document-pagehuge-somewhat mm/hugetlb.c
--- a/mm/hugetlb.c~mm-document-pagehuge-somewhat
+++ a/mm/hugetlb.c
@@ -671,6 +671,11 @@ static void prep_compound_gigantic_page(
 	}
 }
 
+/*
+ * PageHuge() only returns true for hugetlbfs pages, but not for normal or
+ * transparent huge pages.  See the PageTransHuge() documentation for more
+ * details.
+ */
 int PageHuge(struct page *page)
 {
 	compound_page_dtor *dtor;
_


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: Hugh Dickins <hughd@google.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michel Lespinasse <walken@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch -mm] mm, thp: fix mlock statistics fix
Date: Wed, 3 Oct 2012 14:25:19 -0700	[thread overview]
Message-ID: <20121003142519.93375e01.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1210031403270.4352@chino.kir.corp.google.com>

On Wed, 3 Oct 2012 14:10:41 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:

> > The free_page_mlock() hunk gets dropped because free_page_mlock() is
> > removed.  And clear_page_mlock() doesn't need this treatment.  But
> > please check my handiwork.
> > 
> 
> I reviewed what was merged into -mm and clear_page_mlock() does need this 
> fix as well.

argh, it got me *again*.  grr.

From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm: document PageHuge somewhat

Cc: David Rientjes <rientjes@google.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/hugetlb.c |    5 +++++
 1 file changed, 5 insertions(+)

diff -puN mm/hugetlb.c~mm-document-pagehuge-somewhat mm/hugetlb.c
--- a/mm/hugetlb.c~mm-document-pagehuge-somewhat
+++ a/mm/hugetlb.c
@@ -671,6 +671,11 @@ static void prep_compound_gigantic_page(
 	}
 }
 
+/*
+ * PageHuge() only returns true for hugetlbfs pages, but not for normal or
+ * transparent huge pages.  See the PageTransHuge() documentation for more
+ * details.
+ */
 int PageHuge(struct page *page)
 {
 	compound_page_dtor *dtor;
_



  reply	other threads:[~2012-10-03 21:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-20  1:19 [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock David Rientjes
2012-09-20  1:19 ` David Rientjes
2012-09-20  4:01 ` Hugh Dickins
2012-09-20  4:01   ` Hugh Dickins
2012-09-27  1:40   ` David Rientjes
2012-09-27  1:40     ` David Rientjes
2012-09-27  1:54     ` Hugh Dickins
2012-09-27  1:54       ` Hugh Dickins
2012-09-27  2:29     ` [patch] mm, thp: fix mlock statistics David Rientjes
2012-09-27  2:29       ` David Rientjes
2012-09-28  1:32       ` Hugh Dickins
2012-09-28  1:32         ` Hugh Dickins
2012-10-03 20:10         ` Andrew Morton
2012-10-03 20:10           ` Andrew Morton
2012-10-03 21:10           ` [patch -mm] mm, thp: fix mlock statistics fix David Rientjes
2012-10-03 21:10             ` David Rientjes
2012-10-03 21:25             ` Andrew Morton [this message]
2012-10-03 21:25               ` Andrew Morton
2012-10-03 21:46               ` Hugh Dickins
2012-10-03 21:46                 ` Hugh Dickins
2012-10-03 21:29             ` Hugh Dickins
2012-10-03 21:29               ` Hugh Dickins
2012-09-28 13:51       ` [patch] mm, thp: fix mlock statistics Andrea Arcangeli
2012-09-28 13:51         ` Andrea Arcangeli
2012-09-29  0:11       ` Michel Lespinasse
2012-09-29  0:11         ` Michel Lespinasse
2012-10-01 15:22     ` [patch for-3.6] mm, thp: fix mapped pages avoiding unevictable list on mlock Linus Torvalds
2012-10-01 15:22       ` Linus Torvalds
2012-09-28 13:30 ` Andrea Arcangeli
2012-09-28 13:30   ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121003142519.93375e01.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aarcange@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.