All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/24] ARM: nomadik: use __iomem pointers for MMIO
Date: Fri, 28 Sep 2012 20:13:34 +0000	[thread overview]
Message-ID: <201209282013.34638.arnd@arndb.de> (raw)
In-Reply-To: <20120915113356.GA31284@mail.gnudd.com>

On Saturday 15 September 2012, Alessandro Rubini wrote:
> > -     .options        = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \
> > -                     | NAND_NO_READRDY,
> > +     .options        = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING,
> 
> This is not clear to me, and it looks unrelated. But I admit I haven't
> studied what happened to NAND_NO_READRDY lately.
> 
> If this hunk is desired and not just something else
> that slipped in, then
> 
>   Acked-by: Alessandro Rubini <rubini@unipv.it>

I've added the patch below to the next/fixes-non-critical branch now,
to avoid the build error in linux-next.

	Arnd

>From 06f8ab806e9e180966e812f6e47a0735bba638d8 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Sun, 23 Sep 2012 22:57:22 +0000
Subject: [PATCH] ARM: nomadik: remove NAND_NO_READRDY use

The nhk8815 board files uses NAND_NO_READRDY in its platform data, but
this macro is getting removed because it was not being used anywhere.

Without this patch, building nhk8815_defconfig results in:

arch/arm/mach-nomadik/board-nhk8815.c:118:6: error: 'NAND_NO_READRDY' undeclared here (not in a function)

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alessandro Rubini <rubini@unipv.it>
Cc: Linus Walleij <linus.walleij@linaro.org>

diff --git a/arch/arm/mach-nomadik/board-nhk8815.c b/arch/arm/mach-nomadik/board-nhk8815.c
index 381c080..92a0026 100644
--- a/arch/arm/mach-nomadik/board-nhk8815.c
+++ b/arch/arm/mach-nomadik/board-nhk8815.c
@@ -112,8 +112,7 @@ static struct mtd_partition nhk8815_partitions[] = {
 static struct nomadik_nand_platform_data nhk8815_nand_data = {
 	.parts		= nhk8815_partitions,
 	.nparts		= ARRAY_SIZE(nhk8815_partitions),
-	.options	= NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \
-			| NAND_NO_READRDY,
+	.options	= NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING,
 	.init		= nhk8815_nand_init,
 };
 

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Alessandro Rubini <rubini@unipv.it>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, will.deacon@arm.com,
	rmk+kernel@arm.linux.org.uk, nico@linaro.org,
	linus.walleij@linaro.org, STEricsson_nomadik_linux@list.st.com
Subject: Re: [PATCH 13/24] ARM: nomadik: use __iomem pointers for MMIO
Date: Fri, 28 Sep 2012 20:13:34 +0000	[thread overview]
Message-ID: <201209282013.34638.arnd@arndb.de> (raw)
In-Reply-To: <20120915113356.GA31284@mail.gnudd.com>

On Saturday 15 September 2012, Alessandro Rubini wrote:
> > -     .options        = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \
> > -                     | NAND_NO_READRDY,
> > +     .options        = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING,
> 
> This is not clear to me, and it looks unrelated. But I admit I haven't
> studied what happened to NAND_NO_READRDY lately.
> 
> If this hunk is desired and not just something else
> that slipped in, then
> 
>   Acked-by: Alessandro Rubini <rubini@unipv.it>

I've added the patch below to the next/fixes-non-critical branch now,
to avoid the build error in linux-next.

	Arnd

>From 06f8ab806e9e180966e812f6e47a0735bba638d8 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Sun, 23 Sep 2012 22:57:22 +0000
Subject: [PATCH] ARM: nomadik: remove NAND_NO_READRDY use

The nhk8815 board files uses NAND_NO_READRDY in its platform data, but
this macro is getting removed because it was not being used anywhere.

Without this patch, building nhk8815_defconfig results in:

arch/arm/mach-nomadik/board-nhk8815.c:118:6: error: 'NAND_NO_READRDY' undeclared here (not in a function)

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alessandro Rubini <rubini@unipv.it>
Cc: Linus Walleij <linus.walleij@linaro.org>

diff --git a/arch/arm/mach-nomadik/board-nhk8815.c b/arch/arm/mach-nomadik/board-nhk8815.c
index 381c080..92a0026 100644
--- a/arch/arm/mach-nomadik/board-nhk8815.c
+++ b/arch/arm/mach-nomadik/board-nhk8815.c
@@ -112,8 +112,7 @@ static struct mtd_partition nhk8815_partitions[] = {
 static struct nomadik_nand_platform_data nhk8815_nand_data = {
 	.parts		= nhk8815_partitions,
 	.nparts		= ARRAY_SIZE(nhk8815_partitions),
-	.options	= NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING \
-			| NAND_NO_READRDY,
+	.options	= NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING,
 	.init		= nhk8815_nand_init,
 };
 

  reply	other threads:[~2012-09-28 20:13 UTC|newest]

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 21:34 [PATCH 00/24] ARM: readl/writel conversion fallout Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 01/24] ARM: shmobile: use __iomem pointers for MMIO Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-18  7:11   ` Simon Horman
2012-09-18  7:11     ` Simon Horman
2012-09-18  7:11     ` Simon Horman
2012-09-18  8:31     ` Arnd Bergmann
2012-09-18  8:31       ` Arnd Bergmann
2012-09-18  8:31       ` Arnd Bergmann
2012-09-18 11:50       ` Simon Horman
2012-09-18 11:50         ` Simon Horman
2012-09-18 11:50         ` Simon Horman
2012-09-18 16:04         ` Arnd Bergmann
2012-09-18 16:04           ` Arnd Bergmann
2012-09-18 16:04           ` Arnd Bergmann
2012-09-18 23:56           ` Simon Horman
2012-09-18 23:56             ` Simon Horman
2012-09-18 23:56             ` Simon Horman
2012-09-18  7:42   ` Paul Mundt
2012-09-18  7:42     ` Paul Mundt
2012-09-18  7:42     ` Paul Mundt
2012-09-14 21:34 ` [PATCH 02/24] ARM: at91: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-17  7:56   ` Nicolas Ferre
2012-09-17  7:56     ` Nicolas Ferre
2012-09-18  8:05     ` Arnd Bergmann
2012-09-18  8:05       ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 03/24] ARM: ebsa110: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 04/24] ARM: ep93xx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 22:14   ` Ryan Mallon
2012-09-14 22:14     ` Ryan Mallon
2012-09-15  7:55     ` Arnd Bergmann
2012-09-15  7:55       ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 05/24] ARM: imx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 22:31   ` Fabio Estevam
2012-09-14 22:31     ` Fabio Estevam
2012-09-15 17:42     ` Arnd Bergmann
2012-09-15 17:42       ` Arnd Bergmann
2012-09-16  7:21       ` Sascha Hauer
2012-09-16  7:21         ` Sascha Hauer
2012-09-14 21:34 ` [PATCH 06/24] ARM: integrator: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-16 22:19   ` Linus Walleij
2012-09-16 22:19     ` Linus Walleij
2012-09-16 22:35     ` Russell King - ARM Linux
2012-09-16 22:35       ` Russell King - ARM Linux
2012-09-16 22:46       ` Linus Walleij
2012-09-16 22:46         ` Linus Walleij
2012-09-16 23:43         ` Russell King - ARM Linux
2012-09-16 23:43           ` Russell King - ARM Linux
2012-09-14 21:34 ` [PATCH 07/24] ARM: iop13xx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 08/24] ARM: iop32x: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 09/24] ARM: ixp4xx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-18 10:31   ` Krzysztof Halasa
2012-09-18 10:31     ` Krzysztof Halasa
2012-09-18 19:22     ` Krzysztof Halasa
2012-09-18 19:22       ` Krzysztof Halasa
2012-09-19 13:52       ` Arnd Bergmann
2012-09-19 13:52         ` Arnd Bergmann
2012-09-18 20:12   ` [PATCH 08+09/24] " Krzysztof Halasa
2012-09-18 20:12     ` Krzysztof Halasa
2012-09-18 21:25     ` Arnd Bergmann
2012-09-18 21:25       ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 10/24] ARM: ks8695: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 11/24] ARM: lpc32xx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 12/24] ARM: msm: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 22:38   ` Stephen Boyd
2012-09-14 22:38     ` Stephen Boyd
2012-09-15  5:16     ` David Brown
2012-09-15  5:16       ` David Brown
2012-09-14 21:34 ` [PATCH 13/24] ARM: nomadik: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-15 11:33   ` Alessandro Rubini
2012-09-15 11:33     ` Alessandro Rubini
2012-09-28 20:13     ` Arnd Bergmann [this message]
2012-09-28 20:13       ` Arnd Bergmann
2012-09-16 22:24   ` Linus Walleij
2012-09-16 22:24     ` Linus Walleij
2012-09-14 21:34 ` [PATCH 14/24] ARM: prima2: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 15/24] ARM: sa1100: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 16/24] ARM: spear13xx: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 17/24] ARM: OMAP: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-15 18:10   ` Tony Lindgren
2012-09-15 18:10     ` Tony Lindgren
2012-09-15 20:14     ` Arnd Bergmann
2012-09-15 20:14       ` Arnd Bergmann
2012-09-16 20:38       ` Tony Lindgren
2012-09-16 20:38         ` Tony Lindgren
2012-09-17 21:25         ` Tony Lindgren
2012-09-17 21:25           ` Tony Lindgren
2012-09-19 13:35           ` Arnd Bergmann
2012-09-19 13:35             ` Arnd Bergmann
2012-09-19 13:36             ` Felipe Balbi
2012-09-19 13:36               ` Felipe Balbi
2012-09-19 16:44               ` Tony Lindgren
2012-09-19 16:44                 ` Tony Lindgren
2012-09-14 21:34 ` [PATCH 18/24] ARM: samsung: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 19/24] sh: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-18  7:37   ` Paul Mundt
2012-09-18  7:37     ` Paul Mundt
2012-09-18  7:37     ` Paul Mundt
2012-09-18  8:01     ` Arnd Bergmann
2012-09-18  8:01       ` Arnd Bergmann
2012-09-18  8:01       ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 20/24] input: rpcmouse: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-19 17:06   ` Dmitry Torokhov
2012-09-19 17:06     ` Dmitry Torokhov
2012-09-14 21:34 ` [PATCH 21/24] serial: ks8695: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 23:44   ` Greg Kroah-Hartman
2012-09-14 23:44     ` Greg Kroah-Hartman
2012-09-14 21:34 ` [PATCH 22/24] scsi: eesox: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 23:27   ` Russell King - ARM Linux
2012-09-14 23:27     ` Russell King - ARM Linux
2012-09-15  8:00     ` Arnd Bergmann
2012-09-15  8:00       ` Arnd Bergmann
2012-09-15  8:57       ` Russell King - ARM Linux
2012-09-15  8:57         ` Russell King - ARM Linux
2012-09-15  8:57         ` Russell King - ARM Linux
2012-09-15 10:30         ` Arnd Bergmann
2012-09-15 10:30           ` Arnd Bergmann
2012-09-17 22:03           ` Russell King - ARM Linux
2012-09-17 22:03             ` Russell King - ARM Linux
2012-09-18  8:09             ` Arnd Bergmann
2012-09-18  8:09               ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 23/24] video: da8xx-fb: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 24/24] net: seeq: " Arnd Bergmann
2012-09-14 21:34   ` Arnd Bergmann
2012-09-14 23:56   ` Russell King - ARM Linux
2012-09-14 23:56     ` Russell King - ARM Linux
2012-09-14 23:56     ` Russell King - ARM Linux
2012-09-15  4:00     ` David Miller
2012-09-15  4:00       ` David Miller
2012-09-18  8:14       ` Arnd Bergmann
2012-09-18  8:14         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209282013.34638.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.