From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/24] ARM: ep93xx: use __iomem pointers for MMIO
Date: Sat, 15 Sep 2012 08:14:28 +1000 [thread overview]
Message-ID: <5053AC44.1030909@gmail.com> (raw)
In-Reply-To: <1347658492-11608-5-git-send-email-arnd@arndb.de>
On 15/09/12 07:34, Arnd Bergmann wrote:
> ARM is moving to stricter checks on readl/write functions,
> so we need to use the correct types everywhere.
>
> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
Do you want me to queue both this and my patch to move the
ts72xx.h header into arch/arm/mach-ep93xx on to my ep93xx-fixes
branch? That way you won't have to deal with any conflicts at
your end.
Thanks,
~Ryan
> ---
> arch/arm/mach-ep93xx/include/mach/ts72xx.h | 10 +++++-----
> arch/arm/mach-ep93xx/ts72xx.c | 10 +++++-----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/include/mach/ts72xx.h b/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> index f1397a1..071feaa 100644
> --- a/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> +++ b/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> @@ -14,7 +14,7 @@
> */
>
> #define TS72XX_MODEL_PHYS_BASE 0x22000000
> -#define TS72XX_MODEL_VIRT_BASE 0xfebff000
> +#define TS72XX_MODEL_VIRT_BASE IOMEM(0xfebff000)
> #define TS72XX_MODEL_SIZE 0x00001000
>
> #define TS72XX_MODEL_TS7200 0x00
> @@ -26,7 +26,7 @@
>
>
> #define TS72XX_OPTIONS_PHYS_BASE 0x22400000
> -#define TS72XX_OPTIONS_VIRT_BASE 0xfebfe000
> +#define TS72XX_OPTIONS_VIRT_BASE IOMEM(0xfebfe000)
> #define TS72XX_OPTIONS_SIZE 0x00001000
>
> #define TS72XX_OPTIONS_COM2_RS485 0x02
> @@ -34,18 +34,18 @@
>
>
> #define TS72XX_OPTIONS2_PHYS_BASE 0x22800000
> -#define TS72XX_OPTIONS2_VIRT_BASE 0xfebfd000
> +#define TS72XX_OPTIONS2_VIRT_BASE IOMEM(0xfebfd000)
> #define TS72XX_OPTIONS2_SIZE 0x00001000
>
> #define TS72XX_OPTIONS2_TS9420 0x04
> #define TS72XX_OPTIONS2_TS9420_BOOT 0x02
>
>
> -#define TS72XX_RTC_INDEX_VIRT_BASE 0xfebf9000
> +#define TS72XX_RTC_INDEX_VIRT_BASE IOMEM(0xfebf9000)
> #define TS72XX_RTC_INDEX_PHYS_BASE 0x10800000
> #define TS72XX_RTC_INDEX_SIZE 0x00001000
>
> -#define TS72XX_RTC_DATA_VIRT_BASE 0xfebf8000
> +#define TS72XX_RTC_DATA_VIRT_BASE IOMEM(0xfebf8000)
> #define TS72XX_RTC_DATA_PHYS_BASE 0x11700000
> #define TS72XX_RTC_DATA_SIZE 0x00001000
>
> diff --git a/arch/arm/mach-ep93xx/ts72xx.c b/arch/arm/mach-ep93xx/ts72xx.c
> index 75cab2d..faa5bdd 100644
> --- a/arch/arm/mach-ep93xx/ts72xx.c
> +++ b/arch/arm/mach-ep93xx/ts72xx.c
> @@ -32,27 +32,27 @@
>
> static struct map_desc ts72xx_io_desc[] __initdata = {
> {
> - .virtual = TS72XX_MODEL_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_MODEL_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_MODEL_PHYS_BASE),
> .length = TS72XX_MODEL_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_OPTIONS_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_OPTIONS_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_OPTIONS_PHYS_BASE),
> .length = TS72XX_OPTIONS_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_OPTIONS2_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_OPTIONS2_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_OPTIONS2_PHYS_BASE),
> .length = TS72XX_OPTIONS2_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_RTC_INDEX_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_RTC_INDEX_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_RTC_INDEX_PHYS_BASE),
> .length = TS72XX_RTC_INDEX_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_RTC_DATA_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_RTC_DATA_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_RTC_DATA_PHYS_BASE),
> .length = TS72XX_RTC_DATA_SIZE,
> .type = MT_DEVICE,
WARNING: multiple messages have this Message-ID (diff)
From: Ryan Mallon <rmallon@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Nicolas Pitre <nico@linaro.org>,
Hartley Sweeten <hsweeten@visionengravers.com>
Subject: Re: [PATCH 04/24] ARM: ep93xx: use __iomem pointers for MMIO
Date: Sat, 15 Sep 2012 08:14:28 +1000 [thread overview]
Message-ID: <5053AC44.1030909@gmail.com> (raw)
In-Reply-To: <1347658492-11608-5-git-send-email-arnd@arndb.de>
On 15/09/12 07:34, Arnd Bergmann wrote:
> ARM is moving to stricter checks on readl/write functions,
> so we need to use the correct types everywhere.
>
> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
Do you want me to queue both this and my patch to move the
ts72xx.h header into arch/arm/mach-ep93xx on to my ep93xx-fixes
branch? That way you won't have to deal with any conflicts at
your end.
Thanks,
~Ryan
> ---
> arch/arm/mach-ep93xx/include/mach/ts72xx.h | 10 +++++-----
> arch/arm/mach-ep93xx/ts72xx.c | 10 +++++-----
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/mach-ep93xx/include/mach/ts72xx.h b/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> index f1397a1..071feaa 100644
> --- a/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> +++ b/arch/arm/mach-ep93xx/include/mach/ts72xx.h
> @@ -14,7 +14,7 @@
> */
>
> #define TS72XX_MODEL_PHYS_BASE 0x22000000
> -#define TS72XX_MODEL_VIRT_BASE 0xfebff000
> +#define TS72XX_MODEL_VIRT_BASE IOMEM(0xfebff000)
> #define TS72XX_MODEL_SIZE 0x00001000
>
> #define TS72XX_MODEL_TS7200 0x00
> @@ -26,7 +26,7 @@
>
>
> #define TS72XX_OPTIONS_PHYS_BASE 0x22400000
> -#define TS72XX_OPTIONS_VIRT_BASE 0xfebfe000
> +#define TS72XX_OPTIONS_VIRT_BASE IOMEM(0xfebfe000)
> #define TS72XX_OPTIONS_SIZE 0x00001000
>
> #define TS72XX_OPTIONS_COM2_RS485 0x02
> @@ -34,18 +34,18 @@
>
>
> #define TS72XX_OPTIONS2_PHYS_BASE 0x22800000
> -#define TS72XX_OPTIONS2_VIRT_BASE 0xfebfd000
> +#define TS72XX_OPTIONS2_VIRT_BASE IOMEM(0xfebfd000)
> #define TS72XX_OPTIONS2_SIZE 0x00001000
>
> #define TS72XX_OPTIONS2_TS9420 0x04
> #define TS72XX_OPTIONS2_TS9420_BOOT 0x02
>
>
> -#define TS72XX_RTC_INDEX_VIRT_BASE 0xfebf9000
> +#define TS72XX_RTC_INDEX_VIRT_BASE IOMEM(0xfebf9000)
> #define TS72XX_RTC_INDEX_PHYS_BASE 0x10800000
> #define TS72XX_RTC_INDEX_SIZE 0x00001000
>
> -#define TS72XX_RTC_DATA_VIRT_BASE 0xfebf8000
> +#define TS72XX_RTC_DATA_VIRT_BASE IOMEM(0xfebf8000)
> #define TS72XX_RTC_DATA_PHYS_BASE 0x11700000
> #define TS72XX_RTC_DATA_SIZE 0x00001000
>
> diff --git a/arch/arm/mach-ep93xx/ts72xx.c b/arch/arm/mach-ep93xx/ts72xx.c
> index 75cab2d..faa5bdd 100644
> --- a/arch/arm/mach-ep93xx/ts72xx.c
> +++ b/arch/arm/mach-ep93xx/ts72xx.c
> @@ -32,27 +32,27 @@
>
> static struct map_desc ts72xx_io_desc[] __initdata = {
> {
> - .virtual = TS72XX_MODEL_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_MODEL_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_MODEL_PHYS_BASE),
> .length = TS72XX_MODEL_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_OPTIONS_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_OPTIONS_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_OPTIONS_PHYS_BASE),
> .length = TS72XX_OPTIONS_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_OPTIONS2_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_OPTIONS2_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_OPTIONS2_PHYS_BASE),
> .length = TS72XX_OPTIONS2_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_RTC_INDEX_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_RTC_INDEX_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_RTC_INDEX_PHYS_BASE),
> .length = TS72XX_RTC_INDEX_SIZE,
> .type = MT_DEVICE,
> }, {
> - .virtual = TS72XX_RTC_DATA_VIRT_BASE,
> + .virtual = (unsigned long)TS72XX_RTC_DATA_VIRT_BASE,
> .pfn = __phys_to_pfn(TS72XX_RTC_DATA_PHYS_BASE),
> .length = TS72XX_RTC_DATA_SIZE,
> .type = MT_DEVICE,
next prev parent reply other threads:[~2012-09-14 22:14 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 21:34 [PATCH 00/24] ARM: readl/writel conversion fallout Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 01/24] ARM: shmobile: use __iomem pointers for MMIO Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-18 7:11 ` Simon Horman
2012-09-18 7:11 ` Simon Horman
2012-09-18 7:11 ` Simon Horman
2012-09-18 8:31 ` Arnd Bergmann
2012-09-18 8:31 ` Arnd Bergmann
2012-09-18 8:31 ` Arnd Bergmann
2012-09-18 11:50 ` Simon Horman
2012-09-18 11:50 ` Simon Horman
2012-09-18 11:50 ` Simon Horman
2012-09-18 16:04 ` Arnd Bergmann
2012-09-18 16:04 ` Arnd Bergmann
2012-09-18 16:04 ` Arnd Bergmann
2012-09-18 23:56 ` Simon Horman
2012-09-18 23:56 ` Simon Horman
2012-09-18 23:56 ` Simon Horman
2012-09-18 7:42 ` Paul Mundt
2012-09-18 7:42 ` Paul Mundt
2012-09-18 7:42 ` Paul Mundt
2012-09-14 21:34 ` [PATCH 02/24] ARM: at91: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-17 7:56 ` Nicolas Ferre
2012-09-17 7:56 ` Nicolas Ferre
2012-09-18 8:05 ` Arnd Bergmann
2012-09-18 8:05 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 03/24] ARM: ebsa110: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 04/24] ARM: ep93xx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 22:14 ` Ryan Mallon [this message]
2012-09-14 22:14 ` Ryan Mallon
2012-09-15 7:55 ` Arnd Bergmann
2012-09-15 7:55 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 05/24] ARM: imx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 22:31 ` Fabio Estevam
2012-09-14 22:31 ` Fabio Estevam
2012-09-15 17:42 ` Arnd Bergmann
2012-09-15 17:42 ` Arnd Bergmann
2012-09-16 7:21 ` Sascha Hauer
2012-09-16 7:21 ` Sascha Hauer
2012-09-14 21:34 ` [PATCH 06/24] ARM: integrator: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-16 22:19 ` Linus Walleij
2012-09-16 22:19 ` Linus Walleij
2012-09-16 22:35 ` Russell King - ARM Linux
2012-09-16 22:35 ` Russell King - ARM Linux
2012-09-16 22:46 ` Linus Walleij
2012-09-16 22:46 ` Linus Walleij
2012-09-16 23:43 ` Russell King - ARM Linux
2012-09-16 23:43 ` Russell King - ARM Linux
2012-09-14 21:34 ` [PATCH 07/24] ARM: iop13xx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 08/24] ARM: iop32x: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 09/24] ARM: ixp4xx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-18 10:31 ` Krzysztof Halasa
2012-09-18 10:31 ` Krzysztof Halasa
2012-09-18 19:22 ` Krzysztof Halasa
2012-09-18 19:22 ` Krzysztof Halasa
2012-09-19 13:52 ` Arnd Bergmann
2012-09-19 13:52 ` Arnd Bergmann
2012-09-18 20:12 ` [PATCH 08+09/24] " Krzysztof Halasa
2012-09-18 20:12 ` Krzysztof Halasa
2012-09-18 21:25 ` Arnd Bergmann
2012-09-18 21:25 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 10/24] ARM: ks8695: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 11/24] ARM: lpc32xx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 12/24] ARM: msm: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 22:38 ` Stephen Boyd
2012-09-14 22:38 ` Stephen Boyd
2012-09-15 5:16 ` David Brown
2012-09-15 5:16 ` David Brown
2012-09-14 21:34 ` [PATCH 13/24] ARM: nomadik: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-15 11:33 ` Alessandro Rubini
2012-09-15 11:33 ` Alessandro Rubini
2012-09-28 20:13 ` Arnd Bergmann
2012-09-28 20:13 ` Arnd Bergmann
2012-09-16 22:24 ` Linus Walleij
2012-09-16 22:24 ` Linus Walleij
2012-09-14 21:34 ` [PATCH 14/24] ARM: prima2: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 15/24] ARM: sa1100: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 16/24] ARM: spear13xx: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 17/24] ARM: OMAP: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-15 18:10 ` Tony Lindgren
2012-09-15 18:10 ` Tony Lindgren
2012-09-15 20:14 ` Arnd Bergmann
2012-09-15 20:14 ` Arnd Bergmann
2012-09-16 20:38 ` Tony Lindgren
2012-09-16 20:38 ` Tony Lindgren
2012-09-17 21:25 ` Tony Lindgren
2012-09-17 21:25 ` Tony Lindgren
2012-09-19 13:35 ` Arnd Bergmann
2012-09-19 13:35 ` Arnd Bergmann
2012-09-19 13:36 ` Felipe Balbi
2012-09-19 13:36 ` Felipe Balbi
2012-09-19 16:44 ` Tony Lindgren
2012-09-19 16:44 ` Tony Lindgren
2012-09-14 21:34 ` [PATCH 18/24] ARM: samsung: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 19/24] sh: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-18 7:37 ` Paul Mundt
2012-09-18 7:37 ` Paul Mundt
2012-09-18 7:37 ` Paul Mundt
2012-09-18 8:01 ` Arnd Bergmann
2012-09-18 8:01 ` Arnd Bergmann
2012-09-18 8:01 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 20/24] input: rpcmouse: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-19 17:06 ` Dmitry Torokhov
2012-09-19 17:06 ` Dmitry Torokhov
2012-09-14 21:34 ` [PATCH 21/24] serial: ks8695: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 23:44 ` Greg Kroah-Hartman
2012-09-14 23:44 ` Greg Kroah-Hartman
2012-09-14 21:34 ` [PATCH 22/24] scsi: eesox: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 23:27 ` Russell King - ARM Linux
2012-09-14 23:27 ` Russell King - ARM Linux
2012-09-15 8:00 ` Arnd Bergmann
2012-09-15 8:00 ` Arnd Bergmann
2012-09-15 8:57 ` Russell King - ARM Linux
2012-09-15 8:57 ` Russell King - ARM Linux
2012-09-15 8:57 ` Russell King - ARM Linux
2012-09-15 10:30 ` Arnd Bergmann
2012-09-15 10:30 ` Arnd Bergmann
2012-09-17 22:03 ` Russell King - ARM Linux
2012-09-17 22:03 ` Russell King - ARM Linux
2012-09-18 8:09 ` Arnd Bergmann
2012-09-18 8:09 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 23/24] video: da8xx-fb: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 21:34 ` [PATCH 24/24] net: seeq: " Arnd Bergmann
2012-09-14 21:34 ` Arnd Bergmann
2012-09-14 23:56 ` Russell King - ARM Linux
2012-09-14 23:56 ` Russell King - ARM Linux
2012-09-14 23:56 ` Russell King - ARM Linux
2012-09-15 4:00 ` David Miller
2012-09-15 4:00 ` David Miller
2012-09-18 8:14 ` Arnd Bergmann
2012-09-18 8:14 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5053AC44.1030909@gmail.com \
--to=rmallon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.