From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "ABRAHAM, KISHON VIJAY" <kishon@ti.com>
Cc: Sourav Poddar <sourav.poddar@ti.com>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
b-cousson@ti.com, balbi@ti.com, santosh.shilimkar@ti.com,
sameo@linux.intel.com
Subject: Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Mon, 1 Oct 2012 13:09:07 +0100 [thread overview]
Message-ID: <20121001120907.GK4360@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAAe_U6JX9QDWvWA3KH7E9sOv0EHGkozVONuXDgn+a2MZ4GTE7Q@mail.gmail.com>
On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote:
> On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown
> > No, this is not at all sensible - if there's an mfd_remove_devices()
> > function we really ought to be able to use it to remove the children.
> > If we can't do that we should fix the API usability, not open code the
> > same stuff in every user.
> What makes more sense to me is extend mfd_add_devices to create child
> devices from dt data. Then for removing devices, one can use
> mfd_remove_devices().
Why would that be helpful? Most platforms don't support DT at all, and
having the API behave differently depending on the platform doesn't seem
like a step forwards. I would really expect any usage of DT to be
totally orthogonal here.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
Date: Mon, 1 Oct 2012 13:09:07 +0100 [thread overview]
Message-ID: <20121001120907.GK4360@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAAe_U6JX9QDWvWA3KH7E9sOv0EHGkozVONuXDgn+a2MZ4GTE7Q@mail.gmail.com>
On Mon, Oct 01, 2012 at 05:23:15PM +0530, ABRAHAM, KISHON VIJAY wrote:
> On Mon, Oct 1, 2012 at 5:14 PM, Mark Brown
> > No, this is not at all sensible - if there's an mfd_remove_devices()
> > function we really ought to be able to use it to remove the children.
> > If we can't do that we should fix the API usability, not open code the
> > same stuff in every user.
> What makes more sense to me is extend mfd_add_devices to create child
> devices from dt data. Then for removing devices, one can use
> mfd_remove_devices().
Why would that be helpful? Most platforms don't support DT at all, and
having the API behave differently depending on the platform doesn't seem
like a step forwards. I would really expect any usage of DT to be
totally orthogonal here.
next prev parent reply other threads:[~2012-10-01 12:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 11:01 [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Sourav Poddar
2012-10-01 11:01 ` Sourav Poddar
2012-10-01 11:01 ` Sourav Poddar
[not found] ` <1349089282-22105-1-git-send-email-sourav.poddar-l0cyMroinI0@public.gmane.org>
2012-10-01 11:30 ` ABRAHAM, KISHON VIJAY
2012-10-01 11:30 ` ABRAHAM, KISHON VIJAY
2012-10-01 11:30 ` ABRAHAM, KISHON VIJAY
2012-10-01 11:44 ` Mark Brown
2012-10-01 11:44 ` Mark Brown
[not found] ` <20121001114454.GA9170-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2012-10-01 11:53 ` ABRAHAM, KISHON VIJAY
2012-10-01 11:53 ` ABRAHAM, KISHON VIJAY
2012-10-01 11:53 ` ABRAHAM, KISHON VIJAY
2012-10-01 12:09 ` Mark Brown [this message]
2012-10-01 12:09 ` Mark Brown
2012-10-01 15:24 ` ABRAHAM, KISHON VIJAY
2012-10-01 15:24 ` ABRAHAM, KISHON VIJAY
2012-10-02 12:38 ` Mark Brown
2012-10-02 12:38 ` Mark Brown
[not found] ` <20121002123856.GX4360-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-02 12:43 ` Felipe Balbi
2012-10-02 12:43 ` Felipe Balbi
2012-10-02 12:43 ` Felipe Balbi
2012-10-02 12:58 ` Mark Brown
2012-10-02 12:58 ` Mark Brown
2012-10-02 12:58 ` Mark Brown
[not found] ` <20121002125819.GY4360-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-02 13:44 ` Felipe Balbi
2012-10-02 13:44 ` Felipe Balbi
2012-10-02 13:44 ` Felipe Balbi
2012-10-02 19:12 ` ABRAHAM, KISHON VIJAY
2012-10-02 19:12 ` ABRAHAM, KISHON VIJAY
2012-10-01 12:03 ` Samuel Ortiz
2012-10-01 12:03 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121001120907.GK4360@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.