* How to automatically get subsystem name for a file?
@ 2012-10-01 16:57 ` Peter Senna Tschudin
0 siblings, 0 replies; 9+ messages in thread
From: Peter Senna Tschudin @ 2012-10-01 16:57 UTC (permalink / raw)
To: kernelnewbies
I'm trying to figure it out how to automatically get the correct
subsystem string for putting on the first line of the commit message /
subject of the patch message. For example:
Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
^^^^^^^^^^
arch/x86 is only the first two levels of directories from Kernel
source. This may not be smart enough...
What should be the subsystem for the files:
arch/x86/kernel/e820.c
drivers/acpi/thermal.c
drivers/atm/idt77105.c
drivers/block/xen-blkfront.c
drivers/media/dvb-core/dvb_frontend.c
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c
drivers/misc/phantom.c
drivers/misc/sgi-gru/grufault.c
drivers/net/usb/hso.c
drivers/net/wireless/at76c50x-usb.c
drivers/scsi/ncr53c8xx.c
drivers/sh/intc/core.c
drivers/staging/iio/light/tsl2x7x_core.c
fs/btrfs/tree-defrag.c
fs/cifs/connect.c
fs/devpts/inode.c
net/bridge/netfilter/ebtables.c
net/ceph/auth_x.c
net/rds/ib_send.c
sound/pci/bt87x.c
sound/soc/codecs/wm8994.c
sound/usb/caiaq/audio.c
get_maintainers.pl helps but not a lot. Here is it's output for the files above:
arch/x86/kernel/e820.c:X86 ARCHITECTURE (32-BIT AND 64-BIT)
drivers/acpi/thermal.c:ACPI THERMAL DRIVER
drivers/atm/idt77105.c:ATM
drivers/block/xen-blkfront.c:XEN HYPERVISOR INTERFACE
drivers/media/dvb-core/dvb_frontend.c:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)
drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:PVRUSB2 VIDEO4LINUX DRIVER
drivers/misc/phantom.c:SENSABLE PHANTOM
drivers/misc/sgi-gru/grufault.c:SGI GRU DRIVER
drivers/net/usb/hso.c:HSO 3G MODEM DRIVER
drivers/net/wireless/at76c50x-usb.c:NETWORKING [WIRELESS]
drivers/scsi/ncr53c8xx.c:SCSI SUBSYSTEM
drivers/sh/intc/core.c:ARM/SHMOBILE ARM ARCHITECTURE
drivers/staging/iio/light/tsl2x7x_core.c:STAGING - INDUSTRIAL IO
fs/btrfs/tree-defrag.c:BTRFS FILE SYSTEM
fs/cifs/connect.c:COMMON INTERNET FILE SYSTEM (CIFS)
fs/devpts/inode.c:THE REST
net/bridge/netfilter/ebtables.c:EBTABLES
net/ceph/auth_x.c:CEPH DISTRIBUTED FILE SYSTEM CLIENT
net/rds/ib_send.c:RDS - RELIABLE DATAGRAM SOCKETS
sound/pci/bt87x.c:BT87X AUDIO DRIVER
sound/soc/codecs/wm8994.c:WOLFSON MICROELECTRONICS DRIVERS
sound/usb/caiaq/audio.c:NATIVE INSTRUMENTS USB SOUND INTERFACE DRIVER
Subject: [PATCH] NATIVE INSTRUMENTS USB SOUND INTERFACE DRIVER:
Replace memcpy with struct assignment
Do not look as good option too. It is possible to use full path of the
file but leads to Subject over 80 chars.
Any ideas?
--
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: How to automatically get subsystem name for a file?
2012-10-01 16:57 ` Peter Senna Tschudin
(?)
@ 2012-10-01 18:49 ` Dan Carpenter
2012-10-01 19:49 ` Ezequiel Garcia
-1 siblings, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2012-10-01 18:49 UTC (permalink / raw)
To: kernel-janitors
On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
> I'm trying to figure it out how to automatically get the correct
> subsystem string for putting on the first line of the commit message /
> subject of the patch message. For example:
>
> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
> ^^^^^^^^^^
> arch/x86 is only the first two levels of directories from Kernel
> source. This may not be smart enough...
>
You have to do it manually. Here are the relevant lines from my
patch script.
git log --oneline $fullname | head -n 10
echo "Copy and paste one of these subjects?"
read unused
You should be reading through the patch manually anyway and the
reviewer needs to read it manually. It's not like the 20 seconds
it takes to consider which prefix to use is a big deal.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to automatically get subsystem name for a file?
2012-10-01 18:49 ` Dan Carpenter
@ 2012-10-01 19:49 ` Ezequiel Garcia
0 siblings, 0 replies; 9+ messages in thread
From: Ezequiel Garcia @ 2012-10-01 19:49 UTC (permalink / raw)
To: kernelnewbies
On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
>> I'm trying to figure it out how to automatically get the correct
>> subsystem string for putting on the first line of the commit message /
>> subject of the patch message. For example:
>>
>> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>> ^^^^^^^^^^
>> arch/x86 is only the first two levels of directories from Kernel
>> source. This may not be smart enough...
>>
>
> You have to do it manually. Here are the relevant lines from my
> patch script.
>
Manually? Sure there must be some way of auto do it.
Perhaps, parsing Makefile or (if we have access to a build)
use foo.ko files.
I wonder why we don't have a standardized way of naming drivers, yet.
Something like MODULE_AUTHOR, called MODULE_NAME.
(Yes, I realize it won't work if the driver is built-in)
> git log --oneline $fullname | head -n 10
> echo "Copy and paste one of these subjects?"
> read unused
>
> You should be reading through the patch manually anyway and the
> reviewer needs to read it manually. It's not like the 20 seconds
> it takes to consider which prefix to use is a big deal.
>
Sorry Dan, I couldn't catch what you meant by this.
I guess my english slang is not *that* sharp.
Thanks,
Ezequiel.
^ permalink raw reply [flat|nested] 9+ messages in thread
* How to automatically get subsystem name for a file?
@ 2012-10-01 19:49 ` Ezequiel Garcia
0 siblings, 0 replies; 9+ messages in thread
From: Ezequiel Garcia @ 2012-10-01 19:49 UTC (permalink / raw)
To: kernelnewbies
On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
>> I'm trying to figure it out how to automatically get the correct
>> subsystem string for putting on the first line of the commit message /
>> subject of the patch message. For example:
>>
>> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>> ^^^^^^^^^^
>> arch/x86 is only the first two levels of directories from Kernel
>> source. This may not be smart enough...
>>
>
> You have to do it manually. Here are the relevant lines from my
> patch script.
>
Manually? Sure there must be some way of auto do it.
Perhaps, parsing Makefile or (if we have access to a build)
use foo.ko files.
I wonder why we don't have a standardized way of naming drivers, yet.
Something like MODULE_AUTHOR, called MODULE_NAME.
(Yes, I realize it won't work if the driver is built-in)
> git log --oneline $fullname | head -n 10
> echo "Copy and paste one of these subjects?"
> read unused
>
> You should be reading through the patch manually anyway and the
> reviewer needs to read it manually. It's not like the 20 seconds
> it takes to consider which prefix to use is a big deal.
>
Sorry Dan, I couldn't catch what you meant by this.
I guess my english slang is not *that* sharp.
Thanks,
Ezequiel.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to automatically get subsystem name for a file?
2012-10-01 16:57 ` Peter Senna Tschudin
(?)
(?)
@ 2012-10-01 20:51 ` Dan Carpenter
2012-10-02 0:31 ` Ezequiel Garcia
-1 siblings, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2012-10-01 20:51 UTC (permalink / raw)
To: kernel-janitors
On Mon, Oct 01, 2012 at 04:49:13PM -0300, Ezequiel Garcia wrote:
> On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
> >> I'm trying to figure it out how to automatically get the correct
> >> subsystem string for putting on the first line of the commit message /
> >> subject of the patch message. For example:
> >>
> >> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
> >> ^^^^^^^^^^
> >> arch/x86 is only the first two levels of directories from Kernel
> >> source. This may not be smart enough...
> >>
> >
> > You have to do it manually. Here are the relevant lines from my
> > patch script.
> >
>
> Manually? Sure there must be some way of auto do it.
There really isn't an automatic way. For example [media] and [SCSI]
are non-standard.
I look at it as a good thing that people have to do it manually. It
hopefully makes them slow down a bit.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to automatically get subsystem name for a file?
2012-10-01 20:51 ` Dan Carpenter
@ 2012-10-02 0:31 ` Ezequiel Garcia
0 siblings, 0 replies; 9+ messages in thread
From: Ezequiel Garcia @ 2012-10-02 0:31 UTC (permalink / raw)
To: kernelnewbies
On Mon, Oct 1, 2012 at 5:51 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Oct 01, 2012 at 04:49:13PM -0300, Ezequiel Garcia wrote:
>> On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
>> >> I'm trying to figure it out how to automatically get the correct
>> >> subsystem string for putting on the first line of the commit message /
>> >> subject of the patch message. For example:
>> >>
>> >> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>> >> ^^^^^^^^^^
>> >> arch/x86 is only the first two levels of directories from Kernel
>> >> source. This may not be smart enough...
>> >>
>> >
>> > You have to do it manually. Here are the relevant lines from my
>> > patch script.
>> >
>>
>> Manually? Sure there must be some way of auto do it.
>
> There really isn't an automatic way. For example [media] and [SCSI]
> are non-standard.
>
> I look at it as a good thing that people have to do it manually. It
> hopefully makes them slow down a bit.
>
Agreed.
Slow down, less maintainers head.
Thanks,
Ezequiel.
^ permalink raw reply [flat|nested] 9+ messages in thread
* How to automatically get subsystem name for a file?
@ 2012-10-02 0:31 ` Ezequiel Garcia
0 siblings, 0 replies; 9+ messages in thread
From: Ezequiel Garcia @ 2012-10-02 0:31 UTC (permalink / raw)
To: kernelnewbies
On Mon, Oct 1, 2012 at 5:51 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Oct 01, 2012 at 04:49:13PM -0300, Ezequiel Garcia wrote:
>> On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> > On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
>> >> I'm trying to figure it out how to automatically get the correct
>> >> subsystem string for putting on the first line of the commit message /
>> >> subject of the patch message. For example:
>> >>
>> >> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>> >> ^^^^^^^^^^
>> >> arch/x86 is only the first two levels of directories from Kernel
>> >> source. This may not be smart enough...
>> >>
>> >
>> > You have to do it manually. Here are the relevant lines from my
>> > patch script.
>> >
>>
>> Manually? Sure there must be some way of auto do it.
>
> There really isn't an automatic way. For example [media] and [SCSI]
> are non-standard.
>
> I look at it as a good thing that people have to do it manually. It
> hopefully makes them slow down a bit.
>
Agreed.
Slow down, less maintainers head.
Thanks,
Ezequiel.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: How to automatically get subsystem name for a file?
2012-10-01 16:57 ` Peter Senna Tschudin
` (2 preceding siblings ...)
(?)
@ 2012-10-02 5:12 ` Julia Lawall
-1 siblings, 0 replies; 9+ messages in thread
From: Julia Lawall @ 2012-10-02 5:12 UTC (permalink / raw)
To: kernel-janitors
On Mon, 1 Oct 2012, Ezequiel Garcia wrote:
> On Mon, Oct 1, 2012 at 5:51 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>> On Mon, Oct 01, 2012 at 04:49:13PM -0300, Ezequiel Garcia wrote:
>>> On Mon, Oct 1, 2012 at 3:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>>> On Mon, Oct 01, 2012 at 06:57:44PM +0200, Peter Senna Tschudin wrote:
>>>>> I'm trying to figure it out how to automatically get the correct
>>>>> subsystem string for putting on the first line of the commit message /
>>>>> subject of the patch message. For example:
>>>>>
>>>>> Subject: [PATCH 001/142] arch/x86: Replace memcpy with struct assignment
>>>>> ^^^^^^^^^^
>>>>> arch/x86 is only the first two levels of directories from Kernel
>>>>> source. This may not be smart enough...
>>>>>
>>>>
>>>> You have to do it manually. Here are the relevant lines from my
>>>> patch script.
>>>>
>>>
>>> Manually? Sure there must be some way of auto do it.
>>
>> There really isn't an automatic way. For example [media] and [SCSI]
>> are non-standard.
This information could be integrated into get_maintainers somehow.
>> I look at it as a good thing that people have to do it manually. It
>> hopefully makes them slow down a bit.
>>
>
> Agreed.
> Slow down, less maintainers head.
It's a nuisance if one makes a lot of patches at once (by a lot I mean 5
or more). Especially if one realizes midstream that something is wrong
and has to start over. Of course, one could leave this manual step to the
very end, when one is sure that everything is OK, but I would rather be
studying the absolutely final version rather than the not quite final one.
julia
^ permalink raw reply [flat|nested] 9+ messages in thread