From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir
Date: Wed, 3 Oct 2012 13:23:35 -0500 [thread overview]
Message-ID: <20121003182335.GD16157@illuin> (raw)
In-Reply-To: <1349285059-5415-3-git-send-email-lcapitulino@redhat.com>
On Wed, Oct 03, 2012 at 02:24:18PM -0300, Luiz Capitulino wrote:
> Defaults to /var/run.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Since this has the effect of changing both the default directory for
state and well as the pid file, maybe we should s@state@state/pidfile@
the human-readable descriptions?
> ---
> configure | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/configure b/configure
> index 4cfcdc6..4f3d2ed 100755
> --- a/configure
> +++ b/configure
> @@ -215,6 +215,7 @@ usb_redir=""
> opengl=""
> zlib="yes"
> qemuga="yes"
> +qemuga_statedir="/var/run"
> want_tools="yes"
> libiscsi=""
> coroutine=""
> @@ -628,6 +629,8 @@ for opt do
> ;;
> --sysconfdir=*) sysconfdir="$optarg"
> ;;
> + --guest-agent-statedir=*) qemuga_statedir="$optarg"
> + ;;
> --sbindir=*|--sharedstatedir=*|--localstatedir=*|\
> --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
> --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> @@ -1022,6 +1025,7 @@ echo " --datadir=PATH install firmware in PATH$confsuffix"
> echo " --docdir=PATH install documentation in PATH$confsuffix"
> echo " --bindir=PATH install binaries in PATH"
> echo " --sysconfdir=PATH install config in PATH$confsuffix"
> +echo " --guest-agent-statedir=PATH set Guest Agent state directory to PATH"
> echo " --with-confsuffix=SUFFIX suffix for QEMU data inside datadir and sysconfdir [$confsuffix]"
> echo " --enable-debug-tcg enable TCG debugging"
> echo " --disable-debug-tcg disable TCG debugging (default)"
> @@ -3086,6 +3090,7 @@ echo "library directory `eval echo $libdir`"
> echo "libexec directory `eval echo $libexecdir`"
> echo "include directory `eval echo $includedir`"
> echo "config directory `eval echo $sysconfdir`"
> +echo "qemu-ga state directory $qemuga_statedir"
> if test "$mingw32" = "no" ; then
> echo "Manual directory `eval echo $mandir`"
> echo "ELF interp prefix $interp_prefix"
> @@ -3196,6 +3201,7 @@ echo "qemu_datadir=$qemu_datadir" >> $config_host_mak
> echo "qemu_docdir=$qemu_docdir" >> $config_host_mak
> echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak
>
> +echo "CONFIG_QEMUGA_STATEDIR=\"$qemuga_statedir\"" >> $config_host_mak
> echo "ARCH=$ARCH" >> $config_host_mak
> if test "$debug_tcg" = "yes" ; then
> echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak
> --
> 1.7.12.315.g682ce8b
>
next prev parent reply other threads:[~2012-10-03 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:24 [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 1/3] configure: guest_agent -> qemuga Luiz Capitulino
2012-10-03 18:08 ` Michael Roth
2012-10-03 17:24 ` [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir Luiz Capitulino
2012-10-03 18:13 ` Michael Roth
2012-10-03 18:23 ` Michael Roth [this message]
2012-10-03 18:32 ` Paolo Bonzini
2012-10-03 18:53 ` Luiz Capitulino
2012-10-03 18:56 ` Paolo Bonzini
2012-10-03 19:00 ` Luiz Capitulino
2012-10-03 17:24 ` [Qemu-devel] [PATCH 3/3] qemu-ga: use state dir from CONFIG_QEMUGA_STATEDIR Luiz Capitulino
2012-10-03 18:20 ` Michael Roth
2012-10-03 18:33 ` [Qemu-devel] [PATCH 0/3] qemu-ga: change default state dir to /var/run Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121003182335.GD16157@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.