Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir

[Paolo Bonzini <pbonzini@redhat.com>]

Il 03/10/2012 20:53, Luiz Capitulino ha scritto:
> On Wed, 03 Oct 2012 20:32:21 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
>> Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
>>> Defaults to /var/run.
>>
>> Please add instead --localstatedir (defaulting to ${prefix}/var), and
>> make the guest agent's directory /run inside that one.  Packagers
>> already know to override --localstatedir=/var, in some cases macros even
>> do it automatically.
> 
> Well, that was my first version but I discarded it for two reasons.
> 
> First, --localstatedir is a host-side setting but qemu-ga is not supposed to
> run in the host. What if I want a different setting for guests?

Then you should build twice, like you do when the guest is a completely
different OS.

> Second, having /run appended to --localstatedir (or whatever we choose) may
> have a bad effect if qemu is built with --localstatedir=, where qemu-ga's
> state will be "/run" (good for Fedora, but might not be good for other
> distros or other unixes).

I'm not sure I follow, it would be --localstatedir=/var usually.  Even
Fedora would not use --localstatedir=.

Paolo

> 
> I'm not strong about this though, it just was my reasoning while doing this.
> 
>