Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir

[Paolo Bonzini <pbonzini@redhat.com>]

Il 03/10/2012 19:24, Luiz Capitulino ha scritto:
> Defaults to /var/run.

Please add instead --localstatedir (defaulting to ${prefix}/var), and
make the guest agent's directory /run inside that one.  Packagers
already know to override --localstatedir=/var, in some cases macros even
do it automatically.

Paolo

> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  configure | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/configure b/configure
> index 4cfcdc6..4f3d2ed 100755
> --- a/configure
> +++ b/configure
> @@ -215,6 +215,7 @@ usb_redir=""
>  opengl=""
>  zlib="yes"
>  qemuga="yes"
> +qemuga_statedir="/var/run"
>  want_tools="yes"
>  libiscsi=""
>  coroutine=""
> @@ -628,6 +629,8 @@ for opt do
>    ;;
>    --sysconfdir=*) sysconfdir="$optarg"
>    ;;
> +  --guest-agent-statedir=*) qemuga_statedir="$optarg"
> +  ;;
>    --sbindir=*|--sharedstatedir=*|--localstatedir=*|\
>    --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\
>    --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*)
> @@ -1022,6 +1025,7 @@ echo "  --datadir=PATH           install firmware in PATH$confsuffix"
>  echo "  --docdir=PATH            install documentation in PATH$confsuffix"
>  echo "  --bindir=PATH            install binaries in PATH"
>  echo "  --sysconfdir=PATH        install config in PATH$confsuffix"
> +echo "  --guest-agent-statedir=PATH   set Guest Agent state directory to PATH"
>  echo "  --with-confsuffix=SUFFIX suffix for QEMU data inside datadir and sysconfdir [$confsuffix]"
>  echo "  --enable-debug-tcg       enable TCG debugging"
>  echo "  --disable-debug-tcg      disable TCG debugging (default)"
> @@ -3086,6 +3090,7 @@ echo "library directory `eval echo $libdir`"
>  echo "libexec directory `eval echo $libexecdir`"
>  echo "include directory `eval echo $includedir`"
>  echo "config directory  `eval echo $sysconfdir`"
> +echo "qemu-ga state directory  $qemuga_statedir"
>  if test "$mingw32" = "no" ; then
>  echo "Manual directory  `eval echo $mandir`"
>  echo "ELF interp prefix $interp_prefix"
> @@ -3196,6 +3201,7 @@ echo "qemu_datadir=$qemu_datadir" >> $config_host_mak
>  echo "qemu_docdir=$qemu_docdir" >> $config_host_mak
>  echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak
>  
> +echo "CONFIG_QEMUGA_STATEDIR=\"$qemuga_statedir\"" >> $config_host_mak
>  echo "ARCH=$ARCH" >> $config_host_mak
>  if test "$debug_tcg" = "yes" ; then
>    echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak
>