From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix2
Date: Fri, 5 Oct 2012 10:59:45 +0100 [thread overview]
Message-ID: <20121005095945.GC29125@suse.de> (raw)
In-Reply-To: <20121004140017.GW29125@suse.de>
Thierry reported offline that the strict check "mm: compaction: Iron out
isolate_freepages_block() and isolate_freepages_range() -fix1" check is
still too strict because it's possible for more pages to be isolated
than required. This patch corrects the check.
There are still CMA-related problems but they are "somewhere else" yet
to be determined.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 2c4ce17..9eef558 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -346,7 +346,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
* pages requested were isolated. If there were any failures, 0 is
* returned and CMA will fail.
*/
- if (strict && nr_strict_required != total_isolated)
+ if (strict && nr_strict_required > total_isolated)
total_isolated = 0;
if (locked)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Minchan Kim <minchan@kernel.org>,
Thierry Reding <thierry.reding@avionic-design.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix2
Date: Fri, 5 Oct 2012 10:59:45 +0100 [thread overview]
Message-ID: <20121005095945.GC29125@suse.de> (raw)
In-Reply-To: <20121004140017.GW29125@suse.de>
Thierry reported offline that the strict check "mm: compaction: Iron out
isolate_freepages_block() and isolate_freepages_range() -fix1" check is
still too strict because it's possible for more pages to be isolated
than required. This patch corrects the check.
There are still CMA-related problems but they are "somewhere else" yet
to be determined.
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
mm/compaction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 2c4ce17..9eef558 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -346,7 +346,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
* pages requested were isolated. If there were any failures, 0 is
* returned and CMA will fail.
*/
- if (strict && nr_strict_required != total_isolated)
+ if (strict && nr_strict_required > total_isolated)
total_isolated = 0;
if (locked)
next prev parent reply other threads:[~2012-10-05 9:59 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 11:29 CMA broken in next-20120926 Thierry Reding
2012-09-27 15:59 ` Marek Szyprowski
2012-09-27 17:49 ` Mark Brown
2012-09-27 22:11 ` Andrew Morton
2012-09-27 22:11 ` Andrew Morton
2012-09-28 5:43 ` Minchan Kim
2012-09-28 5:43 ` Minchan Kim
2012-09-28 6:10 ` Thierry Reding
2012-09-28 7:44 ` Peter Ujfalusi
2012-09-28 7:44 ` Peter Ujfalusi
2012-09-28 7:56 ` Mel Gorman
2012-09-28 7:56 ` Mel Gorman
2012-09-28 8:09 ` Mel Gorman
2012-09-28 8:09 ` Mel Gorman
2012-09-28 8:37 ` Mel Gorman
2012-09-28 8:37 ` Mel Gorman
2012-09-28 8:48 ` Peter Ujfalusi
2012-09-28 8:48 ` Peter Ujfalusi
2012-09-28 10:27 ` Mel Gorman
2012-09-28 10:27 ` Mel Gorman
2012-09-28 10:32 ` Thierry Reding
2012-09-28 10:38 ` Thierry Reding
2012-09-28 10:51 ` Thierry Reding
2012-09-28 11:07 ` Mel Gorman
2012-09-28 11:07 ` Mel Gorman
2012-09-28 11:39 ` Thierry Reding
2012-09-28 12:43 ` Mel Gorman
2012-09-28 12:43 ` Mel Gorman
2012-10-01 14:24 ` Thierry Reding
2012-10-02 12:48 ` Thierry Reding
2012-10-02 14:41 ` Mel Gorman
2012-10-02 14:41 ` Mel Gorman
2012-10-02 15:03 ` Thierry Reding
2012-10-02 15:12 ` Mel Gorman
2012-10-02 15:12 ` Mel Gorman
2012-10-08 8:06 ` Minchan Kim
2012-10-08 8:06 ` Minchan Kim
2012-10-08 8:48 ` Mel Gorman
2012-10-08 8:48 ` Mel Gorman
2012-10-09 8:40 ` Bartlomiej Zolnierkiewicz
2012-10-09 8:40 ` Bartlomiej Zolnierkiewicz
2012-10-09 10:11 ` Mel Gorman
2012-10-09 10:11 ` Mel Gorman
2012-10-09 11:02 ` Thierry Reding
2012-10-09 11:08 ` Bartlomiej Zolnierkiewicz
2012-10-09 11:08 ` Bartlomiej Zolnierkiewicz
2012-10-09 11:32 ` Mel Gorman
2012-10-09 11:32 ` Mel Gorman
2012-10-09 11:38 ` Thierry Reding
2012-09-28 10:52 ` Mel Gorman
2012-09-28 10:52 ` Mel Gorman
2012-10-04 14:00 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1 Mel Gorman
2012-10-04 14:00 ` Mel Gorman
2012-10-05 9:59 ` Mel Gorman [this message]
2012-10-05 9:59 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix2 Mel Gorman
2012-10-08 6:50 ` Minchan Kim
2012-10-08 6:50 ` Minchan Kim
2012-10-08 6:53 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1 Minchan Kim
2012-10-08 6:53 ` Minchan Kim
2012-10-04 14:03 ` [PATCH] mm: compaction: Cache if a pageblock was scanned and no pages were isolated -fix3 Mel Gorman
2012-10-04 14:03 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005095945.GC29125@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.