From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: CMA broken in next-20120926
Date: Mon, 8 Oct 2012 09:48:07 +0100 [thread overview]
Message-ID: <20121008084806.GH29125@suse.de> (raw)
In-Reply-To: <20121008080654.GD13817@bbox>
On Mon, Oct 08, 2012 at 05:06:54PM +0900, Minchan Kim wrote:
> Hi Mel,
>
> On Tue, Oct 02, 2012 at 04:12:17PM +0100, Mel Gorman wrote:
> > On Tue, Oct 02, 2012 at 05:03:07PM +0200, Thierry Reding wrote:
> > > On Tue, Oct 02, 2012 at 03:41:35PM +0100, Mel Gorman wrote:
> > > > On Tue, Oct 02, 2012 at 02:48:14PM +0200, Thierry Reding wrote:
> > > > > > So this really isn't all that new, but I just wanted to confirm my
> > > > > > results from last week. We'll see if bisection shows up something
> > > > > > interesting.
> > > > >
> > > > > I just finished bisecting this and git reports:
> > > > >
> > > > > 3750280f8bd0ed01753a72542756a8c82ab27933 is the first bad commit
> > > > >
> > > > > I'm attaching the complete bisection log and a diff of all the changes
> > > > > applied on top of the bad commit to make it compile and run on my board.
> > > > > Most of the patch is probably not important, though. There are two hunks
> > > > > which have the pageblock changes I already posted an two other hunks
> > > > > with the patch you posted earlier.
> > > > >
> > > > > I hope this helps. If you want me to run any other tests, please let me
> > > > > know.
> > > > >
> > > >
> > > > Can you test with this on top please?
> > >
> > > That doesn't build on top of the bad commit. Or is it supposed to go on
> > > top of next-20120926?
> > >
> >
> > It doesn't build or do you mean it doesn't apply? Assuming the problem
> > was that it didn't apply then try this one. It applies on top of
> > next-20120928 which is the closest tag I have to next-20120926.
> >
> > ---8<---
> > mm: compaction: Cache if a pageblock was scanned and no pages were isolated -fix3
> >
> > CMA requires that the PG_migrate_skip hint be skipped but it was only
> > skipping it when isolating pages for migration, not for free. Ensure
> > cc->isolate_skip_hint gets passed in both cases.
> >
> > This is a fix for
> > mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated-fix.patch
> >
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Minchan Kim <minchan@kernel.org>
>
> But please resend below compile error fixing.
>
Thanks Minchan. I did resent this patch to Andrew with the subject "[PATCH]
mm: compaction: Cache if a pageblock was scanned and no pages were isolated
-fix3". It should have had the build errors fixed but has not been
picked up yet.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan@kernel.org>
Cc: Thierry Reding <thierry.reding@avionic-design.de>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: CMA broken in next-20120926
Date: Mon, 8 Oct 2012 09:48:07 +0100 [thread overview]
Message-ID: <20121008084806.GH29125@suse.de> (raw)
In-Reply-To: <20121008080654.GD13817@bbox>
On Mon, Oct 08, 2012 at 05:06:54PM +0900, Minchan Kim wrote:
> Hi Mel,
>
> On Tue, Oct 02, 2012 at 04:12:17PM +0100, Mel Gorman wrote:
> > On Tue, Oct 02, 2012 at 05:03:07PM +0200, Thierry Reding wrote:
> > > On Tue, Oct 02, 2012 at 03:41:35PM +0100, Mel Gorman wrote:
> > > > On Tue, Oct 02, 2012 at 02:48:14PM +0200, Thierry Reding wrote:
> > > > > > So this really isn't all that new, but I just wanted to confirm my
> > > > > > results from last week. We'll see if bisection shows up something
> > > > > > interesting.
> > > > >
> > > > > I just finished bisecting this and git reports:
> > > > >
> > > > > 3750280f8bd0ed01753a72542756a8c82ab27933 is the first bad commit
> > > > >
> > > > > I'm attaching the complete bisection log and a diff of all the changes
> > > > > applied on top of the bad commit to make it compile and run on my board.
> > > > > Most of the patch is probably not important, though. There are two hunks
> > > > > which have the pageblock changes I already posted an two other hunks
> > > > > with the patch you posted earlier.
> > > > >
> > > > > I hope this helps. If you want me to run any other tests, please let me
> > > > > know.
> > > > >
> > > >
> > > > Can you test with this on top please?
> > >
> > > That doesn't build on top of the bad commit. Or is it supposed to go on
> > > top of next-20120926?
> > >
> >
> > It doesn't build or do you mean it doesn't apply? Assuming the problem
> > was that it didn't apply then try this one. It applies on top of
> > next-20120928 which is the closest tag I have to next-20120926.
> >
> > ---8<---
> > mm: compaction: Cache if a pageblock was scanned and no pages were isolated -fix3
> >
> > CMA requires that the PG_migrate_skip hint be skipped but it was only
> > skipping it when isolating pages for migration, not for free. Ensure
> > cc->isolate_skip_hint gets passed in both cases.
> >
> > This is a fix for
> > mm-compaction-cache-if-a-pageblock-was-scanned-and-no-pages-were-isolated-fix.patch
> >
> > Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Minchan Kim <minchan@kernel.org>
>
> But please resend below compile error fixing.
>
Thanks Minchan. I did resent this patch to Andrew with the subject "[PATCH]
mm: compaction: Cache if a pageblock was scanned and no pages were isolated
-fix3". It should have had the build errors fixed but has not been
picked up yet.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2012-10-08 8:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 11:29 CMA broken in next-20120926 Thierry Reding
2012-09-27 15:59 ` Marek Szyprowski
2012-09-27 17:49 ` Mark Brown
2012-09-27 22:11 ` Andrew Morton
2012-09-27 22:11 ` Andrew Morton
2012-09-28 5:43 ` Minchan Kim
2012-09-28 5:43 ` Minchan Kim
2012-09-28 6:10 ` Thierry Reding
2012-09-28 7:44 ` Peter Ujfalusi
2012-09-28 7:44 ` Peter Ujfalusi
2012-09-28 7:56 ` Mel Gorman
2012-09-28 7:56 ` Mel Gorman
2012-09-28 8:09 ` Mel Gorman
2012-09-28 8:09 ` Mel Gorman
2012-09-28 8:37 ` Mel Gorman
2012-09-28 8:37 ` Mel Gorman
2012-09-28 8:48 ` Peter Ujfalusi
2012-09-28 8:48 ` Peter Ujfalusi
2012-09-28 10:27 ` Mel Gorman
2012-09-28 10:27 ` Mel Gorman
2012-09-28 10:32 ` Thierry Reding
2012-09-28 10:38 ` Thierry Reding
2012-09-28 10:51 ` Thierry Reding
2012-09-28 11:07 ` Mel Gorman
2012-09-28 11:07 ` Mel Gorman
2012-09-28 11:39 ` Thierry Reding
2012-09-28 12:43 ` Mel Gorman
2012-09-28 12:43 ` Mel Gorman
2012-10-01 14:24 ` Thierry Reding
2012-10-02 12:48 ` Thierry Reding
2012-10-02 14:41 ` Mel Gorman
2012-10-02 14:41 ` Mel Gorman
2012-10-02 15:03 ` Thierry Reding
2012-10-02 15:12 ` Mel Gorman
2012-10-02 15:12 ` Mel Gorman
2012-10-08 8:06 ` Minchan Kim
2012-10-08 8:06 ` Minchan Kim
2012-10-08 8:48 ` Mel Gorman [this message]
2012-10-08 8:48 ` Mel Gorman
2012-10-09 8:40 ` Bartlomiej Zolnierkiewicz
2012-10-09 8:40 ` Bartlomiej Zolnierkiewicz
2012-10-09 10:11 ` Mel Gorman
2012-10-09 10:11 ` Mel Gorman
2012-10-09 11:02 ` Thierry Reding
2012-10-09 11:08 ` Bartlomiej Zolnierkiewicz
2012-10-09 11:08 ` Bartlomiej Zolnierkiewicz
2012-10-09 11:32 ` Mel Gorman
2012-10-09 11:32 ` Mel Gorman
2012-10-09 11:38 ` Thierry Reding
2012-09-28 10:52 ` Mel Gorman
2012-09-28 10:52 ` Mel Gorman
2012-10-04 14:00 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1 Mel Gorman
2012-10-04 14:00 ` Mel Gorman
2012-10-05 9:59 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix2 Mel Gorman
2012-10-05 9:59 ` Mel Gorman
2012-10-08 6:50 ` Minchan Kim
2012-10-08 6:50 ` Minchan Kim
2012-10-08 6:53 ` [PATCH] mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1 Minchan Kim
2012-10-08 6:53 ` Minchan Kim
2012-10-04 14:03 ` [PATCH] mm: compaction: Cache if a pageblock was scanned and no pages were isolated -fix3 Mel Gorman
2012-10-04 14:03 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008084806.GH29125@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.