From: Sergey Senozhatsky <sergey.senozhatsky at gmail.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [RFC][PATCH 1/2] Adding report generator facility
Date: Mon, 08 Oct 2012 09:57:44 -0700 [thread overview]
Message-ID: <20121008165743.GA21958@swordfish.datadirect.datadirectnet.com> (raw)
In-Reply-To: 1349283900-26721-1-git-send-email-i.zhbanov@samsung.com
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
On (10/03/12 21:05), Igor Zhbanov wrote:
> ---
> po/Makevars | 2 +-
> src/Makefile.am | 4 +
> src/report/report-formatter-csv.cpp | 274 ++++++++++++++++++
> src/report/report-formatter-csv.h | 89 ++++++
> src/report/report-formatter-html.cpp | 514 ++++++++++++++++++++++++++++++++++
> src/report/report-formatter-html.h | 127 +++++++++
> src/report/report-formatter-null.cpp | 179 ++++++++++++
> src/report/report-formatter-null.h | 67 +++++
> src/report/report-formatter.h | 63 ++++
> src/report/report-maker.cpp | 331 ++++++++++++++++++++++
> src/report/report-maker.h | 209 ++++++++++++++
> 11 files changed, 1858 insertions(+), 1 deletions(-)
> create mode 100644 src/report/report-formatter-csv.cpp
> create mode 100644 src/report/report-formatter-csv.h
> create mode 100644 src/report/report-formatter-html.cpp
> create mode 100644 src/report/report-formatter-html.h
> create mode 100644 src/report/report-formatter-null.cpp
> create mode 100644 src/report/report-formatter-null.h
> create mode 100644 src/report/report-formatter.h
> create mode 100644 src/report/report-maker.cpp
> create mode 100644 src/report/report-maker.h
>
Hello,
- can we please avoid code duplication? for example, both html and csv
reporters contain identical implementations of
clear_result()/get_result()/add*() and friends.
- I think null formatter could be a basic class with default
implementation (null) of virtual functions, rather than separate
implementation of basic formatter interface (abstract class).
-ss
next reply other threads:[~2012-10-08 16:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 16:57 Sergey Senozhatsky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-10 15:53 [Powertop] [RFC][PATCH 1/2] Adding report generator facility Chris Ferron
2012-10-10 15:39 Sergey Senozhatsky
2012-10-10 12:49 Igor Zhbanov
2012-10-09 19:31 Sergey Senozhatsky
2012-10-09 19:11 Sergey Senozhatsky
2012-10-09 19:03 Sergey Senozhatsky
2012-10-09 18:55 Sergey Senozhatsky
2012-10-09 17:25 Igor Zhbanov
2012-10-09 17:02 Igor Zhbanov
2012-10-05 10:15 Igor Zhbanov
2012-10-04 21:17 Sergey Senozhatsky
2012-10-04 21:07 Sergey Senozhatsky
2012-10-04 16:08 Ferron, Chris E
2012-10-03 17:05 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121008165743.GA21958@swordfish.datadirect.datadirectnet.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.