From: Igor Zhbanov <i.zhbanov at samsung.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [RFC][PATCH 1/2] Adding report generator facility
Date: Fri, 05 Oct 2012 14:15:52 +0400 [thread overview]
Message-ID: <506EB358.8020100@samsung.com> (raw)
In-Reply-To: 20121004211717.GB3333@swordfish.datadirect.datadirectnet.com
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
Hi Sergey,
Sergey Senozhatsky wrote:
> it's better have a destructor in abstract class.
Yes, you are right. Thank you.
To not send the big patch again, here is the small fix.
I will send the new version when other issues will be resolved, if any will be found,
and without [RFC] tag.
--- src/report/report-formatter.h 2012-10-03 20:52:36.834281876 +0400
+++ src/report/report-formatter.h 2012-10-05 13:22:04.307887912 +0400
@@ -31,6 +31,8 @@
class report_formatter /* Interface */
{
public:
+ virtual ~report_formatter() {}
+
virtual void finish_report() = 0;
virtual const char *get_result() = 0;
virtual void clear_result() = 0;
--
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com
ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation
next reply other threads:[~2012-10-05 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 10:15 Igor Zhbanov [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-10 15:53 [Powertop] [RFC][PATCH 1/2] Adding report generator facility Chris Ferron
2012-10-10 15:39 Sergey Senozhatsky
2012-10-10 12:49 Igor Zhbanov
2012-10-09 19:31 Sergey Senozhatsky
2012-10-09 19:11 Sergey Senozhatsky
2012-10-09 19:03 Sergey Senozhatsky
2012-10-09 18:55 Sergey Senozhatsky
2012-10-09 17:25 Igor Zhbanov
2012-10-09 17:02 Igor Zhbanov
2012-10-08 16:57 Sergey Senozhatsky
2012-10-04 21:17 Sergey Senozhatsky
2012-10-04 21:07 Sergey Senozhatsky
2012-10-04 16:08 Ferron, Chris E
2012-10-03 17:05 Igor Zhbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506EB358.8020100@samsung.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.