From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 13:40:58 +0900 [thread overview]
Message-ID: <20121012044042.GI11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1350009258-10044-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
On Fri, Oct 12, 2012 at 10:34:18AM +0800, Bo Shen wrote:
> As the old method will use platform device id, change the id to
> let the i2c device work
What are "the old method" and new method? You're not explaining why
this is needed...
> static struct platform_device at91sam9260_twi_device = {
> .name = "i2c-gpio",
> - .id = -1,
> + .id = 0,
> .dev.platform_data = &pdata,
This looks like a regression, if there's only one of a given type of
device in the system it should have no numeric ID in the display name so
having -1 is appropriate.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 13:40:58 +0900 [thread overview]
Message-ID: <20121012044042.GI11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1350009258-10044-1-git-send-email-voice.shen@atmel.com>
On Fri, Oct 12, 2012 at 10:34:18AM +0800, Bo Shen wrote:
> As the old method will use platform device id, change the id to
> let the i2c device work
What are "the old method" and new method? You're not explaining why
this is needed...
> static struct platform_device at91sam9260_twi_device = {
> .name = "i2c-gpio",
> - .id = -1,
> + .id = 0,
> .dev.platform_data = &pdata,
This looks like a regression, if there's only one of a given type of
device in the system it should have no numeric ID in the display name so
having -1 is appropriate.
next prev parent reply other threads:[~2012-10-12 4:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 2:34 [PATCH] i2c: change the id to let the i2c device work Bo Shen
2012-10-12 2:34 ` Bo Shen
[not found] ` <1350009258-10044-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 4:40 ` Mark Brown [this message]
2012-10-12 4:40 ` Mark Brown
[not found] ` <20121012044042.GI11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 4:57 ` Bo Shen
2012-10-12 4:57 ` Bo Shen
[not found] ` <5077A33E.4080801-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 5:14 ` Mark Brown
2012-10-12 5:14 ` Mark Brown
[not found] ` <20121012051419.GJ11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:53 ` Mark Brown
2012-10-12 5:53 ` Mark Brown
[not found] ` <20121012055301.GM11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 6:42 ` Bo Shen
2012-10-12 6:42 ` Bo Shen
2012-10-12 7:14 ` Jean Delvare
2012-10-12 7:14 ` Jean Delvare
[not found] ` <20121012091427.0d7b2bed-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-12 7:55 ` Bo Shen
2012-10-12 7:55 ` Bo Shen
[not found] ` <5077CCF4.7070104-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 8:05 ` Jean Delvare
2012-10-12 8:05 ` Jean Delvare
[not found] ` <20121012100521.64cb9adb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-12 8:21 ` Mark Brown
2012-10-12 8:21 ` Mark Brown
[not found] ` <20121012082155.GP11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 9:02 ` Bo Shen
2012-10-12 9:02 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012044042.GI11726@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.