From: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 17:21:57 +0900 [thread overview]
Message-ID: <20121012082155.GP11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121012100521.64cb9adb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Fri, Oct 12, 2012 at 10:05:21AM +0200, Jean Delvare wrote:
> Ah sorry I misread Mark's request. i2c-gpio will turn the platform
> device ID into bus number, it can indeed not be forced through platform
> data. But I don't think any other i2c bus driver allows this either. I
> don't quite see the problem with setting a platform device ID even if
> there's only one instance of the platform device. I have many examples
> of this on my machine:
> Fixed MDIO bus.0
> coretemp.0
> vesafb.0
This is generally bad style; if it's required by APIs we really should
be fixing the APIs to remove this sort of dependency. Aside from the
ugliness it tends to be fragile.
> So please just set the platform device ID to 0 (or whatever i2c adapter
> number you want) and your problem is solved. As you just proposed
> initially, actually :)
Though it *does* need a comprehensible commit message so people can
understand what on earth the change is intended to do.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 17:21:57 +0900 [thread overview]
Message-ID: <20121012082155.GP11726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121012100521.64cb9adb@endymion.delvare>
On Fri, Oct 12, 2012 at 10:05:21AM +0200, Jean Delvare wrote:
> Ah sorry I misread Mark's request. i2c-gpio will turn the platform
> device ID into bus number, it can indeed not be forced through platform
> data. But I don't think any other i2c bus driver allows this either. I
> don't quite see the problem with setting a platform device ID even if
> there's only one instance of the platform device. I have many examples
> of this on my machine:
> Fixed MDIO bus.0
> coretemp.0
> vesafb.0
This is generally bad style; if it's required by APIs we really should
be fixing the APIs to remove this sort of dependency. Aside from the
ugliness it tends to be fragile.
> So please just set the platform device ID to 0 (or whatever i2c adapter
> number you want) and your problem is solved. As you just proposed
> initially, actually :)
Though it *does* need a comprehensible commit message so people can
understand what on earth the change is intended to do.
next prev parent reply other threads:[~2012-10-12 8:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 2:34 [PATCH] i2c: change the id to let the i2c device work Bo Shen
2012-10-12 2:34 ` Bo Shen
[not found] ` <1350009258-10044-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 4:40 ` Mark Brown
2012-10-12 4:40 ` Mark Brown
[not found] ` <20121012044042.GI11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 4:57 ` Bo Shen
2012-10-12 4:57 ` Bo Shen
[not found] ` <5077A33E.4080801-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 5:14 ` Mark Brown
2012-10-12 5:14 ` Mark Brown
[not found] ` <20121012051419.GJ11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:53 ` Mark Brown
2012-10-12 5:53 ` Mark Brown
[not found] ` <20121012055301.GM11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 6:42 ` Bo Shen
2012-10-12 6:42 ` Bo Shen
2012-10-12 7:14 ` Jean Delvare
2012-10-12 7:14 ` Jean Delvare
[not found] ` <20121012091427.0d7b2bed-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-12 7:55 ` Bo Shen
2012-10-12 7:55 ` Bo Shen
[not found] ` <5077CCF4.7070104-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-10-12 8:05 ` Jean Delvare
2012-10-12 8:05 ` Jean Delvare
[not found] ` <20121012100521.64cb9adb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-12 8:21 ` Mark Brown [this message]
2012-10-12 8:21 ` Mark Brown
[not found] ` <20121012082155.GP11726-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2012-10-12 9:02 ` Bo Shen
2012-10-12 9:02 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121012082155.GP11726@opensource.wolfsonmicro.com \
--to=broonie-yzvpicuk2aatku/dhu1wvuem+bqzidxxqq4iyu8u01e@public.gmane.org \
--cc=hskinnemoen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
--cc=voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.