From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: wency@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org,
paulus@samba.org, minchan.kim@gmail.com,
kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH v2 2/5] memory-hotplug: update mce_bad_pages when removing the memory
Date: Thu, 18 Oct 2012 15:20:08 -0700 [thread overview]
Message-ID: <20121018152008.ada8fea5.akpm@linux-foundation.org> (raw)
In-Reply-To: <507ECA43.3070402@linux.vnet.ibm.com>
On Wed, 17 Oct 2012 08:09:55 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:
> Hi Wen,
>
> > +#ifdef CONFIG_MEMORY_FAILURE
> > +static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
> > +{
> > + int i;
> > +
> > + if (!memmap)
> > + return;
>
> I guess free_section_usemap() does the same thing.
What does this observation mean?
> > + for (i = 0; i < PAGES_PER_SECTION; i++) {
> > + if (PageHWPoison(&memmap[i])) {
> > + atomic_long_sub(1, &mce_bad_pages);
> > + ClearPageHWPoison(&memmap[i]);
> > + }
> > + }
> > +}
> > +#endif
> > +
> > void sparse_remove_one_section(struct zone *zone, struct mem_section *ms)
> > {
> > struct page *memmap = NULL;
>
> ..
>
> and keep the #ifdef out of sparse_remove_one_section().
yup.
--- a/mm/sparse.c~memory-hotplug-update-mce_bad_pages-when-removing-the-memory-fix
+++ a/mm/sparse.c
@@ -788,6 +788,10 @@ static void clear_hwpoisoned_pages(struc
}
}
}
+#else
+static inline void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
+{
+}
#endif
void sparse_remove_one_section(struct zone *zone, struct mem_section *ms)
@@ -803,10 +807,7 @@ void sparse_remove_one_section(struct zo
ms->pageblock_flags = NULL;
}
-#ifdef CONFIG_MEMORY_FAILURE
clear_hwpoisoned_pages(memmap, PAGES_PER_SECTION);
-#endif
-
free_section_usemap(memmap, usemap);
}
#endif
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: wency@cn.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, benh@kernel.crashing.org,
paulus@samba.org, minchan.kim@gmail.com,
kosaki.motohiro@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH v2 2/5] memory-hotplug: update mce_bad_pages when removing the memory
Date: Thu, 18 Oct 2012 15:20:08 -0700 [thread overview]
Message-ID: <20121018152008.ada8fea5.akpm@linux-foundation.org> (raw)
In-Reply-To: <507ECA43.3070402@linux.vnet.ibm.com>
On Wed, 17 Oct 2012 08:09:55 -0700
Dave Hansen <dave@linux.vnet.ibm.com> wrote:
> Hi Wen,
>
> > +#ifdef CONFIG_MEMORY_FAILURE
> > +static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
> > +{
> > + int i;
> > +
> > + if (!memmap)
> > + return;
>
> I guess free_section_usemap() does the same thing.
What does this observation mean?
> > + for (i = 0; i < PAGES_PER_SECTION; i++) {
> > + if (PageHWPoison(&memmap[i])) {
> > + atomic_long_sub(1, &mce_bad_pages);
> > + ClearPageHWPoison(&memmap[i]);
> > + }
> > + }
> > +}
> > +#endif
> > +
> > void sparse_remove_one_section(struct zone *zone, struct mem_section *ms)
> > {
> > struct page *memmap = NULL;
>
> ..
>
> and keep the #ifdef out of sparse_remove_one_section().
yup.
--- a/mm/sparse.c~memory-hotplug-update-mce_bad_pages-when-removing-the-memory-fix
+++ a/mm/sparse.c
@@ -788,6 +788,10 @@ static void clear_hwpoisoned_pages(struc
}
}
}
+#else
+static inline void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
+{
+}
#endif
void sparse_remove_one_section(struct zone *zone, struct mem_section *ms)
@@ -803,10 +807,7 @@ void sparse_remove_one_section(struct zo
ms->pageblock_flags = NULL;
}
-#ifdef CONFIG_MEMORY_FAILURE
clear_hwpoisoned_pages(memmap, PAGES_PER_SECTION);
-#endif
-
free_section_usemap(memmap, usemap);
}
#endif
_
next prev parent reply other threads:[~2012-10-18 22:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 12:08 [PATCH v2 0/5] bugfix for memory hotplug wency
2012-10-17 12:08 ` wency
2012-10-17 12:08 ` [PATCH v2 1/5] memory-hotplug: skip HWPoisoned page when offlining pages wency
2012-10-17 12:08 ` wency
2012-10-17 12:08 ` [PATCH v2 2/5] memory-hotplug: update mce_bad_pages when removing the memory wency
2012-10-17 12:08 ` wency
2012-10-17 15:09 ` Dave Hansen
2012-10-17 15:09 ` Dave Hansen
2012-10-18 22:20 ` Andrew Morton [this message]
2012-10-18 22:20 ` Andrew Morton
2012-10-19 13:42 ` Dave Hansen
2012-10-19 13:42 ` Dave Hansen
2012-10-17 12:08 ` [PATCH v2 3/5] memory-hotplug: auto offline page_cgroup when onlining memory block failed wency
2012-10-17 12:08 ` wency
2012-10-17 15:26 ` Wen Congyang
2012-10-17 15:26 ` Wen Congyang
2012-10-17 12:08 ` [PATCH v2 4/5] memory-hotplug: fix NR_FREE_PAGES mismatch wency
2012-10-17 12:08 ` wency
2012-10-17 12:08 ` [PATCH v2 5/5] memory-hotplug: allocate zone's pcp before onlining pages wency
2012-10-17 12:08 ` wency
2012-10-17 12:22 ` [PATCH v2 0/5] bugfix for memory hotplug Ni zhan Chen
2012-10-17 12:22 ` Ni zhan Chen
2012-10-17 15:31 ` Wen Congyang
2012-10-17 15:31 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121018152008.ada8fea5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=dave@linux.vnet.ibm.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=rientjes@google.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.