* [PATCH] Added more compile warning options
@ 2012-10-22 21:00 Steve Dickson
2012-10-22 21:43 ` Jim Rees
0 siblings, 1 reply; 3+ messages in thread
From: Steve Dickson @ 2012-10-22 21:00 UTC (permalink / raw)
To: Linux NFS Mailing List
To ensure the code compiles cleaner, the following warning options
are now set
-Wall -Wextra -Wstrict-prototypes -Wstrict-aliasing
-Wconversion -Wsign-conversion -Wmissing-prototypes
-Wsign-conversion -pedantic -Wmissing-prototypes
Signed-off-by: Steve Dickson <steved@redhat.com>
---
configure.ac | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index a174bf4..197823f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -448,7 +448,11 @@ case $host in
ARCHFLAGS="" ;;
esac
-my_am_cflags="-Wall -Wextra -Wstrict-prototypes $ARCHFLAGS -pipe"
+WFLAGS="-Wall -Wextra -Wstrict-prototypes -Wstrict-aliasing \
+ -Wconversion -Wsign-conversion -Wmissing-prototypes \
+ -Wsign-conversion -pedantic -Wmissing-prototypes"
+
+my_am_cflags="$WFLAGS $ARCHFLAGS -pipe"
AC_SUBST([AM_CFLAGS], ["$my_am_cflags"])
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Added more compile warning options
2012-10-22 21:00 [PATCH] Added more compile warning options Steve Dickson
@ 2012-10-22 21:43 ` Jim Rees
2012-10-23 14:45 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: Jim Rees @ 2012-10-22 21:43 UTC (permalink / raw)
To: Steve Dickson; +Cc: Linux NFS Mailing List
Steve Dickson wrote:
To ensure the code compiles cleaner, the following warning options
are now set
-Wall -Wextra -Wstrict-prototypes -Wstrict-aliasing
-Wconversion -Wsign-conversion -Wmissing-prototypes
-Wsign-conversion -pedantic -Wmissing-prototypes
You only need to specify them once. You've got sign-conversion and
missing-prototypes twice. Also I think -pedantic is going too far.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Added more compile warning options
2012-10-22 21:43 ` Jim Rees
@ 2012-10-23 14:45 ` Steve Dickson
0 siblings, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2012-10-23 14:45 UTC (permalink / raw)
To: Jim Rees; +Cc: Linux NFS Mailing List
Hey Jim,
On 22/10/12 17:43, Jim Rees wrote:
> Steve Dickson wrote:
>
> To ensure the code compiles cleaner, the following warning options
> are now set
> -Wall -Wextra -Wstrict-prototypes -Wstrict-aliasing
> -Wconversion -Wsign-conversion -Wmissing-prototypes
> -Wsign-conversion -pedantic -Wmissing-prototypes
>
> You only need to specify them once. You've got sign-conversion and
> missing-prototypes twice.
Yeah... I noticed that after I posted the patch... This was more
of an RFC patch than anything... I just wanted to get people's opinion...
> Also I think -pedantic is going too far.
Why? The one patch its used for does the following:
-gss_OID g_mechOid = GSS_C_NULL_OID;;
+gss_OID g_mechOid = GSS_C_NULL_OID;
Which seems reasonable... What do you see that I don't?
steved.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-23 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-22 21:00 [PATCH] Added more compile warning options Steve Dickson
2012-10-22 21:43 ` Jim Rees
2012-10-23 14:45 ` Steve Dickson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.