From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/dp: actually nack test request
Date: Tue, 23 Oct 2012 16:41:05 +0200 [thread overview]
Message-ID: <20121023144105.GP24005@phenom.ffwll.local> (raw)
In-Reply-To: <20121023072535.1e1e62fe@jbarnes-desktop>
On Tue, Oct 23, 2012 at 07:25:35AM -0700, Jesse Barnes wrote:
> On Tue, 23 Oct 2012 10:53:07 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > ... like the comment says. No idea whether this has any effect, but
> > > I guess it's better to not lie to the display by acking a test request
> > > and never following through with it.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Ha, if I've learnt anything by now making the code consistent with the
> > comments inside intel_dp.c only leads to pain...
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > But really this needs an ack by Jesse:
> >
> > commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Thu Oct 20 15:09:17 2011 -0700
> >
> > drm/i915: add DP test request handling
> >
> > DPCD 1.1+ adds some automated test infrastructure support. Add support
> > for reading the IRQ source and jumping to a test handling routine if
> > needed. Subsequent patches will handle particular tests; this patch
> > just ACKs any requested tests by default.
> > -Chris
> >
>
> I don't think it matters; the only thing that should be looking at this
> is the DP test equipment. I haven't seen any sinks generate test
> requests yet (but then I don't have many...).
>
> So 'meh' on this patch from me.
Applied, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2012-10-23 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 19:13 [PATCH] drm/i915/dp: actually nack test request Daniel Vetter
2012-10-23 9:53 ` Chris Wilson
2012-10-23 14:25 ` Jesse Barnes
2012-10-23 14:41 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023144105.GP24005@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.