From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915/dp: actually nack test request
Date: Tue, 23 Oct 2012 10:53:07 +0100 [thread overview]
Message-ID: <6c3329$6sard9@orsmga002.jf.intel.com> (raw)
In-Reply-To: <1350760385-16634-1-git-send-email-daniel.vetter@ffwll.ch>
On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... like the comment says. No idea whether this has any effect, but
> I guess it's better to not lie to the display by acking a test request
> and never following through with it.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Ha, if I've learnt anything by now making the code consistent with the
comments inside intel_dp.c only leads to pain...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
But really this needs an ack by Jesse:
commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date: Thu Oct 20 15:09:17 2011 -0700
drm/i915: add DP test request handling
DPCD 1.1+ adds some automated test infrastructure support. Add support
for reading the IRQ source and jumping to a test handling routine if
needed. Subsequent patches will handle particular tests; this patch
just ACKs any requested tests by default.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-10-23 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 19:13 [PATCH] drm/i915/dp: actually nack test request Daniel Vetter
2012-10-23 9:53 ` Chris Wilson [this message]
2012-10-23 14:25 ` Jesse Barnes
2012-10-23 14:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$6sard9@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.