* [PATCH] drm/i915/dp: actually nack test request
@ 2012-10-20 19:13 Daniel Vetter
2012-10-23 9:53 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2012-10-20 19:13 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
... like the comment says. No idea whether this has any effect, but
I guess it's better to not lie to the display by acking a test request
and never following through with it.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index b9b9d08..8228083 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2125,7 +2125,7 @@ static void
intel_dp_handle_test_request(struct intel_dp *intel_dp)
{
/* NAK by default */
- intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, DP_TEST_ACK);
+ intel_dp_aux_native_write_1(intel_dp, DP_TEST_RESPONSE, DP_TEST_NAK);
}
/*
--
1.7.11.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/dp: actually nack test request
2012-10-20 19:13 [PATCH] drm/i915/dp: actually nack test request Daniel Vetter
@ 2012-10-23 9:53 ` Chris Wilson
2012-10-23 14:25 ` Jesse Barnes
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2012-10-23 9:53 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter
On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... like the comment says. No idea whether this has any effect, but
> I guess it's better to not lie to the display by acking a test request
> and never following through with it.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Ha, if I've learnt anything by now making the code consistent with the
comments inside intel_dp.c only leads to pain...
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
But really this needs an ack by Jesse:
commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date: Thu Oct 20 15:09:17 2011 -0700
drm/i915: add DP test request handling
DPCD 1.1+ adds some automated test infrastructure support. Add support
for reading the IRQ source and jumping to a test handling routine if
needed. Subsequent patches will handle particular tests; this patch
just ACKs any requested tests by default.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/dp: actually nack test request
2012-10-23 9:53 ` Chris Wilson
@ 2012-10-23 14:25 ` Jesse Barnes
2012-10-23 14:41 ` Daniel Vetter
0 siblings, 1 reply; 4+ messages in thread
From: Jesse Barnes @ 2012-10-23 14:25 UTC (permalink / raw)
To: Chris Wilson; +Cc: Daniel Vetter, Intel Graphics Development
On Tue, 23 Oct 2012 10:53:07 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > ... like the comment says. No idea whether this has any effect, but
> > I guess it's better to not lie to the display by acking a test request
> > and never following through with it.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Ha, if I've learnt anything by now making the code consistent with the
> comments inside intel_dp.c only leads to pain...
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> But really this needs an ack by Jesse:
>
> commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
> Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Thu Oct 20 15:09:17 2011 -0700
>
> drm/i915: add DP test request handling
>
> DPCD 1.1+ adds some automated test infrastructure support. Add support
> for reading the IRQ source and jumping to a test handling routine if
> needed. Subsequent patches will handle particular tests; this patch
> just ACKs any requested tests by default.
> -Chris
>
I don't think it matters; the only thing that should be looking at this
is the DP test equipment. I haven't seen any sinks generate test
requests yet (but then I don't have many...).
So 'meh' on this patch from me.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/dp: actually nack test request
2012-10-23 14:25 ` Jesse Barnes
@ 2012-10-23 14:41 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2012-10-23 14:41 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Daniel Vetter, Intel Graphics Development
On Tue, Oct 23, 2012 at 07:25:35AM -0700, Jesse Barnes wrote:
> On Tue, 23 Oct 2012 10:53:07 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> > On Sat, 20 Oct 2012 21:13:05 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > > ... like the comment says. No idea whether this has any effect, but
> > > I guess it's better to not lie to the display by acking a test request
> > > and never following through with it.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Ha, if I've learnt anything by now making the code consistent with the
> > comments inside intel_dp.c only leads to pain...
> >
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > But really this needs an ack by Jesse:
> >
> > commit a60f0e38d72a5e24085d6e7e27a4cadc20ae268a
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Thu Oct 20 15:09:17 2011 -0700
> >
> > drm/i915: add DP test request handling
> >
> > DPCD 1.1+ adds some automated test infrastructure support. Add support
> > for reading the IRQ source and jumping to a test handling routine if
> > needed. Subsequent patches will handle particular tests; this patch
> > just ACKs any requested tests by default.
> > -Chris
> >
>
> I don't think it matters; the only thing that should be looking at this
> is the DP test equipment. I haven't seen any sinks generate test
> requests yet (but then I don't have many...).
>
> So 'meh' on this patch from me.
Applied, thanks for the review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-23 14:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-20 19:13 [PATCH] drm/i915/dp: actually nack test request Daniel Vetter
2012-10-23 9:53 ` Chris Wilson
2012-10-23 14:25 ` Jesse Barnes
2012-10-23 14:41 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.