[PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[David Howells]

Provide a comment in the empty uapi/asm/hw_breakpoint.h to make sure that the
patch program doesn't delete it.

However, should some part of asm/hw_breakpoint.h actually be exported here,
or, possibly, should the entire uapi file be removed?  In v3.6, though the
file was marked for export to userspace, it had nothing outside of __KERNEL__.

This needs to be applied on top of the x86 UAPI disintegration patch.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/x86/include/uapi/asm/hw_breakpoint.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/include/uapi/asm/hw_breakpoint.h b/arch/x86/include/uapi/asm/hw_breakpoint.h
index e69de29..91cb766 100644
--- a/arch/x86/include/uapi/asm/hw_breakpoint.h
+++ b/arch/x86/include/uapi/asm/hw_breakpoint.h
@@ -0,0 +1,3 @@
+/*
+ * x86 hardware breakpoint stuff.
+ */

[PATCH 2/2] x86: Provide a comment in uapi/asm/setup.h

[David Howells]

Provide a comment in the empty uapi/asm/setup.h to make sure that the patch
program doesn't delete it.

However, should some part of asm/hw_setup.h actually be exported here, or,
possibly, should the entire uapi file be removed?  In v3.6, though the file
was marked for export to userspace, it had nothing outside of __KERNEL__.

This needs to be applied on top of the x86 UAPI disintegration patch.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/x86/include/uapi/asm/setup.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/x86/include/uapi/asm/setup.h b/arch/x86/include/uapi/asm/setup.h
index e69de29..68cd293 100644
--- a/arch/x86/include/uapi/asm/setup.h
+++ b/arch/x86/include/uapi/asm/setup.h
@@ -0,0 +1,3 @@
+/*
+ * x86 setup stuff.
+ */

Re: [PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[Ingo Molnar]

* David Howells <dhowells@redhat.com> wrote:

> Provide a comment in the empty uapi/asm/hw_breakpoint.h to make sure that the
> patch program doesn't delete it.
> 
> However, should some part of asm/hw_breakpoint.h actually be exported here,
> or, possibly, should the entire uapi file be removed?  In v3.6, though the
> file was marked for export to userspace, it had nothing outside of __KERNEL__.
> 
> This needs to be applied on top of the x86 UAPI disintegration patch.

Just wondering, have the tools/perf/ issues been solved in your 
tree, are the x86 UAPI disintegration changes pullable?

Thanks,

	Ingo

Re: [PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[David Howells]

Ingo Molnar <mingo@kernel.org> wrote:

> Just wondering, have the tools/perf/ issues been solved in your 
> tree, are the x86 UAPI disintegration changes pullable?

Did you have a look at the set of five patches I sent?  I think those should
fix up perf and building tools with O=, but I'm not sure whether we want the
last two.  From commits already made, I'm guessing that at least patch #4
should be made.

Note that the disintegrate-x86 branch does not include any perf fixes.  I can
regenerate that with some or all of them, once I know what they will be.

David

Re: [PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[Ingo Molnar]

* David Howells <dhowells@redhat.com> wrote:

> Ingo Molnar <mingo@kernel.org> wrote:
> 
> > Just wondering, have the tools/perf/ issues been solved in your 
> > tree, are the x86 UAPI disintegration changes pullable?
> 
> Did you have a look at the set of five patches I sent?  I 
> think those should fix up perf and building tools with O=, but 
> I'm not sure whether we want the last two.  From commits 
> already made, I'm guessing that at least patch #4 should be 
> made.
> 
> Note that the disintegrate-x86 branch does not include any 
> perf fixes.  I can regenerate that with some or all of them, 
> once I know what they will be.

Just wanted to inquire about the current status of it, as I'd 
rather not pull anything that introduces breakages and is still 
work in progress. Once it's all sorted out I'll have a look.

Arnaldo, what's your take on David's perf Makefile changes?

Thanks,

	Ingo

Re: [PATCH 1/2] x86: Provide a comment in uapi/asm/hw_breakpoint.h

[David Howells]

Ingo Molnar <mingo@kernel.org> wrote:

> Just wanted to inquire about the current status of it, as I'd 
> rather not pull anything that introduces breakages and is still 
> work in progress. Once it's all sorted out I'll have a look.

Should I pull the x86 disintegration and perf fixes onto a tree derived from
tipbot since there are a lot of perf changes in there?

David