All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] zynq: remove use of CLKDEV_LOOKUP
Date: Wed, 24 Oct 2012 12:05:34 +0000	[thread overview]
Message-ID: <201210241205.34557.arnd@arndb.de> (raw)
In-Reply-To: <20121024003442.GD31625@beefymiracle.amer.corp.natinst.com>

On Wednesday 24 October 2012, Josh Cartwright wrote:
> The Zynq support in mainline does not (yet) make use of any of the
> generic clk or clk lookup functionality.  Remove what is upstream for
> now, until the out-of-tree implementation is in suitable form for
> merging.
> 
> An important side effect of this patch is that it allows the building of
> a Zynq kernel without running into unresolved symbol problems:
> 
>    drivers/built-in.o: In function `amba_get_enable_pclk':
>    clkdev.c:(.text+0x444): undefined reference to `clk_enable'
>    drivers/built-in.o: In function `amba_remove':
>    clkdev.c:(.text+0x488): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `amba_probe':
>    clkdev.c:(.text+0x540): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `amba_device_add':
>    clkdev.c:(.text+0x77c): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `enable_clock':
>    clkdev.c:(.text+0x29738): undefined reference to `clk_enable'
>    drivers/built-in.o: In function `disable_clock':
>    clkdev.c:(.text+0x29778): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `__pm_clk_remove':
>    clkdev.c:(.text+0x297f8): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `pm_clk_suspend':
>    clkdev.c:(.text+0x29bc8): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `pm_clk_resume':
>    clkdev.c:(.text+0x29c28): undefined reference to `clk_enable'
>    make[2]: *** [vmlinux] Error 1
>    make[1]: *** [sub-make] Error 2
>    make: *** [all] Error 2
> 
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
> Cc: John Linn <john.linn@xilinx.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I think I forgot to mention in the previous review round that it would be nice
to just enable CONFIG_COMMON_CLK right away. Not important though.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Josh Cartwright <josh.cartwright@ni.com>
Cc: arm@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	John Linn <john.linn@xilinx.com>,
	Nick Bowler <nbowler@elliptictech.com>
Subject: Re: [PATCH v3 3/5] zynq: remove use of CLKDEV_LOOKUP
Date: Wed, 24 Oct 2012 12:05:34 +0000	[thread overview]
Message-ID: <201210241205.34557.arnd@arndb.de> (raw)
In-Reply-To: <20121024003442.GD31625@beefymiracle.amer.corp.natinst.com>

On Wednesday 24 October 2012, Josh Cartwright wrote:
> The Zynq support in mainline does not (yet) make use of any of the
> generic clk or clk lookup functionality.  Remove what is upstream for
> now, until the out-of-tree implementation is in suitable form for
> merging.
> 
> An important side effect of this patch is that it allows the building of
> a Zynq kernel without running into unresolved symbol problems:
> 
>    drivers/built-in.o: In function `amba_get_enable_pclk':
>    clkdev.c:(.text+0x444): undefined reference to `clk_enable'
>    drivers/built-in.o: In function `amba_remove':
>    clkdev.c:(.text+0x488): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `amba_probe':
>    clkdev.c:(.text+0x540): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `amba_device_add':
>    clkdev.c:(.text+0x77c): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `enable_clock':
>    clkdev.c:(.text+0x29738): undefined reference to `clk_enable'
>    drivers/built-in.o: In function `disable_clock':
>    clkdev.c:(.text+0x29778): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `__pm_clk_remove':
>    clkdev.c:(.text+0x297f8): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `pm_clk_suspend':
>    clkdev.c:(.text+0x29bc8): undefined reference to `clk_disable'
>    drivers/built-in.o: In function `pm_clk_resume':
>    clkdev.c:(.text+0x29c28): undefined reference to `clk_enable'
>    make[2]: *** [vmlinux] Error 1
>    make[1]: *** [sub-make] Error 2
>    make: *** [all] Error 2
> 
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
> Cc: John Linn <john.linn@xilinx.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>

I think I forgot to mention in the previous review round that it would be nice
to just enable CONFIG_COMMON_CLK right away. Not important though.

	Arnd

  reply	other threads:[~2012-10-24 12:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24  0:32 [PATCH v3 0/5] zynq subarch cleanups Josh Cartwright
2012-10-24  0:32 ` Josh Cartwright
2012-10-24  0:33 ` [PATCH v3 1/5] zynq: use GIC device tree bindings Josh Cartwright
2012-10-24  0:33   ` Josh Cartwright
2012-10-24 12:03   ` Arnd Bergmann
2012-10-24 12:03     ` Arnd Bergmann
2012-10-24  0:34 ` [PATCH v3 2/5] zynq: use pl310 " Josh Cartwright
2012-10-24  0:34   ` Josh Cartwright
2012-10-24 12:04   ` Arnd Bergmann
2012-10-24 12:04     ` Arnd Bergmann
2012-10-24  0:34 ` [PATCH v3 3/5] zynq: remove use of CLKDEV_LOOKUP Josh Cartwright
2012-10-24  0:34   ` Josh Cartwright
2012-10-24 12:05   ` Arnd Bergmann [this message]
2012-10-24 12:05     ` Arnd Bergmann
2012-10-24 13:32   ` Nick Bowler
2012-10-24 13:32     ` Nick Bowler
2012-10-24 18:16     ` Josh Cartwright
2012-10-24 18:16       ` Josh Cartwright
2012-10-24  0:35 ` [PATCH v3 4/5] ARM: annotate VMALLOC_END definition with _AC Josh Cartwright
2012-10-24  0:35   ` Josh Cartwright
2012-10-24 12:07   ` Arnd Bergmann
2012-10-24 12:07     ` Arnd Bergmann
2012-10-24  0:35 ` [PATCH v3 5/5] zynq: move static peripheral mappings Josh Cartwright
2012-10-24  0:35   ` Josh Cartwright
2012-10-24 12:08   ` Arnd Bergmann
2012-10-24 12:08     ` Arnd Bergmann
2012-10-24 12:09 ` [PATCH v3 0/5] zynq subarch cleanups Arnd Bergmann
2012-10-24 12:09   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210241205.34557.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.