From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update
Date: Wed, 24 Oct 2012 16:01:39 +0200 [thread overview]
Message-ID: <20121024160139.6dbf5e16@skate> (raw)
In-Reply-To: <1351086561-13569-3-git-send-email-gregory.clement@free-electrons.com>
Hello,
Shouldn't you split into one commit adding the SATA definition in
the .dtsi + doing the defconfig change (the "SoC" level modifications),
and then another commit for the .dts change? I don't really care
personally, it's really up to Jason/Andrew on this.
Another comment below, though.
On Wed, 24 Oct 2012 15:49:21 +0200, Gregory CLEMENT wrote:
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 94b4b9e..3f08233 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -69,6 +69,16 @@
> compatible = "marvell,armada-addr-decoding-controller";
> reg = <0xd0020000 0x258>;
> };
> +
> + sata at d00a0000 {
> + compatible = "marvell,orion-sata";
> + reg = <0xd00a0000 0x2400>;
> + interrupts = <55>;
> + nr-ports = <2>;
> + clocks = <&coreclk 0>;//, <&coreclk 0>;
Alignment problem + remainings of tests or something like that.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
linux-arm-kernel@lists.infradead.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Ben Dooks <ben-linux@fluff.org>,
Ian Molton <ian.molton@codethink.co.uk>,
Nicolas Pitre <nico@fluxnic.net>,
Lior Amsalem <alior@marvell.com>,
Maen Suleiman <maen@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Shadi Ammouri <shadi@marvell.com>,
Eran Ben-Avi <benavi@marvell.com>,
Yehuda Yitschak <yehuday@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Ike Pan <ike.pan@canonical.com>,
Jani Monoses <jani.monoses@canonical.com>,
Chris Van Hoof <vanhoof@canonical.com>,
Dan Frazier <dann.frazier@canonical.com>,
Leif Lindholm <leif.lindholm@arm.com>,
Jon Masters <jcm@redhat.com>, David Marlin <dmarlin@redhat.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update
Date: Wed, 24 Oct 2012 16:01:39 +0200 [thread overview]
Message-ID: <20121024160139.6dbf5e16@skate> (raw)
In-Reply-To: <1351086561-13569-3-git-send-email-gregory.clement@free-electrons.com>
Hello,
Shouldn't you split into one commit adding the SATA definition in
the .dtsi + doing the defconfig change (the "SoC" level modifications),
and then another commit for the .dts change? I don't really care
personally, it's really up to Jason/Andrew on this.
Another comment below, though.
On Wed, 24 Oct 2012 15:49:21 +0200, Gregory CLEMENT wrote:
> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
> index 94b4b9e..3f08233 100644
> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
> @@ -69,6 +69,16 @@
> compatible = "marvell,armada-addr-decoding-controller";
> reg = <0xd0020000 0x258>;
> };
> +
> + sata@d00a0000 {
> + compatible = "marvell,orion-sata";
> + reg = <0xd00a0000 0x2400>;
> + interrupts = <55>;
> + nr-ports = <2>;
> + clocks = <&coreclk 0>;//, <&coreclk 0>;
Alignment problem + remainings of tests or something like that.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-24 14:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:49 [PATCH 0/2] Adding SATA support for Armada 370/XP Gregory CLEMENT
2012-10-24 13:49 ` Gregory CLEMENT
2012-10-24 13:49 ` [PATCH 1/2] arm: mvebu: increase atomic coherent pool size for armada 370/XP Gregory CLEMENT
2012-10-24 13:49 ` Gregory CLEMENT
2012-10-25 5:29 ` Marek Szyprowski
2012-10-25 5:29 ` Marek Szyprowski
2012-10-25 11:27 ` Arnd Bergmann
2012-10-25 11:27 ` Arnd Bergmann
2012-10-25 11:43 ` Thomas Petazzoni
2012-10-25 11:43 ` Thomas Petazzoni
2012-10-25 13:46 ` Arnd Bergmann
2012-10-25 13:46 ` Arnd Bergmann
2012-10-25 14:09 ` Thomas Petazzoni
2012-10-25 14:09 ` Thomas Petazzoni
2012-10-30 7:19 ` Marek Szyprowski
2012-10-24 13:49 ` [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update Gregory CLEMENT
2012-10-24 13:49 ` Gregory CLEMENT
2012-10-24 14:01 ` Thomas Petazzoni [this message]
2012-10-24 14:01 ` Thomas Petazzoni
2012-10-24 14:05 ` Gregory CLEMENT
2012-10-24 14:05 ` Gregory CLEMENT
2012-10-25 13:18 ` Jason Cooper
2012-10-25 13:18 ` Jason Cooper
2012-10-25 13:21 ` Thomas Petazzoni
2012-10-25 13:21 ` Thomas Petazzoni
2012-10-25 13:34 ` Gregory CLEMENT
2012-10-25 13:34 ` Gregory CLEMENT
2012-10-25 13:57 ` Rob Herring
2012-10-25 13:57 ` Rob Herring
2012-10-25 16:00 ` Gregory CLEMENT
2012-10-25 16:00 ` Gregory CLEMENT
2012-10-25 13:35 ` Jason Cooper
2012-10-25 13:35 ` Jason Cooper
2012-10-25 13:53 ` Rob Herring
2012-10-25 13:53 ` Rob Herring
2012-10-25 14:11 ` Gregory CLEMENT
2012-10-25 14:11 ` Gregory CLEMENT
2012-10-25 14:27 ` Rob Herring
2012-10-25 14:27 ` Rob Herring
2012-10-24 14:08 ` Andrew Lunn
2012-10-24 14:08 ` Andrew Lunn
2012-10-24 14:45 ` Gregory CLEMENT
2012-10-24 14:45 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024160139.6dbf5e16@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.