From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org,
James Hogan <james.hogan@imgtec.com>,
Mike Frysinger <vapier@gentoo.org>,
Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
linux@lists.openrisc.net, Guan Xuetao <gxt@mprc.pku.edu.cn>,
uclinux-dist-devel@blackfin.uclinux.org,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 14:07:26 +0000 [thread overview]
Message-ID: <201210251407.27145.arnd@arndb.de> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
On Thursday 25 October 2012, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
> > Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> > cacheflush.h being able to use I/O functions like readl and writel due
> > to circular include dependencies. It doesn't appear as if anything from
> > cacheflush.h is actually used by the generic io.h, so remove the
> > include.
> >
> > I've compile tested a defconfig compilation of blackfin, openrisc (which
> > needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> > definitions), and xtensa.
> >
> > Other architectures which use asm-generic/io.h are score and unicore32,
> > and looking at their io.h I don't see any obvious problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
>
> Who's tree should this go via. I can take it via the openrisc tree, but
> it would be good to get some Ack's that this isn't going to break things
> for the other arch's (in particular score and unicore32, since they are
> untested).
I've put it into the asm-generic tree, now that I have set it up again
for the 3.7 merge window.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Bonn <jonas@southpole.se>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-arch@vger.kernel.org, linux@lists.openrisc.net,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-xtensa@linux-xtensa.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 14:07:26 +0000 [thread overview]
Message-ID: <201210251407.27145.arnd@arndb.de> (raw)
Message-ID: <20121025140726.2euidKY9aIxjdU5KWYtR_UcCijxkkJ5R24AQXckYKX8@z> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
On Thursday 25 October 2012, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
> > Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> > cacheflush.h being able to use I/O functions like readl and writel due
> > to circular include dependencies. It doesn't appear as if anything from
> > cacheflush.h is actually used by the generic io.h, so remove the
> > include.
> >
> > I've compile tested a defconfig compilation of blackfin, openrisc (which
> > needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> > definitions), and xtensa.
> >
> > Other architectures which use asm-generic/io.h are score and unicore32,
> > and looking at their io.h I don't see any obvious problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
>
> Who's tree should this go via. I can take it via the openrisc tree, but
> it would be good to get some Ack's that this isn't going to break things
> for the other arch's (in particular score and unicore32, since they are
> untested).
I've put it into the asm-generic tree, now that I have set it up again
for the 3.7 merge window.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Bonn <jonas@southpole.se>
Cc: James Hogan <james.hogan@imgtec.com>,
linux-arch@vger.kernel.org, linux@openrisc.net,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-xtensa@linux-xtensa.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 14:07:26 +0000 [thread overview]
Message-ID: <201210251407.27145.arnd@arndb.de> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
On Thursday 25 October 2012, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
> > Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
> > cacheflush.h being able to use I/O functions like readl and writel due
> > to circular include dependencies. It doesn't appear as if anything from
> > cacheflush.h is actually used by the generic io.h, so remove the
> > include.
> >
> > I've compile tested a defconfig compilation of blackfin, openrisc (which
> > needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_*
> > definitions), and xtensa.
> >
> > Other architectures which use asm-generic/io.h are score and unicore32,
> > and looking at their io.h I don't see any obvious problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
>
> Who's tree should this go via. I can take it via the openrisc tree, but
> it would be good to get some Ack's that this isn't going to break things
> for the other arch's (in particular score and unicore32, since they are
> untested).
I've put it into the asm-generic tree, now that I have set it up again
for the 3.7 merge window.
Arnd
next prev parent reply other threads:[~2012-10-25 14:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 9:21 [PATCH] asm-generic/io.h: remove asm/cacheflush.h include James Hogan
2012-10-23 9:21 ` James Hogan
2012-10-23 9:21 ` James Hogan
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 14:07 ` Arnd Bergmann [this message]
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` James Hogan
2012-10-25 14:07 ` James Hogan
2012-10-25 14:07 ` James Hogan
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 21:19 ` Max Filippov
2012-10-25 21:19 ` Max Filippov
2012-10-29 1:28 ` guanxuetao
2012-10-29 1:28 ` guanxuetao
2012-10-29 1:28 ` guanxuetao
2012-10-29 9:28 ` James Hogan
2012-10-29 9:28 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210251407.27145.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=gxt@mprc.pku.edu.cn \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@lists.openrisc.net \
--cc=liqin.chen@sunplusct.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.