From: James Hogan <james.hogan@imgtec.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Mike Frysinger <vapier@gentoo.org>, Arnd Bergmann <arnd@arndb.de>,
Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
linux@lists.openrisc.net,
uclinux-dist-devel@blackfin.uclinux.org,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 15:07:27 +0100 [thread overview]
Message-ID: <5089479F.6070608@imgtec.com> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 25/10/12 14:40, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
>> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
>> cacheflush.h being able to use I/O functions like readl and
>> writel due to circular include dependencies. It doesn't appear as
>> if anything from cacheflush.h is actually used by the generic
>> io.h, so remove the include.
>>
>> I've compile tested a defconfig compilation of blackfin, openrisc
>> (which needed <asm/pgtable.h> including from it's <asm/io.h> to
>> get the PAGE_* definitions), and xtensa.
>>
>> Other architectures which use asm-generic/io.h are score and
>> unicore32, and looking at their io.h I don't see any obvious
>> problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
Thanks Jonas
> Who's tree should this go via. I can take it via the openrisc
> tree, but it would be good to get some Ack's that this isn't going
> to break things for the other arch's (in particular score and
> unicore32, since they are untested).
Yeh I'd like some acks from score and unicore32 if possible, since I
didn't notice I needed the openrisc bit until I tried compiling it.
Cheers
James
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJQiUefAAoJEKHZs+irPybfly0P/3RZDS5sxivx513plCPNMucV
rXmZnEGh87Iw9c8htjV0WFH5dAtmUQ88wkExGEWPdK57AYhMLwKN+soycq3XGS6E
156EFDpp602K9bwZ5bTodJco2FalaQrUh+GQqWOBGhi0NPwnt0pwEpUC/F5Vn71d
rekQ9er/fKWhF74ONKh+/K3fSTHl6/S2Krt3izsPH9a+7aYpWNVNvfrhyS43A+AR
xa3tE0Q5sHvaRTYp+42p/7CHwOzAerXs3Cvp7QYrwErV8cB6IvkVh+b7RYkawYAq
czVIjbi45ouJlRek7EO3ZlcDFtiuoQZxzdVDNUwMuKWv7e9ASQ1StTHbh67DDlGK
cZsFMnuO0ddkdzs8ya/HWdA9+hZmrigPmst4rKUvM4idJ/N7zpO4G74fCwVDLng1
GIUrPrZTbcgpZyGepJfH9jGmwRJBcS8nYiep3quz21p3oGafeIVdv7WsPcHC0/HA
BOW2NcGDihtiJjooVWAiRhEPO4jxBCpY187YuoKJXCFdm5CfJ7ZdCIjeEt/cWVQs
yNfoGeVtHgRxKEJFsKAIto92iT18JY0qZWJL7WAqFDD4qB13RmJbmUOE4LCChFKK
Jui/Fi46j6uWdau6mujMlYKx3RMHjB/Lw09WRL78gEB6JaxpzVh4iShu4BI8G50P
Ye3bZ/gyfOLBRBky14FJ
=xH4e
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux@lists.openrisc.net,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-xtensa@linux-xtensa.org, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
Mike Frysinger <vapier@gentoo.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 15:07:27 +0100 [thread overview]
Message-ID: <5089479F.6070608@imgtec.com> (raw)
Message-ID: <20121025140727.AuwTQGrSeZi99Y0CiCenPlyTNI_mxIF1ytP14OEeO9o@z> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 25/10/12 14:40, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
>> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
>> cacheflush.h being able to use I/O functions like readl and
>> writel due to circular include dependencies. It doesn't appear as
>> if anything from cacheflush.h is actually used by the generic
>> io.h, so remove the include.
>>
>> I've compile tested a defconfig compilation of blackfin, openrisc
>> (which needed <asm/pgtable.h> including from it's <asm/io.h> to
>> get the PAGE_* definitions), and xtensa.
>>
>> Other architectures which use asm-generic/io.h are score and
>> unicore32, and looking at their io.h I don't see any obvious
>> problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
Thanks Jonas
> Who's tree should this go via. I can take it via the openrisc
> tree, but it would be good to get some Ack's that this isn't going
> to break things for the other arch's (in particular score and
> unicore32, since they are untested).
Yeh I'd like some acks from score and unicore32 if possible, since I
didn't notice I needed the openrisc bit until I tried compiling it.
Cheers
James
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJQiUefAAoJEKHZs+irPybfly0P/3RZDS5sxivx513plCPNMucV
rXmZnEGh87Iw9c8htjV0WFH5dAtmUQ88wkExGEWPdK57AYhMLwKN+soycq3XGS6E
156EFDpp602K9bwZ5bTodJco2FalaQrUh+GQqWOBGhi0NPwnt0pwEpUC/F5Vn71d
rekQ9er/fKWhF74ONKh+/K3fSTHl6/S2Krt3izsPH9a+7aYpWNVNvfrhyS43A+AR
xa3tE0Q5sHvaRTYp+42p/7CHwOzAerXs3Cvp7QYrwErV8cB6IvkVh+b7RYkawYAq
czVIjbi45ouJlRek7EO3ZlcDFtiuoQZxzdVDNUwMuKWv7e9ASQ1StTHbh67DDlGK
cZsFMnuO0ddkdzs8ya/HWdA9+hZmrigPmst4rKUvM4idJ/N7zpO4G74fCwVDLng1
GIUrPrZTbcgpZyGepJfH9jGmwRJBcS8nYiep3quz21p3oGafeIVdv7WsPcHC0/HA
BOW2NcGDihtiJjooVWAiRhEPO4jxBCpY187YuoKJXCFdm5CfJ7ZdCIjeEt/cWVQs
yNfoGeVtHgRxKEJFsKAIto92iT18JY0qZWJL7WAqFDD4qB13RmJbmUOE4LCChFKK
Jui/Fi46j6uWdau6mujMlYKx3RMHjB/Lw09WRL78gEB6JaxpzVh4iShu4BI8G50P
Ye3bZ/gyfOLBRBky14FJ
=xH4e
-----END PGP SIGNATURE-----
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Jonas Bonn <jonas@southpole.se>
Cc: Arnd Bergmann <arnd@arndb.de>, <linux-arch@vger.kernel.org>,
<linux@openrisc.net>, <linux-kernel@vger.kernel.org>,
<uclinux-dist-devel@blackfin.uclinux.org>,
<linux-xtensa@linux-xtensa.org>, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
"Mike Frysinger" <vapier@gentoo.org>,
Chen Liqin <liqin.chen@sunplusct.com>,
Lennox Wu <lennox.wu@gmail.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] asm-generic/io.h: remove asm/cacheflush.h include
Date: Thu, 25 Oct 2012 15:07:27 +0100 [thread overview]
Message-ID: <5089479F.6070608@imgtec.com> (raw)
In-Reply-To: <1351172416.6232.70.camel@jerome.southpole.se>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 25/10/12 14:40, Jonas Bonn wrote:
> On Tue, 2012-10-23 at 10:21 +0100, James Hogan wrote:
>> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents
>> cacheflush.h being able to use I/O functions like readl and
>> writel due to circular include dependencies. It doesn't appear as
>> if anything from cacheflush.h is actually used by the generic
>> io.h, so remove the include.
>>
>> I've compile tested a defconfig compilation of blackfin, openrisc
>> (which needed <asm/pgtable.h> including from it's <asm/io.h> to
>> get the PAGE_* definitions), and xtensa.
>>
>> Other architectures which use asm-generic/io.h are score and
>> unicore32, and looking at their io.h I don't see any obvious
>> problems.
>
> Acked-by: Jonas Bonn <jonas@southpole.se> for OpenRISC
Thanks Jonas
> Who's tree should this go via. I can take it via the openrisc
> tree, but it would be good to get some Ack's that this isn't going
> to break things for the other arch's (in particular score and
> unicore32, since they are untested).
Yeh I'd like some acks from score and unicore32 if possible, since I
didn't notice I needed the openrisc bit until I tried compiling it.
Cheers
James
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBAgAGBQJQiUefAAoJEKHZs+irPybfly0P/3RZDS5sxivx513plCPNMucV
rXmZnEGh87Iw9c8htjV0WFH5dAtmUQ88wkExGEWPdK57AYhMLwKN+soycq3XGS6E
156EFDpp602K9bwZ5bTodJco2FalaQrUh+GQqWOBGhi0NPwnt0pwEpUC/F5Vn71d
rekQ9er/fKWhF74ONKh+/K3fSTHl6/S2Krt3izsPH9a+7aYpWNVNvfrhyS43A+AR
xa3tE0Q5sHvaRTYp+42p/7CHwOzAerXs3Cvp7QYrwErV8cB6IvkVh+b7RYkawYAq
czVIjbi45ouJlRek7EO3ZlcDFtiuoQZxzdVDNUwMuKWv7e9ASQ1StTHbh67DDlGK
cZsFMnuO0ddkdzs8ya/HWdA9+hZmrigPmst4rKUvM4idJ/N7zpO4G74fCwVDLng1
GIUrPrZTbcgpZyGepJfH9jGmwRJBcS8nYiep3quz21p3oGafeIVdv7WsPcHC0/HA
BOW2NcGDihtiJjooVWAiRhEPO4jxBCpY187YuoKJXCFdm5CfJ7ZdCIjeEt/cWVQs
yNfoGeVtHgRxKEJFsKAIto92iT18JY0qZWJL7WAqFDD4qB13RmJbmUOE4LCChFKK
Jui/Fi46j6uWdau6mujMlYKx3RMHjB/Lw09WRL78gEB6JaxpzVh4iShu4BI8G50P
Ye3bZ/gyfOLBRBky14FJ
=xH4e
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-10-25 14:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 9:21 [PATCH] asm-generic/io.h: remove asm/cacheflush.h include James Hogan
2012-10-23 9:21 ` James Hogan
2012-10-23 9:21 ` James Hogan
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 13:40 ` Jonas Bonn
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` Arnd Bergmann
2012-10-25 14:07 ` James Hogan [this message]
2012-10-25 14:07 ` James Hogan
2012-10-25 14:07 ` James Hogan
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 14:10 ` Arnd Bergmann
2012-10-25 21:19 ` Max Filippov
2012-10-25 21:19 ` Max Filippov
2012-10-29 1:28 ` guanxuetao
2012-10-29 1:28 ` guanxuetao
2012-10-29 1:28 ` guanxuetao
2012-10-29 9:28 ` James Hogan
2012-10-29 9:28 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089479F.6070608@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=gxt@mprc.pku.edu.cn \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=lennox.wu@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@lists.openrisc.net \
--cc=liqin.chen@sunplusct.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.