From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message
Date: Thu, 25 Oct 2012 15:12:37 -0700 [thread overview]
Message-ID: <20121025221236.GE11928@atomide.com> (raw)
In-Reply-To: <20121025175607.GA21937@kahuna>
* Nishanth Menon <nm@ti.com> [121025 10:57]:
> On 10:35-20121025, Kevin Hilman wrote:
> > From: Kevin Hilman <khilman@ti.com>
> >
> > Add missing newline to warning message to avoid annoying
> > wrapping problems during kernel boot like this one:
> >
> > omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0).
> > omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0).Power Management for TI OMAP4.
> >
> > Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > ---
> > arch/arm/mach-omap2/vc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> > index 880249b..75878c3 100644
> > --- a/arch/arm/mach-omap2/vc.c
> > +++ b/arch/arm/mach-omap2/vc.c
> > @@ -264,7 +264,7 @@ static void __init omap_vc_i2c_init(struct voltagedomain *voltdm)
> >
> > if (initialized) {
> > if (voltdm->pmic->i2c_high_speed != i2c_high_speed)
> > - pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).",
> > + pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).\n",
> > __func__, voltdm->name, i2c_high_speed);
> > return;
> > }
> Acked-by: Nishanth Menon <nm@ti.com>
Thanks I'll apply this into omap-for-v3.7-rc2/fixes-part2-take2.
> while we are at it, could we clean up the pr_warning usage back to
> pr_warn as well?
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 880249b..2d66f8c 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm,
> loop_cnt++;
>
> if (retries_cnt > 10) {
> - pr_warning("%s: Retry count exceeded\n", __func__);
> + pr_warn("%s: Retry count exceeded\n", __func__);
> return -ETIMEDOUT;
> }
>
Looks like that's in the separate patch you posted for v3.8 that Kevin
is taking.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message
Date: Thu, 25 Oct 2012 15:12:37 -0700 [thread overview]
Message-ID: <20121025221236.GE11928@atomide.com> (raw)
In-Reply-To: <20121025175607.GA21937@kahuna>
* Nishanth Menon <nm@ti.com> [121025 10:57]:
> On 10:35-20121025, Kevin Hilman wrote:
> > From: Kevin Hilman <khilman@ti.com>
> >
> > Add missing newline to warning message to avoid annoying
> > wrapping problems during kernel boot like this one:
> >
> > omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0).
> > omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0).Power Management for TI OMAP4.
> >
> > Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kevin Hilman <khilman@ti.com>
> > ---
> > arch/arm/mach-omap2/vc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> > index 880249b..75878c3 100644
> > --- a/arch/arm/mach-omap2/vc.c
> > +++ b/arch/arm/mach-omap2/vc.c
> > @@ -264,7 +264,7 @@ static void __init omap_vc_i2c_init(struct voltagedomain *voltdm)
> >
> > if (initialized) {
> > if (voltdm->pmic->i2c_high_speed != i2c_high_speed)
> > - pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).",
> > + pr_warn("%s: I2C config for vdd_%s does not match other channels (%u).\n",
> > __func__, voltdm->name, i2c_high_speed);
> > return;
> > }
> Acked-by: Nishanth Menon <nm@ti.com>
Thanks I'll apply this into omap-for-v3.7-rc2/fixes-part2-take2.
> while we are at it, could we clean up the pr_warning usage back to
> pr_warn as well?
> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> index 880249b..2d66f8c 100644
> --- a/arch/arm/mach-omap2/vc.c
> +++ b/arch/arm/mach-omap2/vc.c
> @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm,
> loop_cnt++;
>
> if (retries_cnt > 10) {
> - pr_warning("%s: Retry count exceeded\n", __func__);
> + pr_warn("%s: Retry count exceeded\n", __func__);
> return -ETIMEDOUT;
> }
>
Looks like that's in the separate patch you posted for v3.8 that Kevin
is taking.
Regards,
Tony
next prev parent reply other threads:[~2012-10-25 22:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 17:35 [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message Kevin Hilman
2012-10-25 17:35 ` Kevin Hilman
2012-10-25 17:56 ` Nishanth Menon
2012-10-25 17:56 ` Nishanth Menon
2012-10-25 22:12 ` Tony Lindgren [this message]
2012-10-25 22:12 ` Tony Lindgren
2012-10-25 22:27 ` Nishanth Menon
2012-10-25 22:27 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025221236.GE11928@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.