From: Nishanth Menon <nm@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message
Date: Thu, 25 Oct 2012 17:27:34 -0500 [thread overview]
Message-ID: <20121025222733.GA19767@kahuna> (raw)
In-Reply-To: <20121025221236.GE11928@atomide.com>
On 15:12-20121025, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [121025 10:57]:
> > On 10:35-20121025, Kevin Hilman wrote:
> > > From: Kevin Hilman <khilman@ti.com>
[..]
> > while we are at it, could we clean up the pr_warning usage back to
> > pr_warn as well?
> > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> > index 880249b..2d66f8c 100644
> > --- a/arch/arm/mach-omap2/vc.c
> > +++ b/arch/arm/mach-omap2/vc.c
> > @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm,
> > loop_cnt++;
> >
> > if (retries_cnt > 10) {
> > - pr_warning("%s: Retry count exceeded\n", __func__);
> > + pr_warn("%s: Retry count exceeded\n", __func__);
> > return -ETIMEDOUT;
> > }
> >
>
> Looks like that's in the separate patch you posted for v3.8 that Kevin
> is taking.
Nope. if you indicated [1], then I got inspired by Kevin's cleanup and cleaned
up vp.c -> Kevin cleaned up vc.c :)
If the additional cleanup I pointed above in this thread is interesting, it
could be clubbed with the current patch itself
[1] https://patchwork.kernel.org/patch/1646661/
--
Regards,
Nishanth Menon
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message
Date: Thu, 25 Oct 2012 17:27:34 -0500 [thread overview]
Message-ID: <20121025222733.GA19767@kahuna> (raw)
In-Reply-To: <20121025221236.GE11928@atomide.com>
On 15:12-20121025, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [121025 10:57]:
> > On 10:35-20121025, Kevin Hilman wrote:
> > > From: Kevin Hilman <khilman@ti.com>
[..]
> > while we are at it, could we clean up the pr_warning usage back to
> > pr_warn as well?
> > diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
> > index 880249b..2d66f8c 100644
> > --- a/arch/arm/mach-omap2/vc.c
> > +++ b/arch/arm/mach-omap2/vc.c
> > @@ -186,7 +186,7 @@ int omap_vc_bypass_scale(struct voltagedomain *voltdm,
> > loop_cnt++;
> >
> > if (retries_cnt > 10) {
> > - pr_warning("%s: Retry count exceeded\n", __func__);
> > + pr_warn("%s: Retry count exceeded\n", __func__);
> > return -ETIMEDOUT;
> > }
> >
>
> Looks like that's in the separate patch you posted for v3.8 that Kevin
> is taking.
Nope. if you indicated [1], then I got inspired by Kevin's cleanup and cleaned
up vp.c -> Kevin cleaned up vc.c :)
If the additional cleanup I pointed above in this thread is interesting, it
could be clubbed with the current patch itself
[1] https://patchwork.kernel.org/patch/1646661/
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2012-10-25 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 17:35 [PATCH] ARM: OMAP2+: PM: add missing newline to VC warning message Kevin Hilman
2012-10-25 17:35 ` Kevin Hilman
2012-10-25 17:56 ` Nishanth Menon
2012-10-25 17:56 ` Nishanth Menon
2012-10-25 22:12 ` Tony Lindgren
2012-10-25 22:12 ` Tony Lindgren
2012-10-25 22:27 ` Nishanth Menon [this message]
2012-10-25 22:27 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025222733.GA19767@kahuna \
--to=nm@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.