From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, mhocko@suse.cz, peterz@infradead.org,
akpm@linux-foundation.org, Chris Metcalf <cmetcalf@tilera.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault.
Date: Fri, 26 Oct 2012 10:44:35 +0300 [thread overview]
Message-ID: <20121026074435.GA871@shutemov.name> (raw)
In-Reply-To: <1351183471-14710-1-git-send-email-will.deacon@arm.com>
On Thu, Oct 25, 2012 at 05:44:31PM +0100, Will Deacon wrote:
> On x86 memory accesses to pages without the ACCESSED flag set result in the
> ACCESSED flag being set automatically. With the ARM architecture a page access
> fault is raised instead (and it will continue to be raised until the ACCESSED
> flag is set for the appropriate PTE/PMD).
>
> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
> be called for a write fault.
>
> This patch ensures that faults on transparent hugepages which do not result
> in a CoW update the access flags for the faulting pmd.
>
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Ok chaps, I rebased this thing onto today's next (which basically
> necessitated a rewrite) so I've reluctantly dropped my acks and kindly
> ask if you could eyeball the new code, especially where the locking is
> concerned. In the numa code (do_huge_pmd_prot_none), Peter checks again
> that the page is not splitting, but I can't see why that is required.
In handle_mm_fault() we check if the pmd is under splitting without
page_table_lock. It's kind of speculative cheap check. We need to re-check
if the PMD is really not under splitting after taking page_table_lock.
See section "Locking in hugepage aware code" in Documentation/vm/transhuge.txt
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, mhocko@suse.cz, peterz@infradead.org,
akpm@linux-foundation.org, Chris Metcalf <cmetcalf@tilera.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault.
Date: Fri, 26 Oct 2012 10:44:35 +0300 [thread overview]
Message-ID: <20121026074435.GA871@shutemov.name> (raw)
Message-ID: <20121026074435.Ti5fuba6JWTu6XvIRyopecOaQojZtrtIoxDaoN5T3RU@z> (raw)
In-Reply-To: <1351183471-14710-1-git-send-email-will.deacon@arm.com>
On Thu, Oct 25, 2012 at 05:44:31PM +0100, Will Deacon wrote:
> On x86 memory accesses to pages without the ACCESSED flag set result in the
> ACCESSED flag being set automatically. With the ARM architecture a page access
> fault is raised instead (and it will continue to be raised until the ACCESSED
> flag is set for the appropriate PTE/PMD).
>
> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
> be called for a write fault.
>
> This patch ensures that faults on transparent hugepages which do not result
> in a CoW update the access flags for the faulting pmd.
>
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>
> Ok chaps, I rebased this thing onto today's next (which basically
> necessitated a rewrite) so I've reluctantly dropped my acks and kindly
> ask if you could eyeball the new code, especially where the locking is
> concerned. In the numa code (do_huge_pmd_prot_none), Peter checks again
> that the page is not splitting, but I can't see why that is required.
In handle_mm_fault() we check if the pmd is under splitting without
page_table_lock. It's kind of speculative cheap check. We need to re-check
if the PMD is really not under splitting after taking page_table_lock.
See section "Locking in hugepage aware code" in Documentation/vm/transhuge.txt
--
Kirill A. Shutemov
next prev parent reply other threads:[~2012-10-26 7:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 16:44 [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-25 16:44 ` Will Deacon
2012-10-25 19:51 ` Johannes Weiner
2012-10-25 19:51 ` Johannes Weiner
2012-10-26 3:07 ` Ni zhan Chen
2012-10-26 3:07 ` Ni zhan Chen
2012-10-26 6:19 ` Ni zhan Chen
2012-10-26 6:19 ` Ni zhan Chen
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:49 ` Ni zhan Chen
2012-10-26 9:49 ` Ni zhan Chen
2012-10-26 7:44 ` Kirill A. Shutemov [this message]
2012-10-26 7:44 ` Kirill A. Shutemov
2012-10-26 9:07 ` Will Deacon
2012-10-26 9:07 ` Will Deacon
2012-10-26 10:15 ` Kirill A. Shutemov
2012-10-26 10:15 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026074435.GA871@shutemov.name \
--to=kirill@shutemov.name \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.