From: Ni zhan Chen <nizhan.chen@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Will Deacon <will.deacon@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, mhocko@suse.cz, peterz@infradead.org,
akpm@linux-foundation.org, Chris Metcalf <cmetcalf@tilera.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault.
Date: Fri, 26 Oct 2012 11:07:58 +0800 [thread overview]
Message-ID: <5089FE8E.4030603@gmail.com> (raw)
In-Reply-To: <20121025195110.GA4771@cmpxchg.org>
On 10/26/2012 03:51 AM, Johannes Weiner wrote:
> On Thu, Oct 25, 2012 at 05:44:31PM +0100, Will Deacon wrote:
>> On x86 memory accesses to pages without the ACCESSED flag set result in the
>> ACCESSED flag being set automatically. With the ARM architecture a page access
>> fault is raised instead (and it will continue to be raised until the ACCESSED
>> flag is set for the appropriate PTE/PMD).
>>
>> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
>> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
>> be called for a write fault.
>>
>> This patch ensures that faults on transparent hugepages which do not result
>> in a CoW update the access flags for the faulting pmd.
>>
>> Cc: Chris Metcalf <cmetcalf@tilera.com>
>> Cc: Kirill A. Shutemov <kirill@shutemov.name>
>> Cc: Andrea Arcangeli <aarcange@redhat.com>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
>> Ok chaps, I rebased this thing onto today's next (which basically
>> necessitated a rewrite) so I've reluctantly dropped my acks and kindly
>> ask if you could eyeball the new code, especially where the locking is
>> concerned. In the numa code (do_huge_pmd_prot_none), Peter checks again
>> that the page is not splitting, but I can't see why that is required.
> I don't either. If the thing was splitting when the fault happened,
> that path is not taken. And the locked pmd_same() check should rule
> out splitting setting in after testing pmd_trans_huge_splitting().
Why I can't find function pmd_trans_huge_splitting() you mentioned in
latest mainline codes and linux-next?
>
> Peter?
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ni zhan Chen <nizhan.chen@gmail.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Will Deacon <will.deacon@arm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, mhocko@suse.cz, peterz@infradead.org,
akpm@linux-foundation.org, Chris Metcalf <cmetcalf@tilera.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault.
Date: Fri, 26 Oct 2012 11:07:58 +0800 [thread overview]
Message-ID: <5089FE8E.4030603@gmail.com> (raw)
Message-ID: <20121026030758.ZUIRuZZ9FuB1l0z_8TVBDynrLv8Chzdni1eH9fOwexY@z> (raw)
In-Reply-To: <20121025195110.GA4771@cmpxchg.org>
On 10/26/2012 03:51 AM, Johannes Weiner wrote:
> On Thu, Oct 25, 2012 at 05:44:31PM +0100, Will Deacon wrote:
>> On x86 memory accesses to pages without the ACCESSED flag set result in the
>> ACCESSED flag being set automatically. With the ARM architecture a page access
>> fault is raised instead (and it will continue to be raised until the ACCESSED
>> flag is set for the appropriate PTE/PMD).
>>
>> For normal memory pages, handle_pte_fault will call pte_mkyoung (effectively
>> setting the ACCESSED flag). For transparent huge pages, pmd_mkyoung will only
>> be called for a write fault.
>>
>> This patch ensures that faults on transparent hugepages which do not result
>> in a CoW update the access flags for the faulting pmd.
>>
>> Cc: Chris Metcalf <cmetcalf@tilera.com>
>> Cc: Kirill A. Shutemov <kirill@shutemov.name>
>> Cc: Andrea Arcangeli <aarcange@redhat.com>
>> Signed-off-by: Will Deacon <will.deacon@arm.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
>> Ok chaps, I rebased this thing onto today's next (which basically
>> necessitated a rewrite) so I've reluctantly dropped my acks and kindly
>> ask if you could eyeball the new code, especially where the locking is
>> concerned. In the numa code (do_huge_pmd_prot_none), Peter checks again
>> that the page is not splitting, but I can't see why that is required.
> I don't either. If the thing was splitting when the fault happened,
> that path is not taken. And the locked pmd_same() check should rule
> out splitting setting in after testing pmd_trans_huge_splitting().
Why I can't find function pmd_trans_huge_splitting() you mentioned in
latest mainline codes and linux-next?
>
> Peter?
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
next prev parent reply other threads:[~2012-10-26 3:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 16:44 [PATCH v3] mm: thp: Set the accessed flag for old pages on access fault Will Deacon
2012-10-25 16:44 ` Will Deacon
2012-10-25 19:51 ` Johannes Weiner
2012-10-25 19:51 ` Johannes Weiner
2012-10-26 3:07 ` Ni zhan Chen [this message]
2012-10-26 3:07 ` Ni zhan Chen
2012-10-26 6:19 ` Ni zhan Chen
2012-10-26 6:19 ` Ni zhan Chen
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:34 ` Will Deacon
2012-10-26 9:49 ` Ni zhan Chen
2012-10-26 9:49 ` Ni zhan Chen
2012-10-26 7:44 ` Kirill A. Shutemov
2012-10-26 7:44 ` Kirill A. Shutemov
2012-10-26 9:07 ` Will Deacon
2012-10-26 9:07 ` Will Deacon
2012-10-26 10:15 ` Kirill A. Shutemov
2012-10-26 10:15 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5089FE8E.4030603@gmail.com \
--to=nizhan.chen@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@tilera.com \
--cc=hannes@cmpxchg.org \
--cc=kirill@shutemov.name \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.