From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
balbi@ti.com
Subject: Re: [PATCH] ARM: OMAP1: usb: fix sparse warnings
Date: Fri, 26 Oct 2012 14:28:41 -0700 [thread overview]
Message-ID: <20121026212841.GW11908@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210262125410.11258@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121026 14:27]:
> On Fri, 26 Oct 2012, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul@pwsan.com> [121026 13:54]:
> > >
> > > Resolve the following sparse warnings:
> > >
> > > arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?
> > >
> > > by declaring those functions as static. Also remove the unneeded
> > > prototypes and related code from the plat/usb.h header file.
> > >
> > > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Felipe Balbi <balbi@ti.com>
> > > ---
> > >
> > > Tony, care to take this one?
> >
> > Let's apply just the usb.c changes on omap-for-v3.8/cleanup-headers
> > as plat/usb.h is now gone?
>
> OK no problem, thought you might want it for the -rc series...
Looks like it's not urgent for the -rc series, so let's not
introduce more self-inflicted merge conflicts. If that's OK
with you, I can apply it to omap-for-v3.8/cleanup-headers
without the header changes.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP1: usb: fix sparse warnings
Date: Fri, 26 Oct 2012 14:28:41 -0700 [thread overview]
Message-ID: <20121026212841.GW11908@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210262125410.11258@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121026 14:27]:
> On Fri, 26 Oct 2012, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul@pwsan.com> [121026 13:54]:
> > >
> > > Resolve the following sparse warnings:
> > >
> > > arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
> > > arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?
> > >
> > > by declaring those functions as static. Also remove the unneeded
> > > prototypes and related code from the plat/usb.h header file.
> > >
> > > Signed-off-by: Paul Walmsley <paul@pwsan.com>
> > > Cc: Tony Lindgren <tony@atomide.com>
> > > Cc: Felipe Balbi <balbi@ti.com>
> > > ---
> > >
> > > Tony, care to take this one?
> >
> > Let's apply just the usb.c changes on omap-for-v3.8/cleanup-headers
> > as plat/usb.h is now gone?
>
> OK no problem, thought you might want it for the -rc series...
Looks like it's not urgent for the -rc series, so let's not
introduce more self-inflicted merge conflicts. If that's OK
with you, I can apply it to omap-for-v3.8/cleanup-headers
without the header changes.
Regards,
Tony
next prev parent reply other threads:[~2012-10-26 21:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 20:52 [PATCH] ARM: OMAP1: usb: fix sparse warnings Paul Walmsley
2012-10-26 20:52 ` Paul Walmsley
2012-10-26 21:20 ` Tony Lindgren
2012-10-26 21:20 ` Tony Lindgren
2012-10-26 21:25 ` Paul Walmsley
2012-10-26 21:25 ` Paul Walmsley
2012-10-26 21:28 ` Tony Lindgren [this message]
2012-10-26 21:28 ` Tony Lindgren
2012-10-26 21:29 ` Paul Walmsley
2012-10-26 21:29 ` Paul Walmsley
2012-10-26 21:28 ` [PATCH v2] " Paul Walmsley
2012-10-26 21:28 ` Paul Walmsley
2012-10-26 21:33 ` Tony Lindgren
2012-10-26 21:33 ` Tony Lindgren
2012-10-29 16:21 ` Felipe Balbi
2012-10-29 16:21 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026212841.GW11908@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.