From: Felipe Balbi <balbi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
balbi@ti.com
Subject: Re: [PATCH v2] ARM: OMAP1: usb: fix sparse warnings
Date: Mon, 29 Oct 2012 18:21:17 +0200 [thread overview]
Message-ID: <20121029162117.GL27566@arwen.pp.htv.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1210262128050.11258@utopia.booyaka.com>
[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]
On Fri, Oct 26, 2012 at 09:28:58PM +0000, Paul Walmsley wrote:
>
> Resolve the following sparse warnings:
>
> arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
> arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
> arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?
>
> by declaring those functions as static.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
>
> Applies on linux-omap/omap-for-v3.8/cleanup-headers.
>
> arch/arm/mach-omap1/usb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 84267ed..104fed3 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -301,7 +301,7 @@ static inline void otg_device_init(struct omap_usb_config *pdata)
>
> #endif
>
> -u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> +static u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> {
> u32 syscon1 = 0;
>
> @@ -409,7 +409,7 @@ u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> return syscon1 << 16;
> }
>
> -u32 __init omap1_usb1_init(unsigned nwires)
> +static u32 __init omap1_usb1_init(unsigned nwires)
> {
> u32 syscon1 = 0;
>
> @@ -475,7 +475,7 @@ bad:
> return syscon1 << 20;
> }
>
> -u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> +static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> {
> u32 syscon1 = 0;
>
> --
> 1.7.10.4
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP1: usb: fix sparse warnings
Date: Mon, 29 Oct 2012 18:21:17 +0200 [thread overview]
Message-ID: <20121029162117.GL27566@arwen.pp.htv.fi> (raw)
In-Reply-To: <alpine.DEB.2.00.1210262128050.11258@utopia.booyaka.com>
On Fri, Oct 26, 2012 at 09:28:58PM +0000, Paul Walmsley wrote:
>
> Resolve the following sparse warnings:
>
> arch/arm/mach-omap1/usb.c:304:12: warning: symbol 'omap1_usb0_init' was not declared. Should it be static?
> arch/arm/mach-omap1/usb.c:412:12: warning: symbol 'omap1_usb1_init' was not declared. Should it be static?
> arch/arm/mach-omap1/usb.c:478:12: warning: symbol 'omap1_usb2_init' was not declared. Should it be static?
>
> by declaring those functions as static.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
>
> Applies on linux-omap/omap-for-v3.8/cleanup-headers.
>
> arch/arm/mach-omap1/usb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/usb.c b/arch/arm/mach-omap1/usb.c
> index 84267ed..104fed3 100644
> --- a/arch/arm/mach-omap1/usb.c
> +++ b/arch/arm/mach-omap1/usb.c
> @@ -301,7 +301,7 @@ static inline void otg_device_init(struct omap_usb_config *pdata)
>
> #endif
>
> -u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> +static u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> {
> u32 syscon1 = 0;
>
> @@ -409,7 +409,7 @@ u32 __init omap1_usb0_init(unsigned nwires, unsigned is_device)
> return syscon1 << 16;
> }
>
> -u32 __init omap1_usb1_init(unsigned nwires)
> +static u32 __init omap1_usb1_init(unsigned nwires)
> {
> u32 syscon1 = 0;
>
> @@ -475,7 +475,7 @@ bad:
> return syscon1 << 20;
> }
>
> -u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> +static u32 __init omap1_usb2_init(unsigned nwires, unsigned alt_pingroup)
> {
> u32 syscon1 = 0;
>
> --
> 1.7.10.4
>
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121029/cecc3b45/attachment.sig>
next prev parent reply other threads:[~2012-10-29 16:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 20:52 [PATCH] ARM: OMAP1: usb: fix sparse warnings Paul Walmsley
2012-10-26 20:52 ` Paul Walmsley
2012-10-26 21:20 ` Tony Lindgren
2012-10-26 21:20 ` Tony Lindgren
2012-10-26 21:25 ` Paul Walmsley
2012-10-26 21:25 ` Paul Walmsley
2012-10-26 21:28 ` Tony Lindgren
2012-10-26 21:28 ` Tony Lindgren
2012-10-26 21:29 ` Paul Walmsley
2012-10-26 21:29 ` Paul Walmsley
2012-10-26 21:28 ` [PATCH v2] " Paul Walmsley
2012-10-26 21:28 ` Paul Walmsley
2012-10-26 21:33 ` Tony Lindgren
2012-10-26 21:33 ` Tony Lindgren
2012-10-29 16:21 ` Felipe Balbi [this message]
2012-10-29 16:21 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029162117.GL27566@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.