From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Balbir Singh
<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Subject: Re: [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts
Date: Wed, 31 Oct 2012 12:29:33 -0400 [thread overview]
Message-ID: <20121031162933.GB2305@cmpxchg.org> (raw)
In-Reply-To: <1351251453-6140-2-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
On Fri, Oct 26, 2012 at 01:37:28PM +0200, Michal Hocko wrote:
> mem_cgroup_force_empty did two separate things depending on free_all
> parameter from the very beginning. It either reclaimed as many pages as
> possible and moved the rest to the parent or just moved charges to the
> parent. The first variant is used as memory.force_empty callback while
> the later is used from the mem_cgroup_pre_destroy.
>
> The whole games around gotos are far from being nice and there is no
> reason to keep those two functions inside one. Let's split them and
> also move the responsibility for css reference counting to their callers
> to make to code easier.
>
> This patch doesn't have any functional changes.
>
> Signed-off-by: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
> Reviewed-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts
Date: Wed, 31 Oct 2012 12:29:33 -0400 [thread overview]
Message-ID: <20121031162933.GB2305@cmpxchg.org> (raw)
In-Reply-To: <1351251453-6140-2-git-send-email-mhocko@suse.cz>
On Fri, Oct 26, 2012 at 01:37:28PM +0200, Michal Hocko wrote:
> mem_cgroup_force_empty did two separate things depending on free_all
> parameter from the very beginning. It either reclaimed as many pages as
> possible and moved the rest to the parent or just moved charges to the
> parent. The first variant is used as memory.force_empty callback while
> the later is used from the mem_cgroup_pre_destroy.
>
> The whole games around gotos are far from being nice and there is no
> reason to keep those two functions inside one. Let's split them and
> also move the responsibility for css reference counting to their callers
> to make to code easier.
>
> This patch doesn't have any functional changes.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> Reviewed-by: Tejun Heo <tj@kernel.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts
Date: Wed, 31 Oct 2012 12:29:33 -0400 [thread overview]
Message-ID: <20121031162933.GB2305@cmpxchg.org> (raw)
In-Reply-To: <1351251453-6140-2-git-send-email-mhocko@suse.cz>
On Fri, Oct 26, 2012 at 01:37:28PM +0200, Michal Hocko wrote:
> mem_cgroup_force_empty did two separate things depending on free_all
> parameter from the very beginning. It either reclaimed as many pages as
> possible and moved the rest to the parent or just moved charges to the
> parent. The first variant is used as memory.force_empty callback while
> the later is used from the mem_cgroup_pre_destroy.
>
> The whole games around gotos are far from being nice and there is no
> reason to keep those two functions inside one. Let's split them and
> also move the responsibility for css reference counting to their callers
> to make to code easier.
>
> This patch doesn't have any functional changes.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> Reviewed-by: Tejun Heo <tj@kernel.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2012-10-31 16:29 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 11:37 memcg/cgroup: do not fail fail on pre_destroy callbacks Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-26 11:37 ` [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 13:45 ` Glauber Costa
2012-10-29 13:45 ` Glauber Costa
[not found] ` <1351251453-6140-2-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-31 16:29 ` Johannes Weiner [this message]
2012-10-31 16:29 ` Johannes Weiner
2012-10-31 16:29 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 13:48 ` Glauber Costa
2012-10-29 13:48 ` Glauber Costa
[not found] ` <508E8910.40203-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 13:52 ` Michal Hocko
2012-10-29 13:52 ` Michal Hocko
2012-10-29 13:52 ` Michal Hocko
[not found] ` <1351251453-6140-3-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-31 16:31 ` Johannes Weiner
2012-10-31 16:31 ` Johannes Weiner
2012-10-31 16:31 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 3/6] memcg: Simplify mem_cgroup_force_empty_list error handling Michal Hocko
2012-10-26 11:37 ` Michal Hocko
[not found] ` <1351251453-6140-4-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-29 13:58 ` Glauber Costa
2012-10-29 13:58 ` Glauber Costa
2012-10-29 13:58 ` Glauber Costa
[not found] ` <508E8B95.406-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:15 ` Michal Hocko
2012-10-29 14:15 ` Michal Hocko
2012-10-29 14:15 ` Michal Hocko
2012-10-29 15:09 ` Glauber Costa
2012-10-29 15:09 ` Glauber Costa
2012-10-29 22:00 ` Andrew Morton
2012-10-29 22:00 ` Andrew Morton
[not found] ` <20121029150022.a595b866.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-30 10:35 ` Michal Hocko
2012-10-30 10:35 ` Michal Hocko
2012-10-30 10:35 ` Michal Hocko
[not found] ` <20121030103559.GA7394-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-31 21:30 ` Andrew Morton
2012-10-31 21:30 ` Andrew Morton
2012-10-31 21:30 ` Andrew Morton
2012-11-13 21:10 ` Johannes Weiner
2012-11-13 21:10 ` Johannes Weiner
[not found] ` <20121113211041.GB1543-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-11-14 13:59 ` Michal Hocko
2012-11-14 13:59 ` Michal Hocko
2012-11-14 13:59 ` Michal Hocko
2012-11-14 18:33 ` Johannes Weiner
2012-11-14 18:33 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 4/6] cgroups: forbid pre_destroy callback to fail Michal Hocko
2012-10-26 11:37 ` Michal Hocko
[not found] ` <1351251453-6140-5-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-29 14:04 ` Glauber Costa
2012-10-29 14:04 ` Glauber Costa
2012-10-29 14:04 ` Glauber Costa
[not found] ` <508E8CDE.1090702-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:06 ` Glauber Costa
2012-10-29 14:06 ` Glauber Costa
2012-10-29 14:06 ` Glauber Costa
[not found] ` <508E8D6A.5040602-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:17 ` Michal Hocko
2012-10-29 14:17 ` Michal Hocko
2012-10-29 14:17 ` Michal Hocko
2012-11-13 21:13 ` Johannes Weiner
2012-11-13 21:13 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 5/6] memcg: make mem_cgroup_reparent_charges non failing Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 14:07 ` Glauber Costa
2012-10-29 14:07 ` Glauber Costa
2012-10-26 11:37 ` [PATCH v3 6/6] hugetlb: do not fail in hugetlb_cgroup_pre_destroy Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 14:08 ` Glauber Costa
2012-10-29 14:08 ` Glauber Costa
2012-10-29 23:26 ` memcg/cgroup: do not fail fail on pre_destroy callbacks Tejun Heo
2012-10-29 23:26 ` Tejun Heo
[not found] ` <20121029232602.GF4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-30 23:37 ` Michal Hocko
2012-10-30 23:37 ` Michal Hocko
2012-10-30 23:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031162933.GB2305@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.