From: Glauber Costa <glommer@parallels.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent
Date: Mon, 29 Oct 2012 17:48:00 +0400 [thread overview]
Message-ID: <508E8910.40203@parallels.com> (raw)
In-Reply-To: <1351251453-6140-3-git-send-email-mhocko@suse.cz>
On 10/26/2012 03:37 PM, Michal Hocko wrote:
> The root cgroup cannot be destroyed so we never hit it down the
> mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't
> even try to do anything if called for the root.
>
> This means that mem_cgroup_move_parent doesn't have to bother with the
> root cgroup and it can assume it can always move charges upwards.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> Reviewed-by: Tejun Heo <tj@kernel.org>
I think it would be safer to have this folded in the last patch, to
avoid a weird intermediate state (specially for force_empty). Being a
single statement, it doesn't confuse review so much.
However, this is also pretty much just a nitpick, do as you prefer.
Reviewed-by: Glauber Costa <glommer@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Glauber Costa <glommer@parallels.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: <linux-mm@kvack.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>
Subject: Re: [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent
Date: Mon, 29 Oct 2012 17:48:00 +0400 [thread overview]
Message-ID: <508E8910.40203@parallels.com> (raw)
In-Reply-To: <1351251453-6140-3-git-send-email-mhocko@suse.cz>
On 10/26/2012 03:37 PM, Michal Hocko wrote:
> The root cgroup cannot be destroyed so we never hit it down the
> mem_cgroup_pre_destroy path and mem_cgroup_force_empty_write shouldn't
> even try to do anything if called for the root.
>
> This means that mem_cgroup_move_parent doesn't have to bother with the
> root cgroup and it can assume it can always move charges upwards.
>
> Signed-off-by: Michal Hocko <mhocko@suse.cz>
> Reviewed-by: Tejun Heo <tj@kernel.org>
I think it would be safer to have this folded in the last patch, to
avoid a weird intermediate state (specially for force_empty). Being a
single statement, it doesn't confuse review so much.
However, this is also pretty much just a nitpick, do as you prefer.
Reviewed-by: Glauber Costa <glommer@parallels.com>
next prev parent reply other threads:[~2012-10-29 13:48 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 11:37 memcg/cgroup: do not fail fail on pre_destroy callbacks Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-26 11:37 ` [PATCH v3 1/6] memcg: split mem_cgroup_force_empty into reclaiming and reparenting parts Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 13:45 ` Glauber Costa
2012-10-29 13:45 ` Glauber Costa
[not found] ` <1351251453-6140-2-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-31 16:29 ` Johannes Weiner
2012-10-31 16:29 ` Johannes Weiner
2012-10-31 16:29 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 2/6] memcg: root_cgroup cannot reach mem_cgroup_move_parent Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 13:48 ` Glauber Costa [this message]
2012-10-29 13:48 ` Glauber Costa
[not found] ` <508E8910.40203-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 13:52 ` Michal Hocko
2012-10-29 13:52 ` Michal Hocko
2012-10-29 13:52 ` Michal Hocko
[not found] ` <1351251453-6140-3-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-31 16:31 ` Johannes Weiner
2012-10-31 16:31 ` Johannes Weiner
2012-10-31 16:31 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 3/6] memcg: Simplify mem_cgroup_force_empty_list error handling Michal Hocko
2012-10-26 11:37 ` Michal Hocko
[not found] ` <1351251453-6140-4-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-29 13:58 ` Glauber Costa
2012-10-29 13:58 ` Glauber Costa
2012-10-29 13:58 ` Glauber Costa
[not found] ` <508E8B95.406-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:15 ` Michal Hocko
2012-10-29 14:15 ` Michal Hocko
2012-10-29 14:15 ` Michal Hocko
2012-10-29 15:09 ` Glauber Costa
2012-10-29 15:09 ` Glauber Costa
2012-10-29 22:00 ` Andrew Morton
2012-10-29 22:00 ` Andrew Morton
[not found] ` <20121029150022.a595b866.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-10-30 10:35 ` Michal Hocko
2012-10-30 10:35 ` Michal Hocko
2012-10-30 10:35 ` Michal Hocko
[not found] ` <20121030103559.GA7394-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-10-31 21:30 ` Andrew Morton
2012-10-31 21:30 ` Andrew Morton
2012-10-31 21:30 ` Andrew Morton
2012-11-13 21:10 ` Johannes Weiner
2012-11-13 21:10 ` Johannes Weiner
[not found] ` <20121113211041.GB1543-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-11-14 13:59 ` Michal Hocko
2012-11-14 13:59 ` Michal Hocko
2012-11-14 13:59 ` Michal Hocko
2012-11-14 18:33 ` Johannes Weiner
2012-11-14 18:33 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 4/6] cgroups: forbid pre_destroy callback to fail Michal Hocko
2012-10-26 11:37 ` Michal Hocko
[not found] ` <1351251453-6140-5-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2012-10-29 14:04 ` Glauber Costa
2012-10-29 14:04 ` Glauber Costa
2012-10-29 14:04 ` Glauber Costa
[not found] ` <508E8CDE.1090702-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:06 ` Glauber Costa
2012-10-29 14:06 ` Glauber Costa
2012-10-29 14:06 ` Glauber Costa
[not found] ` <508E8D6A.5040602-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-10-29 14:17 ` Michal Hocko
2012-10-29 14:17 ` Michal Hocko
2012-10-29 14:17 ` Michal Hocko
2012-11-13 21:13 ` Johannes Weiner
2012-11-13 21:13 ` Johannes Weiner
2012-10-26 11:37 ` [PATCH v3 5/6] memcg: make mem_cgroup_reparent_charges non failing Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 14:07 ` Glauber Costa
2012-10-29 14:07 ` Glauber Costa
2012-10-26 11:37 ` [PATCH v3 6/6] hugetlb: do not fail in hugetlb_cgroup_pre_destroy Michal Hocko
2012-10-26 11:37 ` Michal Hocko
2012-10-29 14:08 ` Glauber Costa
2012-10-29 14:08 ` Glauber Costa
2012-10-29 23:26 ` memcg/cgroup: do not fail fail on pre_destroy callbacks Tejun Heo
2012-10-29 23:26 ` Tejun Heo
[not found] ` <20121029232602.GF4066-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2012-10-30 23:37 ` Michal Hocko
2012-10-30 23:37 ` Michal Hocko
2012-10-30 23:37 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E8910.40203@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.