From: Stephen Hemminger <shemminger@vyatta.com>
To: George Zhang <georgezhang@vmware.com>
Cc: pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
gregkh@linuxfoundation.org, vm-crosstalk@vmware.com,
davem@davemloft.net
Subject: Re: [PATCH 1/6] VSOCK: vsock protocol implementation.
Date: Tue, 6 Nov 2012 10:10:13 +0100 [thread overview]
Message-ID: <20121106101013.09806f81@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <20121105180043.21472.95003.stgit@promb-2n-dhcp175.eng.vmware.com>
On Mon, 05 Nov 2012 10:00:51 -0800
George Zhang <georgezhang@vmware.com> wrote:
> + /* Added in 2.6.10. */
> + .owner = THIS_MODULE,
Thanks for submitting this, it will make life easier for distro's
that now have to go through extra effort to include out of mainline
support for Vmware.
You did some scrubbing of the macro's to support multiple kernel
versions, but there are still some leftovers.
This code seems to have a lot of "this added in version xxx"
type comments. These are probably not a good idea to include
in the mainline kernel code.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@vyatta.com>
To: George Zhang <georgezhang@vmware.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pv-drivers@vmware.com,
vm-crosstalk@vmware.com, davem@davemloft.net,
gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/6] VSOCK: vsock protocol implementation.
Date: Tue, 6 Nov 2012 10:10:13 +0100 [thread overview]
Message-ID: <20121106101013.09806f81@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <20121105180043.21472.95003.stgit@promb-2n-dhcp175.eng.vmware.com>
On Mon, 05 Nov 2012 10:00:51 -0800
George Zhang <georgezhang@vmware.com> wrote:
> + /* Added in 2.6.10. */
> + .owner = THIS_MODULE,
Thanks for submitting this, it will make life easier for distro's
that now have to go through extra effort to include out of mainline
support for Vmware.
You did some scrubbing of the macro's to support multiple kernel
versions, but there are still some leftovers.
This code seems to have a lot of "this added in version xxx"
type comments. These are probably not a good idea to include
in the mainline kernel code.
next prev parent reply other threads:[~2012-11-06 9:10 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 18:00 [PATCH 0/6] VSOCK for Linux upstreaming George Zhang
2012-11-05 18:00 ` [PATCH 1/6] VSOCK: vsock protocol implementation George Zhang
2012-11-06 9:10 ` Stephen Hemminger [this message]
2012-11-06 9:10 ` Stephen Hemminger
2012-11-06 14:31 ` [Pv-drivers] " Andy King
2012-11-05 18:01 ` [PATCH 2/6] VSOCK: vsock address implementaion George Zhang
2012-11-05 18:01 ` [PATCH 3/6] VSOCK: notification implementation George Zhang
2012-11-05 18:01 ` [PATCH 4/6] VSOCK: statistics implementation George Zhang
2012-11-05 18:01 ` [PATCH 5/6] VSOCK: utility functions George Zhang
2012-11-05 18:01 ` George Zhang
2012-11-05 18:01 ` [PATCH 6/6] VSOCK: header and config files George Zhang
2012-11-05 18:09 ` [PATCH 0/6] VSOCK for Linux upstreaming David Miller
2012-11-05 18:09 ` David Miller
2012-11-05 18:10 ` David Miller
2012-11-05 18:10 ` David Miller
2012-11-05 18:24 ` George Zhang
2012-11-05 18:24 ` George Zhang
2012-11-05 18:19 ` [Pv-drivers] " Andy King
2012-11-07 6:58 ` Gerd Hoffmann
2012-11-07 6:58 ` Gerd Hoffmann
2012-11-08 15:47 ` Andy King
2012-11-08 15:47 ` Andy King
2012-11-15 21:32 ` Anthony Liguori
2012-11-19 9:59 ` Benjamin Herrenschmidt
2012-11-19 9:59 ` Benjamin Herrenschmidt
2012-12-06 15:28 ` Andy King
2012-12-06 15:28 ` Andy King
2012-11-15 21:32 ` Anthony Liguori
2012-11-05 18:23 ` Sasha Levin
2012-11-05 18:23 ` Sasha Levin
2012-11-05 18:32 ` George Zhang
2012-11-05 18:32 ` George Zhang
2012-11-11 21:59 ` Sasha Levin
2012-11-11 21:59 ` Sasha Levin
2012-11-14 16:42 ` [Pv-drivers] " Andy King
2012-11-06 9:00 ` Stephen Hemminger
2012-11-06 9:00 ` Stephen Hemminger
2012-11-06 9:06 ` Stephen Hemminger
2012-11-06 9:06 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 23:59 George Zhang
2013-01-08 23:59 ` [PATCH 1/6] VSOCK: vsock protocol implementation George Zhang
2012-11-21 20:39 [PATCH 0/6] VSOCK for Linux upstreaming George Zhang
2012-11-21 20:39 ` [PATCH 1/6] VSOCK: vsock protocol implementation George Zhang
2012-11-07 18:45 [PATCH 0/6] VSOCK for Linux upstreaming George Zhang
2012-11-07 18:45 ` [PATCH 1/6] VSOCK: vsock protocol implementation George Zhang
2012-10-16 0:31 [PATCH 0/6] VSOCK for Linux upstreaming George Zhang
2012-10-16 0:32 ` [PATCH 1/6] VSOCK: vsock protocol implementation George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121106101013.09806f81@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vm-crosstalk@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.